lemo added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413
+section->GetName().GetCString(),
+llvm::toString(Decompressor.takeError()).c_str());
+return 0;
labath wrote:
> lemo wrote:
> > labath wrote:
> > > T
lemo updated this revision to Diff 159432.
lemo marked an inline comment as done.
lemo added a comment.
Updated the LIT file too
https://reviews.llvm.org/D50274
Files:
lit/Modules/compressed-sections.yaml
source/Core/Module.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plug
teemperor updated this revision to Diff 159426.
teemperor added a comment.
- Resolved merge conflicts.
https://reviews.llvm.org/D48465
Files:
include/lldb/Expression/ExpressionParser.h
include/lldb/Expression/UserExpression.h
packages/Python/lldbsuite/test/expression_command/completion/.c
xiaobai added a comment.
Can't speak much to the contents yet (Haven't done a thorough pass yet) but it
looks like there's a lot of dead code you might want to remove. I commented on
a few of them but there is probably more.
Comment at:
packages/Python/lldbsuite/test/tools/l
Author: stella.stamenova
Date: Mon Aug 6 15:37:53 2018
New Revision: 339076
URL: http://llvm.org/viewvc/llvm-project?rev=339076&view=rev
Log:
[lit, python] Always add quotes around the python path in lit
Summary:
The issue with the python path is that the path to python on Windows can
contain s
Author: sas
Date: Mon Aug 6 15:21:28 2018
New Revision: 339071
URL: http://llvm.org/viewvc/llvm-project?rev=339071&view=rev
Log:
Revert "Add a relocation for R_AARCH64_ABS32 in ObjectFileELF"
This reverts commit f055ce7eb893cd0d17ebcfd4125018f46f983aff.
Modified:
lldb/trunk/source/Plugins/O
You should be able to add a unittest for this, I think?
--
Davide
On Mon, Aug 6, 2018 at 3:04 PM Stephane Sezer via lldb-commits
wrote:
>
> Author: sas
> Date: Mon Aug 6 15:04:08 2018
> New Revision: 339068
>
> URL: http://llvm.org/viewvc/llvm-project?rev=339068&view=rev
> Log:
> Add a relocatio
Author: sas
Date: Mon Aug 6 15:04:08 2018
New Revision: 339068
URL: http://llvm.org/viewvc/llvm-project?rev=339068&view=rev
Log:
Add a relocation for R_AARCH64_ABS32 in ObjectFileELF
Summary:
.rela.debug_info relocations are being done via
ObjectFileELF::ApplyRelocations for aarch64. Currently,
xiaobai updated this revision to Diff 159400.
xiaobai added a comment.
Reducing redundancy and changing some wording around.
https://reviews.llvm.org/D50362
Files:
www/build.html
Index: www/build.html
===
--- www/build.html
+++
labath added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413
+section->GetName().GetCString(),
+llvm::toString(Decompressor.takeError()).c_str());
+return 0;
lemo wrote:
> labath wrote:
> > This needs to be `s
lemo added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413
+section->GetName().GetCString(),
+llvm::toString(Decompressor.takeError()).c_str());
+return 0;
labath wrote:
> This needs to be `std::move(Error)`.
Author: vedantk
Date: Mon Aug 6 13:13:52 2018
New Revision: 339051
URL: http://llvm.org/viewvc/llvm-project?rev=339051&view=rev
Log:
[IRMemoryMap] Avoid redundant zero-init in the Allocation constructor (NFC)
In the lldb-bench/arithmetic benchmark, 1.7% of the total running time
is spent zero-in
labath added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413
+section->GetName().GetCString());
+return 0;
}
lemo wrote:
> labath wrote:
> > `lit/Modules/compressed-sections.yaml` test will need to be updated to
>
lemo marked 2 inline comments as done.
lemo added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413
+section->GetName().GetCString());
+return 0;
}
labath wrote:
> `lit/Modules/compressed-sections.yaml` test will nee
lemo updated this revision to Diff 159368.
lemo added a comment.
Incorporating feedback, thanks.
https://reviews.llvm.org/D50274
Files:
source/Core/Module.cpp
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
source/Plugins/Process/minidump/ProcessMinidump.cpp
source/Target/Process.cpp
I
nealsid added a comment.
In https://reviews.llvm.org/D49963#1183036, @clayborg wrote:
> This will be very cool. Biggest issues to watch out for is to make sure it
> doesn't return incorrect values when running for things like the thread
> count. If you switch to use the
> "m_debugger.GetComman
jingham added a comment.
In https://reviews.llvm.org/D49740#1188587, @labath wrote:
> In https://reviews.llvm.org/D49740#1188055, @jingham wrote:
>
> > First off, I'm fine with Zachary's suggestion that we let the dust settle a
> > bit before we try to organize things better. We'll probably do
vsk updated this revision to Diff 159339.
vsk retitled this revision from "[IRMemoryMap] Shrink Allocation by
sizeof(addr_t) (NFC)" to "[IRMemoryMap] Shrink Allocation make it move-only
(NFC)".
vsk edited the summary of this revision.
vsk added a comment.
- Make Allocation move-only. This should
clayborg added a comment.
More offsetof issues:
$ svn commit
Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp
Transmitting file data .done
Committing transaction...
Committed revision 339034.
Repository:
rL LLVM
https://reviews.llvm.org/D50336
___
Author: gclayton
Date: Mon Aug 6 10:26:53 2018
New Revision: 339034
URL: http://llvm.org/viewvc/llvm-project?rev=339034&view=rev
Log:
Fix more offsetof issues.
Modified:
lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp
Modified:
lldb/trunk/source/Plugins/Process/
jingham added a comment.
This implementation forces an extra lookup when the line number slides. For
instance, if there were only one line match, but it was not exact, you're going
to look up the exact address, fail, then look it up with exact = false.
Wouldn't it be more efficient to look wit
clayborg added a comment.
Passing patches between linux and mac the offsetof fixes got lost. When binary
files are involved, patches are trickier to pass between to machines.
Repository:
rL LLVM
https://reviews.llvm.org/D50336
___
lldb-commits m
clayborg added a comment.
Fixed offsetof issues with:
$ svn commit
Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp
Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp
Transmitting file data ..done
Committing transaction...
Committed revi
Author: gclayton
Date: Mon Aug 6 10:07:50 2018
New Revision: 339033
URL: http://llvm.org/viewvc/llvm-project?rev=339033&view=rev
Log:
Fix offsetof usage that got lost when passing patches between linux and mac.
Modified:
lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339032: Add support for ARM and ARM64 breakpad generated
minidump files (version 2). (authored by gclayton, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB339032: Add support for ARM and ARM64 breakpad generated
minidump files (version 2). (authored by gclayton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50336?vs=159324&id=15932
Author: gclayton
Date: Mon Aug 6 09:56:10 2018
New Revision: 339032
URL: http://llvm.org/viewvc/llvm-project?rev=339032&view=rev
Log:
Add support for ARM and ARM64 breakpad generated minidump files (version 2).
In this patch I add support for ARM and ARM64 break pad files. There are two
flavors
clayborg updated this revision to Diff 159324.
clayborg added a comment.
Herald added a subscriber: mgorny.
Added CMakeList.txt changes, tested on linux, and removed unused "log" variable.
https://reviews.llvm.org/D50336
Files:
include/lldb/Target/Target.h
lldb.xcodeproj/project.pbxproj
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This should be fine once the cmake thing is addressed.
https://reviews.llvm.org/D50336
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
I was in the process of testing on linux. I will fix this.
> On Aug 6, 2018, at 8:19 AM, Zachary Turner wrote:
>
> Did you see my comments on the first round about how the CMake build didn’t
> work? Because I don’t see any changes to CMakeLists.txt here, which means it
> still won’t work.
>
zturner added a subscriber: clayborg.
zturner added a comment.
Did you see my comments on the first round about how the CMake build didn’t
work? Because I don’t see any changes to CMakeLists.txt here, which means
it still won’t work.
The easiest way to make sure you get all the fixes that may hav
Did you see my comments on the first round about how the CMake build didn’t
work? Because I don’t see any changes to CMakeLists.txt here, which means
it still won’t work.
The easiest way to make sure you get all the fixes that may have gone in
after your initial commit is to revert the revert and
clayborg created this revision.
clayborg added reviewers: labath, zturner, markmentovai, javed.absar.
Herald added subscribers: chrib, kristof.beyls.
In this patch I add support for ARM and ARM64 break pad files. There are two
flavors of ARM: Apple where FP is https://reviews.llvm.org/source/open
I am OOO this week and only have access to mobile, so hopefully someone
else can review it
On Mon, Aug 6, 2018 at 11:05 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> Ping!
>
> Can you review this, please?
>
>
> https://reviews.llvm.o
zturner added a subscriber: aleksandr.urakov.
zturner added a comment.
I am OOO this week and only have access to mobile, so hopefully someone
else can review it
https://reviews.llvm.org/D49980
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
aleksandr.urakov added a comment.
Ping!
Can you review this, please?
https://reviews.llvm.org/D49980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
In general, I would assume that a function taking a StringRef can take *any*
StringRef object (including the non-terminated ones), unless the limitations
are very clearly documented.
That sai
sgraenitz created this revision.
sgraenitz added a reviewer: labath.
It was not immediately clear to me whether or not non-null-terminated
StringRef's are supported in ConstString and/or the counterpart mechanism. From
this test it seems to be fine. Maybe useful to keep?
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339014: Add ConstString::IsNull() to tell between null vs.
empty strings and fix usage… (authored by stefan.graenitz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
Author: stefan.graenitz
Date: Mon Aug 6 07:15:21 2018
New Revision: 339015
URL: http://llvm.org/viewvc/llvm-project?rev=339015&view=rev
Log:
Fix Mangled::Compare()
Modified:
lldb/trunk/source/Core/Mangled.cpp
Modified: lldb/trunk/source/Core/Mangled.cpp
URL:
http://llvm.org/viewvc/llvm-pro
Author: stefan.graenitz
Date: Mon Aug 6 07:15:17 2018
New Revision: 339014
URL: http://llvm.org/viewvc/llvm-project?rev=339014&view=rev
Log:
Add ConstString::IsNull() to tell between null vs. empty strings and fix usage
in Mangled::GetDemangledName()
Summary: `IsEmpty()` and `operator bool() ==
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for splitting this out.
https://reviews.llvm.org/D50327
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
sgraenitz added a comment.
Ok I will fix the details, rebase and update the review.
Btw: I also spilt off the `ConstString::IsNull()` addition with unit test and
fix in `Mangled` to https://reviews.llvm.org/D50327
Comment at: source/Core/RichManglingInfo.cpp:126
+ case Itani
sgraenitz created this revision.
sgraenitz added reviewers: labath, jingham.
Herald added a subscriber: erik.pilkington.
`IsEmpty()` and `operator bool() == false` have equal semantics. Usage in
Mangled::GetDemangledName() was incorrect. What it actually wants is a check
for null-string. Split t
labath added a comment.
I think we're getting there, but all these changes mean I have another round of
comments. None of them should be major though.
I'm also wondering whether it wouldn't be good to add a couple (one for each
mangling scheme?) unit tests for the new class, as a way to show th
labath added a comment.
In https://reviews.llvm.org/D50161#1187972, @teemperor wrote:
> StreamTee is copying it, which is expected to be copyable when we copy
> CommandObjectResult around. And then I just added the copy-constructor as
> CommandObjectResult refactoring sound time-expensive.
Su
46 matches
Mail list logo
