[Lldb-commits] [PATCH] D50317: Remove duplicated code in CommandObjectQuit

2018-08-05 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL338976: Remove duplicated code in CommandObjectQuit (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50317?vs=159237&id

[Lldb-commits] [lldb] r338976 - Remove duplicated code in CommandObjectQuit

2018-08-05 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sun Aug 5 17:04:51 2018 New Revision: 338976 URL: http://llvm.org/viewvc/llvm-project?rev=338976&view=rev Log: Remove duplicated code in CommandObjectQuit Summary: We already have the same check directly before, so this code can never be reached (as seen in the test cover

[Lldb-commits] [PATCH] D50317: Remove duplicated code in CommandObjectQuit

2018-08-05 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Sure. Repository: rLLDB LLDB https://reviews.llvm.org/D50317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

[Lldb-commits] [PATCH] D50317: Remove duplicated code in CommandObjectQuit

2018-08-05 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. We already have the same check directly before, so this code can never be reached (as seen in the test coverage). Repository: rLLDB LLDB https://reviews.llvm.org/D50317 Files: source/Commands/CommandObjectQuit.cpp Index: source/Commands/CommandObjectQuit.

[Lldb-commits] [PATCH] D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers

2018-08-05 Thread Venkata Ramanaiah Nalamothu via Phabricator via lldb-commits
ramana-nvr created this revision. ramana-nvr added a reviewer: jingham. The requirements for "thread until " are: a) If any code contributed by or the nearest subsequent of is executed before leaving the function, stop b) If you end up leaving the function w/o triggering (a), then stop In case