jankratochvil updated this revision to Diff 158176.
https://reviews.llvm.org/D49969
Files:
source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.h
source/Plugins/SymbolFile/DWARF/NameToDIE.cpp
source/Plugins/SymbolFile/DWARF/NameToDIE.h
Ind
xiaobai added a comment.
Using this patch, I was able to build the lldb framework and install it. I
configured with:
cmake .. -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLDB_CODESIGN_IDENTITY=""
-DLLDB_BUILD_FRAMEWORK=1 -DLLDB_USE_SYSTEM_SIX=1 -DCMAKE_INSTALL_PREFIX=""
-DLLVM_TARGETS_TO_BUILD="X8
xiaobai created this revision.
xiaobai added reviewers: labath, sas.
Herald added a subscriber: mgorny.
Previously, I thought that install-liblldb would fail because CMake had
a bug related to installing frameworks. In actuality, I misunderstood the
semantics of `add_custom_target`: the DEPENDS op
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338345: Remove Stream::UnitTest (authored by teemperor,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50026?vs=158120&id=158151#toc
Reposit
Author: teemperor
Date: Mon Jul 30 18:21:36 2018
New Revision: 338345
URL: http://llvm.org/viewvc/llvm-project?rev=338345&view=rev
Log:
Remove Stream::UnitTest
Summary: No one is using this method, and it also doesn't really make a lot of
sense to have it around.
Reviewers: davide
Reviewed By:
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D50026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/ll
teemperor updated this revision to Diff 158127.
teemperor added a comment.
- Removed MaxHex64 test (which moved to the child revision to be in the same
commit as the related bug).
https://reviews.llvm.org/D50027
Files:
unittests/Utility/CMakeLists.txt
unittests/Utility/StreamTest.cpp
Inde
teemperor updated this revision to Diff 158126.
teemperor edited the summary of this revision.
teemperor added a comment.
- Reverse patch dependencies that we can add the unit test here (but also means
this has to wait until the StreamTest is in).
https://reviews.llvm.org/D50025
Files:
sourc
teemperor added a comment.
Yeah, on a second thought I should just strip out the parts of the unit test
that found this bug and commit them alongside this.
https://reviews.llvm.org/D50025
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
teemperor created this revision.
Herald added a subscriber: mgorny.
This adds an initial small unit test for LLDB's Stream class, which should at
least cover
most of the functions in the Stream class. StreamString is always in big endian
mode, so that's the only stream byte order path this test c
shafik added a comment.
@davide @labath I believe I have addressed both the C++17 filter and the libc++
filter. Please let me know if you have further comments.
https://reviews.llvm.org/D49271
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
shafik updated this revision to Diff 158121.
shafik added a comment.
Adjust test to filter on clang version and libc++ version to precent build bots
from failing due to lack of C++17 or lack of optional support
https://reviews.llvm.org/D49271
Files:
lldb.xcodeproj/project.pbxproj
packages
zturner added a comment.
When is the Stream unit test coming? Maybe we should just add it first, then
add this?
https://reviews.llvm.org/D50025
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
teemperor created this revision.
No one is using this method, and it also doesn't really make a lot of sense to
have it around.
https://reviews.llvm.org/D50026
Files:
include/lldb/Utility/Stream.h
source/Utility/Stream.cpp
Index: source/Utility/Stream.cpp
teemperor created this revision.
Note: We don't have a unittest for Stream yet, so the regression test for this
will be added with the
upcoming Stream unit test.
https://reviews.llvm.org/D50025
Files:
source/Utility/Stream.cpp
Index: source/Utility/Stream.cpp
==
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338311: Remove unnecessary newlines from break command help
text. (authored by teemperor, committed by ).
Herald added a s
Author: teemperor
Date: Mon Jul 30 14:41:13 2018
New Revision: 338311
URL: http://llvm.org/viewvc/llvm-project?rev=338311&view=rev
Log:
Remove unnecessary newlines from break command help text.
Summary:
We usually don't have trailing newlines in the short help strings. This just
adds
unnecessary
teemperor created this revision.
We usually don't have trailing newlines in the short help strings. This just
adds
unnecessary extra lines when printing the help text of these commands.
https://reviews.llvm.org/D50015
Files:
source/Interpreter/CommandInterpreter.cpp
Index: source/Interpret
EugeneBi added a comment.
In https://reviews.llvm.org/D49685#1179837, @labath wrote:
> In https://reviews.llvm.org/D49685#1178730, @EugeneBi wrote:
>
> > I looked at the tests - is it all in Python? Not sure I have time to learn
> > a new language... Is there anything in C++?
>
>
> We have unit
sgraenitz marked 3 inline comments as done.
sgraenitz added a comment.
Sorry, I accidentally added the tests from https://reviews.llvm.org/D49909 also
to this review. I will clean this up tomorrow.
https://reviews.llvm.org/D49990
___
lldb-commits m
sgraenitz updated this revision to Diff 158044.
sgraenitz added a comment.
Moved forward decls
https://reviews.llvm.org/D49990
Files:
include/lldb/Core/Mangled.h
include/lldb/Symbol/Symtab.h
include/lldb/Utility/ConstString.h
include/lldb/lldb-forward.h
source/Core/Mangled.cpp
sourc
FYI, Breakpad & Crashpad will start generating the Microsoft flavor of ARM
minidumps soon.
On Wed, Jul 25, 2018 at 9:44 AM, Leonard Mosescu via Phabricator <
revi...@reviews.llvm.org> wrote:
> lemo added inline comments.
>
>
>
> Comment at: source/Plugins/Process/minidump/Registe
lemo added subscribers: clayborg, labath, markmentovai, t.p.northover, zturner.
lemo added a comment.
FYI, Breakpad & Crashpad will start generating the Microsoft flavor of ARM
minidumps soon.
https://reviews.llvm.org/D49750
___
lldb-commits mailing
sgraenitz updated this revision to Diff 158041.
sgraenitz added a comment.
Herald added a subscriber: mgorny.
Simple fixes
https://reviews.llvm.org/D49990
Files:
include/lldb/Core/Mangled.h
include/lldb/Symbol/Symtab.h
include/lldb/Utility/ConstString.h
include/lldb/lldb-forward.h
sou
apolyakov added a comment.
In https://reviews.llvm.org/D49632#1180465, @clayborg wrote:
> I still don't get why we are printing process stopped information to STDOUT.
> MI is a machine interface for a IDE. The IDE should be showing the process
> state in the GUI.
AFAIK, all lldb-mi commands p
sgraenitz added inline comments.
Comment at: source/Symbol/Symtab.cpp:274
+ case ItaniumPartialDemangler:
+m_IPD_buf = m_IPD->getFunctionBaseName(m_IPD_buf, &m_IPD_size);
+return m_IPD_buf;
erik.pilkington wrote:
> sgraenitz wrote:
> > @erik.pilkington I
zturner added inline comments.
Comment at: include/lldb/Symbol/Symtab.h:58
+ /// dependency. Keep a void* here instead and cast it on-demand on the cpp.
+ void *m_legacy_parser = nullptr;
+
sgraenitz wrote:
> sgraenitz wrote:
> > zturner wrote:
> > > sgraenitz
sgraenitz added inline comments.
Comment at: include/lldb/Symbol/Symtab.h:58
+ /// dependency. Keep a void* here instead and cast it on-demand on the cpp.
+ void *m_legacy_parser = nullptr;
+
sgraenitz wrote:
> zturner wrote:
> > sgraenitz wrote:
> > > This is
clayborg added a comment.
I still don't get why we are printing process stopped information to STDOUT. MI
is a machine interface for a IDE. The IDE should be showing the process state
in the GUI.
https://reviews.llvm.org/D49632
___
lldb-commits ma
erik.pilkington added inline comments.
Comment at: source/Symbol/Symtab.cpp:274
+ case ItaniumPartialDemangler:
+m_IPD_buf = m_IPD->getFunctionBaseName(m_IPD_buf, &m_IPD_size);
+return m_IPD_buf;
sgraenitz wrote:
> @erik.pilkington Is it acceptable/good
sgraenitz added a comment.
Thanks or the quick reviews! Follow-ups inline.
Comment at: include/lldb/Symbol/Symtab.h:58
+ /// dependency. Keep a void* here instead and cast it on-demand on the cpp.
+ void *m_legacy_parser = nullptr;
+
zturner wrote:
> sgraenit
clayborg added inline comments.
Comment at: include/lldb/Core/Mangled.h:25-34
+namespace lldb_private {
+class RichManglingInfo;
+class RichManglingSpec;
+}
namespace lldb_private {
class RegularExpression;
}
move any forward decls to lldb-forward.h and remove
sgraenitz added inline comments.
Comment at: source/Symbol/Symtab.cpp:274
+ case ItaniumPartialDemangler:
+m_IPD_buf = m_IPD->getFunctionBaseName(m_IPD_buf, &m_IPD_size);
+return m_IPD_buf;
@erik.pilkington Is it acceptable/good practice to pass `(nullpt
zturner added inline comments.
Comment at: include/lldb/Symbol/Symtab.h:58
+ /// dependency. Keep a void* here instead and cast it on-demand on the cpp.
+ void *m_legacy_parser = nullptr;
+
sgraenitz wrote:
> This is the hackiest point I guess.
We have `llvm::A
labath added a comment.
I haven't read through this in detail yet, but I think this is a good start!
The part I'm not sure about is whether the RichManglingInfo vs.
RichManglingSpec distinction brings any value. I mean, the lifetime of the
first is tied to the lifetime of the second, and the Sp
sgraenitz added inline comments.
Comment at: include/lldb/Symbol/Symtab.h:43
+private:
+ enum InfoProvider { ItaniumPartialDemangler, PluginCxxLanguage };
+
We don't need a None-case here.
Comment at: include/lldb/Symbol/Symtab.h:58
+ /// dep
sgraenitz created this revision.
sgraenitz added reviewers: labath, jingham, JDevlieghere, erik.pilkington.
This review is about getting your feedback for the patch. If it doesn't make it
in this form, I can adjust everything that's necessary and open a new review
once I am done. So please don't
aleksandr.urakov added inline comments.
Comment at: lit/SymbolFile/PDB/udt-layout.test:1-51
+REQUIRES: windows
+RUN: clang-cl /Zi %S/Inputs/UdtLayoutTest.cpp /o %t.exe
+RUN: %lldb -b -s %S/Inputs/UdtLayoutTest.script -- %t.exe | FileCheck %s
+
+CHECK:(int) int C::abc = 123
+CHECK
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: asmith, zturner, rnk, labath, clayborg,
lldb-commits.
Herald added a subscriber: JDevlieghere.
In this patch I've tried to combine the best ideas from
https://reviews.llvm.org/D49368 and https://reviews.llvm.org/D49410, so
labath added a comment.
Thanks for looking out for the bots.
I am afraid the compiler check will not be enough here. After that, you'll run
into the issue of the system libc++ not being recent enough to contain
std::optional. I suppose this could be handled by including some other header
first
labath added a comment.
In https://reviews.llvm.org/D49685#1178730, @EugeneBi wrote:
> I looked at the tests - is it all in Python? Not sure I have time to learn a
> new language... Is there anything in C++?
We have unit tests in c++, but it's going to be quite hard to tickle this code
path f
41 matches
Mail list logo
