Author: jmolenda
Date: Wed Jun 13 18:29:18 2018
New Revision: 334680
URL: http://llvm.org/viewvc/llvm-project?rev=334680&view=rev
Log:
fix cmake include path.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/
Author: jdevlieghere
Date: Wed Jun 13 15:54:52 2018
New Revision: 334668
URL: http://llvm.org/viewvc/llvm-project?rev=334668&view=rev
Log:
[FileSpec] Make style argument mandatory for SetFile. NFC
Update SetFile uses in the unittests.
Modified:
lldb/trunk/unittests/Host/SymbolsTest.cpp
l
Author: jmolenda
Date: Wed Jun 13 15:37:01 2018
New Revision: 334667
URL: http://llvm.org/viewvc/llvm-project?rev=334667&view=rev
Log:
Move the header file to be in the same new place as the .mm file.
Added:
lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSu
Author: jmolenda
Date: Wed Jun 13 15:33:27 2018
New Revision: 334666
URL: http://llvm.org/viewvc/llvm-project?rev=334666&view=rev
Log:
Fix group entry.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org/viewvc/llvm-pr
Author: jdevlieghere
Date: Wed Jun 13 15:23:48 2018
New Revision: 334664
URL: http://llvm.org/viewvc/llvm-project?rev=334664&view=rev
Log:
[FileSpec] Make style argument mandatory for SetFile. NFC
Fix SetFile uses in hosts that I missed in r334663.
Modified:
lldb/trunk/source/Host/freebsd/Ho
Author: jdevlieghere
Date: Wed Jun 13 15:08:14 2018
New Revision: 334663
URL: http://llvm.org/viewvc/llvm-project?rev=334663&view=rev
Log:
[FileSpec] Make style argument mandatory for SetFile. NFC
SetFile has an optional style argument which defaulted to the native
style. This patch makes that ar
Author: jmolenda
Date: Wed Jun 13 15:05:38 2018
New Revision: 334662
URL: http://llvm.org/viewvc/llvm-project?rev=334662&view=rev
Log:
Fix macos xcode build.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
lldb/trunk/source/Host/macosx/objcxx/Host.mm
Modified: lldb/trunk/lldb.xcodepr
I like seeing the windows debugger plug-in getting fixes.
LLDB currently encourages everyone to add native debugging support to
lldb-server. Then you get remote debugging support for free. It seems like you
are putting in some time on the windows fixes, so I thought I would pass this
along. The
Author: stella.stamenova
Date: Wed Jun 13 12:02:44 2018
New Revision: 334642
URL: http://llvm.org/viewvc/llvm-project?rev=334642&view=rev
Log:
[lit] Split test_set_working_dir TestProcessLaunch into two tests and fix it on
Windows
Summary:
test_set_working_dir was testing two scenario: failure t
aprantl added a comment.
I'm getting a new warning now, can you also reproduce this?
In file included from :21:
In file included from ../tools/lldb/include/lldb/Host/MainLoop.h:13:
tools/lldb/include/lldb/Host/Config.h:33:9: warning: 'HAVE_LIBCOMPRESSION'
macro redefined [-Wmacro-redefined
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334638: [ObjC] Add dataformatter for NSDecimalNumber
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48114?vs=151096&id=151217#toc
Repository:
rL LLVM
h
Author: jdevlieghere
Date: Wed Jun 13 11:47:04 2018
New Revision: 334638
URL: http://llvm.org/viewvc/llvm-project?rev=334638&view=rev
Log:
[ObjC] Add dataformatter for NSDecimalNumber
This patch adds a data formatter for NSDecimalNumber. The latter is a
Foundation object used for representing and
jingham added a comment.
SBTarget.Attach, and Launch take SBError references, and they are pretty well
tested. So I don't think that's a concern here.
We don't use the text content of error messages programmatically in lldb.
If you wanted to make these errors actionable, the low level LoadCore
xiaobai added inline comments.
Comment at: CMakeLists.txt:140
+# lldb-suite is a dummy target that encompasses all the necessary tools and
+# libraries for building a fully-functioning lldb.
+add_custom_target(lldb-suite)
labath wrote:
> fully-functioning lldb **
Author: jdevlieghere
Date: Wed Jun 13 11:15:14 2018
New Revision: 334631
URL: http://llvm.org/viewvc/llvm-project?rev=334631&view=rev
Log:
[ObjC] Use llvm::StringRef in summary providers
Replace const char pointers with llvm::StringRef and use its equality
operator for string comparisons.
Modifi
amccarth added a comment.
My motivation was not to check for different kinds of errors but to ensure that
the error code detail doesn't get lost through the SWIG plumbing. SBErrors
seem to be marshaled properly when used as return values, but this is the first
one I've seen returned by referen
The intention in the scope of this change is just to check that the new
overload is exposed correctly through the Python API.
In general, guaranteeing specific error codes (messages?) is likely
impractical:
1. It's not always easy to do the proper checks (ex. for 'file-not-found'
you'd actually g
lemo added a comment.
The intention in the scope of this change is just to check that the new
overload is exposed correctly through the Python API.
In general, guaranteeing specific error codes (messages?) is likely
impractical:
1. It's not always easy to do the proper checks (ex. for 'file-not-
jingham accepted this revision.
jingham added a comment.
This looks fine to me. Nothing in the TypeSummaryOptions is relevant to
printing these numbers, so it's correct to ignore them.
Repository:
rL LLVM
https://reviews.llvm.org/D48114
___
lld
amccarth added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py:78
+self.assertFalse(self.process, PROCESS_IS_VALID)
+self.assertTrue(error.Fail())
+
Is it worth che
Author: jdevlieghere
Date: Wed Jun 13 09:36:07 2018
New Revision: 334618
URL: http://llvm.org/viewvc/llvm-project?rev=334618&view=rev
Log:
[FileSpec] Simplify getting extension and stem.
As noted by Pavel on lldb-commits, we don't need the temp path, we can
just pass the filename directly into ex
Good catch, thanks!
On Wed, Jun 13, 2018 at 9:34 AM Pavel Labath wrote:
> On Wed, 13 Jun 2018 at 17:27, Jonas Devlieghere via lldb-commits
> wrote:
> >
> > Author: jdevlieghere
> > Date: Wed Jun 13 09:23:21 2018
> > New Revision: 334615
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=33461
On Wed, 13 Jun 2018 at 17:27, Jonas Devlieghere via lldb-commits
wrote:
>
> Author: jdevlieghere
> Date: Wed Jun 13 09:23:21 2018
> New Revision: 334615
>
> URL: http://llvm.org/viewvc/llvm-project?rev=334615&view=rev
> Log:
> [FileSpec] Delegate common operations to llvm::sys::path
>
> With the r
JDevlieghere added inline comments.
Comment at: source/Utility/FileSpec.cpp:244-246
+ // Only update style if explicitly requested.
+ if (style)
+m_style = (*style == Style::native) ? GetNativeStyle() : *style;
labath wrote:
> JDevlieghere wrote:
> > labath
This revision was automatically updated to reflect the committed changes.
JDevlieghere marked 11 inline comments as done.
Closed by commit rL334615: [FileSpec] Delegate common operations to
llvm::sys::path (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.
Author: jdevlieghere
Date: Wed Jun 13 09:23:21 2018
New Revision: 334615
URL: http://llvm.org/viewvc/llvm-project?rev=334615&view=rev
Log:
[FileSpec] Delegate common operations to llvm::sys::path
With the recent changes in FileSpec to use LLVM's path style, it is
possible to delegate a bunch of c
Author: adrian
Date: Wed Jun 13 09:21:24 2018
New Revision: 334614
URL: http://llvm.org/viewvc/llvm-project?rev=334614&view=rev
Log:
Fix/unify the spelling of Objective-C.
Modified:
lldb/trunk/CODE_OWNERS.txt
lldb/trunk/examples/darwin/heap_find/heap/heap_find.cpp
lldb/trunk/include/l
clayborg added a comment.
In https://reviews.llvm.org/D47991#1131181, @apolyakov wrote:
> In https://reviews.llvm.org/D47991#1131043, @clayborg wrote:
>
> > Looks good. Just a question about including the commented out default
> > arguments
>
>
> Don't you think it increases readability of this
Author: teemperor
Date: Wed Jun 13 08:50:45 2018
New Revision: 334611
URL: http://llvm.org/viewvc/llvm-project?rev=334611&view=rev
Log:
Add modules support for lldb headers in include/
Summary:
This patch adds a modulemap which allows compiling the lldb headers into C++
modules
(for example in b
teemperor updated this revision to Diff 151181.
teemperor added a comment.
- Finally found the one and only way to spell "Objective-C++"
https://reviews.llvm.org/D47929
Files:
include/lldb/module.modulemap
source/Host/CMakeLists.txt
source/Host/common/Terminal.cpp
source/Host/macosx/Hos
apolyakov added a comment.
In https://reviews.llvm.org/D47991#1131043, @clayborg wrote:
> Looks good. Just a question about including the commented out default
> arguments
Don't you think it increases readability of this code?
https://reviews.llvm.org/D47991
__
clayborg added inline comments.
Comment at: source/Utility/FileSpec.cpp:593
+ llvm::SmallString<64> current_path;
+ GetPath(current_path, false);
+ return ConstString(llvm::sys::path::extension(current_path, m_style));
We won't need the full path in order to g
clayborg added a comment.
Looks good. Just a question about including the commented out default arguments
Comment at: source/API/SBThread.cpp:636
+void SBThread::StepOver(lldb::RunMode stop_other_threads
+/* = lldb::eOnlyDuringStepping */) {
+ SBError e
labath added inline comments.
Comment at: source/Utility/FileSpec.cpp:244-246
+ // Only update style if explicitly requested.
+ if (style)
+m_style = (*style == Style::native) ? GetNativeStyle() : *style;
JDevlieghere wrote:
> labath wrote:
> > JDevlieghere
labath added inline comments.
Comment at: CMakeLists.txt:140
+# lldb-suite is a dummy target that encompasses all the necessary tools and
+# libraries for building a fully-functioning lldb.
+add_custom_target(lldb-suite)
fully-functioning lldb **library**.
(this
35 matches
Mail list logo
