[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

polyakov.alex added a comment. You are right. I think that the reason of exiting *normally is much deeper. I'll look at this, but for now I don't have any ideas about what it may cause, do you have one? Repository: rL LLVM https://reviews.llvm.org/D47679 _

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

stella.stamenova added a comment. You can actually follow the pattern in the other tests and do: %cc -o %t %p/inputs/break-insert.c -g %t``` then becomes the name of the output file and you can use that in our other commands. This is better than specifying a hardcoded name. Having sa

[Lldb-commits] [PATCH] D47678: [lldb, lldm-mi] Fix hanging of -exec-run command.

aprantl added a comment. Nice. It should be easy to also create a test for this that just specifies an invalid filename and verifies that lldb-mi returns a failure? Repository: rL LLVM https://reviews.llvm.org/D47678 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

polyakov.alex added a comment. I would really appreciate if you guys can check this test on Windows again. Repository: rL LLVM https://reviews.llvm.org/D47679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D47679: [lldb, lldb-mi] Enable lldb-mi -break-insert test on Windows.

polyakov.alex created this revision. polyakov.alex added reviewers: aprantl, stella.stamenova. Herald added subscribers: llvm-commits, ki.stfu. The default name for a compiler output on Linux is `a.out`, while on Windows it's `a.exe`. But if we add option `-o a.exe`, the compiler will create the

[Lldb-commits] [PATCH] D47678: [lldb, lldm-mi] Fix hanging of -exec-run command.

polyakov.alex updated this revision to Diff 149619. polyakov.alex added a comment. A bit of refactoring. Repository: rL LLVM https://reviews.llvm.org/D47678 Files: tools/lldb-mi/MICmdCmdExec.cpp Index: tools/lldb-mi/MICmdCmdExec.cpp ===

[Lldb-commits] [PATCH] D47678: [lldb, lldm-mi] Fix hanging of -exec-run command.

polyakov.alex added a comment. These changes fix the hanging of the lldb-mi lit tests. For example: `-file-exec-and-symbols a.out` command in test may cause a hanging if `a.out` is invalid name of binary. Repository: rL LLVM https://reviews.llvm.org/D47678 ___

[Lldb-commits] [PATCH] D47678: [lldb, lldm-mi] Fix hanging of -exec-run command.

polyakov.alex created this revision. polyakov.alex added reviewers: aprantl, stella.stamenova. Herald added subscribers: llvm-commits, ki.stfu. -exec-run command hanged in case of invalid or dummy target. Repository: rL LLVM https://reviews.llvm.org/D47678 Files: tools/lldb-mi/MICmdCmdExec

[Lldb-commits] [PATCH] D40470: Protect DWARFCompileUnit::m_die_array by a new mutex

jankratochvil updated this revision to Diff 149609. jankratochvil added a comment. Provided variants with a new RAII lock guard vs. unchanged caller `bool clear_dies` variable. And also 1 vs. 2 mutexes for `m_die_array`. Please choose one, I do not mind any. - mutexes2raii.patch