[Lldb-commits] [lldb] r333816 - Fix silly error introduced after testing in r333813.

Author: jyknight Date: Fri Jun 1 21:00:16 2018 New Revision: 333816 URL: http://llvm.org/viewvc/llvm-project?rev=333816&view=rev Log: Fix silly error introduced after testing in r333813. Oops. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/duplicate-archive-members/TestDuplicat

[Lldb-commits] [lldb] r333813 - Fix support for distinguishing archive members by timestamp on Darwin.

Author: jyknight Date: Fri Jun 1 19:44:10 2018 New Revision: 333813 URL: http://llvm.org/viewvc/llvm-project?rev=333813&view=rev Log: Fix support for distinguishing archive members by timestamp on Darwin. On Darwin, the binary's symbol table points to debug info in object files -- potentially ob

[Lldb-commits] [lldb] r333790 - [lit, pdb] Fix two failing PDB tests on Windows

Author: stella.stamenova Date: Fri Jun 1 14:33:27 2018 New Revision: 333790 URL: http://llvm.org/viewvc/llvm-project?rev=333790&view=rev Log: [lit, pdb] Fix two failing PDB tests on Windows Summary: One of the tests is failing to build because it needs GS-, the second test does not correctly ma

[Lldb-commits] [lldb] r333789 - [lit, lldbmi] Skip the new break-insert test on Windows

Author: stella.stamenova Date: Fri Jun 1 14:29:43 2018 New Revision: 333789 URL: http://llvm.org/viewvc/llvm-project?rev=333789&view=rev Log: [lit, lldbmi] Skip the new break-insert test on Windows Summary: Skip the new break-insert test on Windows because it hangs and so the test suite never c

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

vsk added a comment. In https://reviews.llvm.org/D47646#1119512, @stella.stamenova wrote: > I can look into the failure - but can you XFAIL the test rather than skipping > it and log a bug, so that we can track the failure rather than potentially > assuming down the line that the test is not me

[Lldb-commits] [lldb] r333787 - XFAIL TestIRMemoryMap.test on Windows

Author: vedantk Date: Fri Jun 1 13:32:32 2018 New Revision: 333787 URL: http://llvm.org/viewvc/llvm-project?rev=333787&view=rev Log: XFAIL TestIRMemoryMap.test on Windows I've xfailed this test instead of skipping it by request (https://reviews.llvm.org/D47646). Bug: https://bugs.llvm.org/show_

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. I can look into the failure - but can you XFAIL the test rather than skipping it and log a bug, so that we can track the failure rather than potentially assuming down the line that the test is not meant for windows? https://reviews.llvm.org/D47646 _

[Lldb-commits] [lldb] r333786 - Fix Module::FindTypes to return the correct number of matches.

Author: friss Date: Fri Jun 1 13:14:21 2018 New Revision: 333786 URL: http://llvm.org/viewvc/llvm-project?rev=333786&view=rev Log: Fix Module::FindTypes to return the correct number of matches. In r331719, I changed Module::FindTypes not to limit the amount of types returned by the Symbol provid

[Lldb-commits] [lldb] r333785 - Disable TestIRMemoryMap.test on Windows

Author: vedantk Date: Fri Jun 1 13:02:57 2018 New Revision: 333785 URL: http://llvm.org/viewvc/llvm-project?rev=333785&view=rev Log: Disable TestIRMemoryMap.test on Windows It's been pointed out in https://reviews.llvm.org/D47646 that lldb-test fails to create a usable process on Windows when ru

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

vsk added a comment. In https://reviews.llvm.org/D47646#1119487, @vsk wrote: > In https://reviews.llvm.org/D47646#1119479, @stella.stamenova wrote: > > > In https://reviews.llvm.org/D47646#1119471, @vsk wrote: > > > > > In https://reviews.llvm.org/D47646#1119396, @stella.stamenova wrote: > > > >

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

vsk added a comment. In https://reviews.llvm.org/D47646#1119479, @stella.stamenova wrote: > In https://reviews.llvm.org/D47646#1119471, @vsk wrote: > > > In https://reviews.llvm.org/D47646#1119396, @stella.stamenova wrote: > > > > > While you are at it, can you make sure this works on Windows? Th

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. In https://reviews.llvm.org/D47646#1119471, @vsk wrote: > In https://reviews.llvm.org/D47646#1119396, @stella.stamenova wrote: > > > While you are at it, can you make sure this works on Windows? The current > > version of the test that is checked in fails. > > >

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

vsk added a comment. In https://reviews.llvm.org/D47646#1119396, @stella.stamenova wrote: > While you are at it, can you make sure this works on Windows? The current > version of the test that is checked in fails. Sorry about that. Could you point me to the error message? https://reviews.llv

[Lldb-commits] [lldb] r333781 - [lldb, process] Fix occasional hang when launching a process in LLDB

Author: stella.stamenova Date: Fri Jun 1 12:14:53 2018 New Revision: 333781 URL: http://llvm.org/viewvc/llvm-project?rev=333781&view=rev Log: [lldb, process] Fix occasional hang when launching a process in LLDB Summary: Occasionally, when launching a process in lldb (especially on windows, but n

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

stella.stamenova added a comment. While you are at it, can you make sure this works on Windows? The current version of the test that is checked in fails. https://reviews.llvm.org/D47646 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

vsk created this revision. vsk added a reviewer: labath. Change the syntax of the malloc and free commands in lldb-test's ir-memory-map subcommand to: ::= = malloc ::= free This should make it easier to read and extend tests in the future, e.g to test IRMemoryMap::WriteMemory or dou

Re: [Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

Patch up for review: https://reviews.llvm.org/D47646 thanks, vedant > On Jun 1, 2018, at 11:31 AM, Vedant Kumar wrote: > > > >> On Jun 1, 2018, at 1:39 AM, Pavel Labath wrote: >> >> On Thu, 31 May 2018 at 23:13, Vedant Kumar via lldb-commits >> wrote: >>>

Re: [Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

> On Jun 1, 2018, at 1:39 AM, Pavel Labath wrote: > > On Thu, 31 May 2018 at 23:13, Vedant Kumar via lldb-commits > wrote: >> >> Author: vedantk >> Date: Thu May 31 15:09:01 2018 >> New Revision: 333700 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=333700&view=rev >> Log: >> [IRMemoryMa

[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

xiaobai added a comment. In https://reviews.llvm.org/D47612#1118615, @labath wrote: > I don't understand the interactions between lldb framework and clang headers, > but if there isn't a better person to review this, I'm happy to rubber-stamp > it. :) Thanks! I don't quite understand it eithe

[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

This revision was automatically updated to reflect the committed changes. Closed by commit rL333777: Add dependency on clang-headers when building LLDB.framework using CMake (authored by xiaobai, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.

[Lldb-commits] [lldb] r333777 - Add dependency on clang-headers when building LLDB.framework using CMake

Author: xiaobai Date: Fri Jun 1 11:14:49 2018 New Revision: 333777 URL: http://llvm.org/viewvc/llvm-project?rev=333777&view=rev Log: Add dependency on clang-headers when building LLDB.framework using CMake Summary: The LLDB.framework generated when building with CMake + Ninja/Make is completely

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

christos added inline comments. Comment at: include/lldb/Host/Editline.h:72-76 #ifdef EL_CLIENTDATA /* editline with wide support + wide char read function */ using EditLineGetCharType = wchar_t; #else using EditLineGetCharType = char; #endif labath wrote

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

clayborg accepted this revision. clayborg added a comment. I can't think of a better name, looks good. Thanks for taking the time, this will be great. https://reviews.llvm.org/D47470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

krytarowski added a comment. The original reason to switch NetBSD to wide characters was to unbreak the input parser. It used to mix wide and short characters. Typing unicode characters doesn't work well here too (before applying the patch): `(lldb) za\U+017C\U+0142\U+0107 g\U+0119\U+015Bl\U+0

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. No regressions on Fedora 28 x86_64. It does set there now `LLDB_EDITLINE_USE_WCHAR` although one still cannot enter unicode characters to `(lldb)` line. https://reviews.llvm.o

[Lldb-commits] [PATCH] D47629: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. Herald added subscribers: aprantl, mehdi_amini, mgorny. This patch is pretty much a big noop. It adds the ability to create a DebugNamesDWARFIndex class, but the class itself is not implemented in any useful way

[Lldb-commits] [lldb] r333743 - Add .debug_names section glue code

Author: labath Date: Fri Jun 1 05:06:45 2018 New Revision: 333743 URL: http://llvm.org/viewvc/llvm-project?rev=333743&view=rev Log: Add .debug_names section glue code Modified: lldb/trunk/include/lldb/lldb-enumerations.h lldb/trunk/lit/Modules/elf-section-types.yaml lldb/trunk/source

Re: [Lldb-commits] [lldb] r303907 - Fix bug #28898

Thanks for confirming that. I have created which tries to implement this. Could you take quick look at that? There is one particular question about EL_CLIENTDATA that I would like to hear your thoughts on. On Thu, 31 May 2018 at 12:47, Christos Zoulas wrote: > > O

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

labath added inline comments. Comment at: include/lldb/Host/Editline.h:72-76 #ifdef EL_CLIENTDATA /* editline with wide support + wide char read function */ using EditLineGetCharType = wchar_t; #else using EditLineGetCharType = char; #endif It's not fully

[Lldb-commits] [PATCH] D47625: [cmake] Detect presence of wide-char libedit at build time

labath created this revision. labath added reviewers: krytarowski, uweigand, jankratochvil, timshen, beanz. Herald added a subscriber: mgorny. Instead of hardcoding a list of platforms where libedit is known to have wide char support we detect this in cmake. The main motivation for this is attempt

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

labath added a comment. ps: the specificationsAndAbstractOrigins sounded like too big of a mouthful. I've invented the name "elaborating dies" for that. https://reviews.llvm.org/D47470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D47470: AppleDWARFIndex: Get function method-ness directly from debug info

labath updated this revision to Diff 149423. labath marked an inline comment as done. labath added a comment. I have a feeling we are starting to over-engineer this. Visiting referenced dies sounds like a useful utility in general, though I think most of the users will be content with just visitin

[Lldb-commits] [PATCH] D47612: Add dependency on clang-headers when building LLDB.framework using CMake

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't understand the interactions between lldb framework and clang headers, but if there isn't a better person to review this, I'm happy to rubber-stamp it. :) https://reviews.llvm.org/D47

Re: [Lldb-commits] [lldb] r333700 - [IRMemoryMap] Test interleaved Mallocs and Frees

On Thu, 31 May 2018 at 23:13, Vedant Kumar via lldb-commits wrote: > > Author: vedantk > Date: Thu May 31 15:09:01 2018 > New Revision: 333700 > > URL: http://llvm.org/viewvc/llvm-project?rev=333700&view=rev > Log: > [IRMemoryMap] Test interleaved Mallocs and Frees > > This adds a new command to t