[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

2018-05-26 Thread Ilia K via Phabricator via lldb-commits
ki.stfu added a comment. 👍 Repository: rL LLVM https://reviews.llvm.org/D47410 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D47415: [lldb, lldb-mi] Re-implement MI -exec-continue command.

2018-05-26 Thread Alexander Polyakov via Phabricator via lldb-commits
polyakov.alex created this revision. polyakov.alex added reviewers: aprantl, clayborg. Herald added subscribers: llvm-commits, ki.stfu. Now -exec-continue command uses SB API t resume target's process. Repository: rL LLVM https://reviews.llvm.org/D47415 Files: lit/tools/lldb-mi/exec/exec-c

[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

2018-05-26 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Generally I'm fine with improving the layering. I just wanted to point out that the Swift language plugin also wants know the clang resource directory (it calls `HostInfo::GetLLDBPath(ePathTypeClangDir, clang_dir_spec)`) since Swift embeds Clang. That said it makes no s

[Lldb-commits] [PATCH] D47412: Add missing includes to some LLDB headers.

2018-05-26 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL45: Add missing includes to some LLDB headers. (authored by teemperor, committed by ). Herald added a subscriber: llvm

[Lldb-commits] [lldb] r333345 - Add missing includes to some LLDB headers.

2018-05-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat May 26 07:59:14 2018 New Revision: 45 URL: http://llvm.org/viewvc/llvm-project?rev=45&view=rev Log: Add missing includes to some LLDB headers. Summary: When compiling with modules, these missing includes cause the build to fail (as the header can't be compiled

[Lldb-commits] [PATCH] D47412: Add missing includes to some LLDB headers.

2018-05-26 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. Herald added a subscriber: ki.stfu. When compiling with modules, these missing includes cause the build to fail (as the header can't be compiled into a module). https://reviews.llvm.org/D47412 Files: source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendez

[Lldb-commits] [PATCH] D47411: Mute some compiler warnings in the generated python wrapper code.

2018-05-26 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: zturner. Herald added a subscriber: mgorny. With SWIG 3.0.12 I get the following compiler warnings when compiling LLDB: tools/lldb/scripts/LLDBWrapPython.cpp:23699:52: warning: format string is not a string literal (potentially insec

[Lldb-commits] [PATCH] D47384: Remove dependency from Host to clang

2018-05-26 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: aprantl. labath added a comment. +Adrian. I remember looking at the path computation code a while ago (I think it was in the context of python though) and concluding that something like this would be needed. Overall the patch seems fine to me, but I want to make sure it

[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

2018-05-26 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL43: Don't include headers from inside a namespace in MIUtilSingletonHelper.h (authored by teemperor, committed by ). H

[Lldb-commits] [lldb] r333343 - Don't include headers from inside a namespace in MIUtilSingletonHelper.h

2018-05-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat May 26 07:39:35 2018 New Revision: 43 URL: http://llvm.org/viewvc/llvm-project?rev=43&view=rev Log: Don't include headers from inside a namespace in MIUtilSingletonHelper.h Subscribers: ki.stfu, lldb-commits Differential Revision: https://reviews.llvm.org/D474

[Lldb-commits] [PATCH] D47410: Don't include headers from inside a namespace in MIUtilSingletonHelper.h

2018-05-26 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. Herald added a subscriber: ki.stfu. https://reviews.llvm.org/D47410 Files: tools/lldb-mi/MIUtilSingletonHelper.h Index: tools/lldb-mi/MIUtilSingletonHelper.h === --- tools/lldb-mi/MIUtilSingletonH

[Lldb-commits] [PATCH] D47409: Forward declare DumpValueObjectOptions in ValueObject.h

2018-05-26 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL42: Forward declare DumpValueObjectOptions in ValueObject.h (authored by teemperor, committed by ). Herald added a sub

[Lldb-commits] [lldb] r333342 - Forward declare DumpValueObjectOptions in ValueObject.h

2018-05-26 Thread Raphael Isemann via lldb-commits
Author: teemperor Date: Sat May 26 07:34:49 2018 New Revision: 42 URL: http://llvm.org/viewvc/llvm-project?rev=42&view=rev Log: Forward declare DumpValueObjectOptions in ValueObject.h Summary: This resolves unnecessary the header dependency from Core to DataFormatters. Patch is necessary

[Lldb-commits] [PATCH] D47409: Forward declare DumpValueObjectOptions in ValueObject.h

2018-05-26 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. This resolves unnecessary the header dependency from Core to DataFormatters. Patch is necessary for the introduction of C++ modules to the LLDB build system. https://reviews.llvm.org/D47409 Files: include/lldb/Core/ValueObject.h source/Core/ValueObject.cpp