Re: [Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

2018-05-04 Thread Davide Italiano via lldb-commits
On Fri, May 4, 2018 at 10:54 AM, Greg Clayton wrote: > So it seems that if specify "./blah" as your program then this fails, but if > you specify just "blah" then this succeeds. Looks like we need to resolve the > path when creating a target with a local copy of the file. I will look into > thi

Re: [Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

2018-05-04 Thread Greg Clayton via lldb-commits
So it seems that if specify "./blah" as your program then this fails, but if you specify just "blah" then this succeeds. Looks like we need to resolve the path when creating a target with a local copy of the file. I will look into this. Greg > On May 3, 2018, at 3:08 PM, Davide Italiano wrot

Re: [Lldb-commits] [lldb] r331082 - Fix build bots after r331049 broke them.

2018-05-04 Thread Davide Italiano via lldb-commits
ping. On Thu, May 3, 2018 at 3:08 PM, Davide Italiano wrote: > I would like to apologize for communicating this so late (mainly > because I worked on the swift bits which are a little behind and I > didn't update my checkout) but this commit completely broke debugging > in some cases (on MacOS).

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-05-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In https://reviews.llvm.org/D32167#1087627, @labath wrote: > Maybe we could start by splitting of the ObjectFile recognition code for the > debug_types section into a separate patch. That should be sufficiently > non-controversial and it would reduce the number of file

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

2018-05-04 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Maybe we could start by splitting of the ObjectFile recognition code for the debug_types section into a separate patch. That should be sufficiently non-controversial and it would reduce the number of files touched by this patch a bit. https://reviews.llvm.org/D32167

[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

2018-05-04 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 145163. labath marked an inline comment as done. labath added a comment. Update the diff. https://reviews.llvm.org/D46395 Files: include/lldb/Host/Host.h include/lldb/Host/MonitoringProcessLauncher.h include/lldb/Target/ProcessLaunchInfo.h source/Hos

[Lldb-commits] [PATCH] D46395: Remove Process references from the Host module

2018-05-04 Thread Pavel Labath via Phabricator via lldb-commits
labath marked an inline comment as done. labath added a comment. I've added a comment about the requirement to the `MonitoringProcessLauncher` and to `Host::LaunchProcess` (most users go through the latter). I've also tried to make it more obvious that the no-op callback still causes the process