Author: jingham
Date: Thu May 3 18:31:47 2018
New Revision: 331501
URL: http://llvm.org/viewvc/llvm-project?rev=331501&view=rev
Log:
Add children and child[N] properties to SBValue.i.
Also fixed some bad formatting in SBValue.i.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/python_api
Author: jmolenda
Date: Thu May 3 17:59:37 2018
New Revision: 331497
URL: http://llvm.org/viewvc/llvm-project?rev=331497&view=rev
Log:
The on-ios-device command line lldb has an optimization where
when it and the inferior process both have the same shared cache
(a conglomeration of all libraries a
aprantl added a comment.
As Greg suspected, the problem was that target was null. I rewrote that patch
to not use a SymbolContext in the first place.
Repository:
rL LLVM
https://reviews.llvm.org/D46362
___
lldb-commits mailing list
lldb-commits@
Author: adrian
Date: Thu May 3 16:32:47 2018
New Revision: 331492
URL: http://llvm.org/viewvc/llvm-project?rev=331492&view=rev
Log:
DWARFExpression: Convert file addresses to load addresses early on.
This is a change that only affects Swift and is NFC for the language
plugins on llvm.org. In Swi
I would like to apologize for communicating this so late (mainly
because I worked on the swift bits which are a little behind and I
didn't update my checkout) but this commit completely broke debugging
in some cases (on MacOS).
Testcase:
#import
int main() {
id keys[1] = { @"abc" };
id valu
On Fri, Apr 27, 2018 at 2:10 PM, Greg Clayton via lldb-commits
wrote:
> Author: gclayton
> Date: Fri Apr 27 14:10:07 2018
> New Revision: 331082
>
> URL: http://llvm.org/viewvc/llvm-project?rev=331082&view=rev
> Log:
> Fix build bots after r331049 broke them.
>
I would like to apologize for commu
One issue after looking closer at the code is you didn't specify you wanted the
target filled in when calling:
auto sc = frame->GetSymbolContext(eSymbolContextFunction);
It should be:
auto sc = frame->GetSymbolContext(eSymbolContextTarget | eSymbolContextModule |
eSymbolContextCompUnit | eSym
aprantl added a comment.
Yes, I must have added a mistake in my last edit before landing this. I
reverted that patch for now.
Repository:
rL LLVM
https://reviews.llvm.org/D46362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://li
Author: adrian
Date: Thu May 3 13:19:39 2018
New Revision: 331480
URL: http://llvm.org/viewvc/llvm-project?rev=331480&view=rev
Log:
Revert "DWARFExpression: Convert file addresses to load addresses early on."
This reverts commit 331462 while investigating bot breakage.
Modified:
lldb/trunk/
Was this the "please make sure global variable expression can be evaluated when
not running" issue you ran into?
> On May 3, 2018, at 1:13 PM, Adrian Prantl via lldb-commits
> wrote:
>
> Author: adrian
> Date: Thu May 3 13:13:58 2018
> New Revision: 331479
>
> URL: http://llvm.org/viewvc/llv
labath added a comment.
It looks like this has caused a bunch of tests to crash on linux
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/22800.
The crashes seem to be happening during printing of global variables (
`HandleCommand(command = "target variable my_global_char
Author: adrian
Date: Thu May 3 13:13:58 2018
New Revision: 331479
URL: http://llvm.org/viewvc/llvm-project?rev=331479&view=rev
Log:
Add back condition that was accidentally removed in r331462.
This should make the bots much happier.
Modified:
lldb/trunk/source/Core/ValueObjectVariable.cpp
clayborg added inline comments.
Comment at: source/Host/macosx/Host.mm:1501
+bool monitoring = launch_info.MonitorProcess();
+(void)monitoring;
+assert(monitoring);
Do we not have a macro for silencing unused variables?
Comment at:
davide accepted this revision.
davide added a comment.
lg
https://reviews.llvm.org/D46395
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This is a cleaner approach. Might be worth adding a comment in the
MonitoringProcessLauncher.h saying that the monitoring callback in the
ProcessLaunchInfo is required? You might from the
labath created this revision.
labath added reviewers: jingham, davide.
Herald added a subscriber: emaste.
The Process class was only being referenced because of the last-ditch
effort in the process launchers to set a process exit callback in case
one isn't set already.
Although launching a proces
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331463: [CMake] Unify and relayer testing (authored by
JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46334?vs=145033&id=145035#toc
Repository:
rL LLVM
https://revi
Author: jdevlieghere
Date: Thu May 3 09:54:10 2018
New Revision: 331463
URL: http://llvm.org/viewvc/llvm-project?rev=331463&view=rev
Log:
[CMake] Unify and relayer testing
This patch restructures part of LLDB's testing configuration:
1. I moved the test dependencies up the chain so every dotest
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331462: DWARFExpression: Convert file addresses to load
addresses early on. (authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
Author: adrian
Date: Thu May 3 09:51:37 2018
New Revision: 331462
URL: http://llvm.org/viewvc/llvm-project?rev=331462&view=rev
Log:
DWARFExpression: Convert file addresses to load addresses early on.
This is a change that only affects Swift and is NFC for the language
plugins on llvm.org. In Swi
stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.
I still need to verify this works with VS on Windows, but feel free to check in
to unblock the bots
https://reviews.llvm.org/D46334
JDevlieghere updated this revision to Diff 145033.
JDevlieghere added a comment.
Herald added a reviewer: alexshap.
update diff pro forma
https://reviews.llvm.org/D46334
Files:
CMakeLists.txt
lit/CMakeLists.txt
lit/Suite/lit.site.cfg.in
test/CMakeLists.txt
test/lldb-dotest.in
tools/
labath added subscribers: aprantl, davide, JDevlieghere, zturner.
labath added a comment.
I remember hearing some people use the check-lldb-single target, but it had
to do with running the tests against some remote devices/stubs that did not
handle multiple connections very well.
However, the way
I remember hearing some people use the check-lldb-single target, but it had
to do with running the tests against some remote devices/stubs that did not
handle multiple connections very well.
However, the way it seems to me, with the transition to lit, this target
will have to go away sooner or lat
JDevlieghere added a comment.
I didn't realize `check-lldb-single` was also broken for ninja/make. Using the
property indeed fixed it, so we can land this without the caveat.
https://reviews.llvm.org/D46334
___
lldb-commits mailing list
lldb-commit
aprantl updated this revision to Diff 145032.
aprantl added a comment.
Thanks for the excellent feedback! Addressed comments.
https://reviews.llvm.org/D46362
Files:
include/lldb/Core/Value.h
source/Core/Value.cpp
source/Core/ValueObjectVariable.cpp
source/Expression/DWARFExpression.cpp
aprantl added a comment.
> If by as-is you mean with a big comment in the config file before the
> creation of check-single that it is broken, then yes, let's get the bots
> unblocked and then fix the issue.
Sounds good. Thanks!
https://reviews.llvm.org/D46334
_
stella.stamenova added a comment.
If by as-is you mean with a big comment in the config file before the creation
of check-single that it is broken, then yes, let's get the bots unblocked and
then fix the issue.
https://reviews.llvm.org/D46334
___
aprantl added a comment.
If that's okay with you I would suggest landing this as is to unblock the bots,
and we'll keep working on fixing the check-single target ASAP, too.
https://reviews.llvm.org/D46334
___
lldb-commits mailing list
lldb-commits@
stella.stamenova added a comment.
In its current version, the patch won't *break* the windows build (the previous
change broke the build as well as tests), so if it will unblock the bots, Jonas
could check it in and then fix check-single in a follow up patch. I think it
needs to be explicit if
clayborg added a comment.
Ping. I would like to get this in. As for testing, the full matrix should be
run on .debug_types as it is the main form of type uniquing that is defined by
the DWARF spec. Any formats that are fully accepted and written into the DWARF
spec should be fully tested to ens
aprantl added a comment.
Is there a way to land a partial version of this patch to un-block the green
dragon bots and keep iterating on the check-single target separately? Or do
other bots depend on check-single working correctly? I'm really uneasy about
the fact that we are loosing signal from
Author: labath
Date: Thu May 3 08:33:41 2018
New Revision: 331458
URL: http://llvm.org/viewvc/llvm-project?rev=331458&view=rev
Log:
Remove the timed_out out-argument from Predicate::WaitForValueEqualTo
The function can only return in one of two ways: the Predicate value is
successfully set withi
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
great fix. Just resolve the file address using the module function and this is
good to go.
Comment at: source/Core/Value.cpp:683-685
+ ObjectFile *objfile = s
This revision was automatically updated to reflect the committed changes.
labath marked 2 inline comments as done.
Closed by commit rL331447: lldb-test symbols: Add ability to do name-based
lookup (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commi
Author: labath
Date: Thu May 3 03:57:16 2018
New Revision: 331447
URL: http://llvm.org/viewvc/llvm-project?rev=331447&view=rev
Log:
lldb-test symbols: Add ability to do name-based lookup
Summary:
lldb-test already had the ability to dump all symbol information in a
module. This is interesting, b
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
A few more nits but otherwise this LGTM.
Comment at: tools/lldb-test/lldb-test.cpp:463
DebuggerLifetime->Terminate();
return 0;
labath wr
labath added a comment.
One day I'd like us to have a unit testing framework for the dwarf expression
evaluator. The evaluator looks like a thing that is both complex enough (so
it's worth doing it) and /ought to be/ self-contained enough (so it is doable).
Then we could test these, and all oth
38 matches
Mail list logo
