lemo added subscribers: bgianfo, clayborg, alur, labath, penryu, lemo.
lemo added a comment.
Hi Erik, the review is still marked as requiring changes. Once that is
sorted out I'd be happy to submit this on your behalf (what is the base SVN
revision for the latest patch?)
Davide Italiano, is all t
Hi Erik, the review is still marked as requiring changes. Once that is
sorted out I'd be happy to submit this on your behalf (what is the base SVN
revision for the latest patch?)
Davide Italiano, is all the CR feedback addressed in the latest revision?
On Tue, Apr 24, 2018 at 1:38 PM, Erik Weland
alur added a comment.
Friendly ping, is there anything else I need to do for this to get submitted?
https://reviews.llvm.org/D45628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg updated this revision to Diff 143801.
clayborg added a comment.
Added comment before llvm::sys::path_remove_dots(...)
https://reviews.llvm.org/D45977
Files:
include/lldb/Core/FileSpecList.h
include/lldb/Utility/FileSpec.h
source/Breakpoint/BreakpointResolverFileLine.cpp
source/
jankratochvil updated this revision to Diff 143799.
https://reviews.llvm.org/D40475
Files:
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/lldbinline.py
packages/Python/lldbsuite/test/lldbtest.py
packages/Python/lldbsuite/test/make/Makefile.rules
packages/Python/
aprantl added inline comments.
Comment at: source/Utility/FileSpec.cpp:241
}
+ llvm::sys::path::remove_dots(resolved, true, LLVMPathSyntax(syntax));
`// Normalize the path by removing './' and other redundant components.`
Comment at: sour
jankratochvil updated this revision to Diff 143785.
https://reviews.llvm.org/D40474
Files:
include/lldb/Utility/ConstString.h
include/lldb/Utility/FileSpec.h
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
source/Plugins/SymbolFile
jankratochvil updated this revision to Diff 143784.
https://reviews.llvm.org/D40473
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp
source/Plugins/SymbolFile/DWARF/DWARFDIE.h
source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
s
zturner added a comment.
In https://reviews.llvm.org/D46005#1077029, @labath wrote:
> In https://reviews.llvm.org/D46005#1077013, @zturner wrote:
>
> > I thought the intention was going to be parallelize at file-granularity
> > rather than method granularity, since the whole point of grouping te
labath added a comment.
In https://reviews.llvm.org/D46005#1077013, @zturner wrote:
> I thought the intention was going to be parallelize at file-granularity
> rather than method granularity, since the whole point of grouping tests
> together into classes is that they can share similar set up a
clayborg updated this revision to Diff 143777.
clayborg added a comment.
Switch over to using llvm::sys::path::remove_dots(), remove the ::Normalize()
function and fix a few issue discovered during testing.
https://reviews.llvm.org/D45977
Files:
include/lldb/Core/FileSpecList.h
include/lld
zturner added a comment.
Actually, for the first case, I'm thinking we can extend lit to support
somethign like per-directory set up. Like if there is a file present called
`lit.init.cfg`, then this file contains some code that is run once per
directory before any of the tests. Then we could
zturner added a comment.
In https://reviews.llvm.org/D46005#1077013, @zturner wrote:
> In https://reviews.llvm.org/D46005#1077000, @labath wrote:
>
> > In https://reviews.llvm.org/D46005#1076978, @zturner wrote:
> >
> > > Does it print just the names of the .py files, or does it print the
> > >
zturner added a comment.
In https://reviews.llvm.org/D46005#1077000, @labath wrote:
> In https://reviews.llvm.org/D46005#1076978, @zturner wrote:
>
> > Does it print just the names of the .py files, or does it print the actual
> > test classes and methods in the Class.TestName format, evaluate X
labath added a comment.
In https://reviews.llvm.org/D46005#1076978, @zturner wrote:
> Does it print just the names of the .py files, or does it print the actual
> test classes and methods in the Class.TestName format, evaluate XFAIL and
> SKIPs, etc?
It prints everything: test file (including
zturner added a comment.
Does it print just the names of the .py files, or does it print the actual test
classes and methods in the Class.TestName format, evaluate XFAIL and SKIPs, etc?
I'm also not entirely clear why `set_up_environment` is even necessary.
Nothing below the call to `set_up_en
labath added inline comments.
Comment at: source/Utility/FileSpec.cpp:406
+ m_directory.Clear();
+ }
}
clayborg wrote:
> labath wrote:
> > clayborg wrote:
> > > > they resolve to the same file in a virtual filesystem, where all
> > > > referenced path com
clayborg added inline comments.
Comment at: source/Utility/FileSpec.cpp:406
+ m_directory.Clear();
+ }
}
labath wrote:
> clayborg wrote:
> > > they resolve to the same file in a virtual filesystem, where all
> > > referenced path components exist and are
labath added inline comments.
Comment at: source/Utility/FileSpec.cpp:406
+ m_directory.Clear();
+ }
}
clayborg wrote:
> > they resolve to the same file in a virtual filesystem, where all referenced
> > path components exist and are directories
>
> Norma
clayborg added a comment.
I am trying to switch to using llvm::sys::path::remove_dots() and we will see
where we end up. By switching to this it means:
"./foo.c" --> "foo.c"
"./foo/bar.c" --> "foo/bar.c"
This makes is easier to see if a relative path matches another FileSpec since
we don't hav
JDevlieghere added inline comments.
Comment at: lit/Suite/lldbtestdumper.py:27
+
+def set_up_environment():
+global lldb_test_root
A comment describing what and why this is necessary might be nice.
Comment at: lit/Suite/lldbtestdumper.py:4
labath created this revision.
labath added reviewers: JDevlieghere, aprantl, amccarth.
The utility iterates through the tests in the suite, much like dotest
does, and prints all tests it found. So that it can set up the
environment properly, it needs to be called with a single argument - the
path
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330708: [dotest] Make the set of tests independent of the
test configuration (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: labath
Date: Tue Apr 24 03:51:44 2018
New Revision: 330708
URL: http://llvm.org/viewvc/llvm-project?rev=330708&view=rev
Log:
[dotest] Make the set of tests independent of the test configuration
Summary:
In the magic test duplicator, we were making the decision whether to
create a test var
labath added inline comments.
Comment at: source/Breakpoint/BreakpointResolverFileLine.cpp:130-131
+// we must leave the slash character though.
+while (relative_path.consume_front("."))
+ /* Do nothing. */;
+ }
What about paths like `.foo/bar.c` an
25 matches
Mail list logo
