[Lldb-commits] [lldb] r327753 - Fix the Windows build after r327750

2018-03-16 Thread Frederic Riss via lldb-commits
Author: friss Date: Fri Mar 16 15:19:58 2018 New Revision: 327753 URL: http://llvm.org/viewvc/llvm-project?rev=327753&view=rev Log: Fix the Windows build after r327750 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D43592: [DWARFASTParserClang] Always complete types read from a module/PCH AST context.

2018-03-16 Thread Frederic Riss via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327750: [DWARFASTParserClang] Complete external record types before using them as a… (authored by friss, committed by ). H

[Lldb-commits] [lldb] r327750 - [DWARFASTParserClang] Complete external record types before using them as a decl context.

2018-03-16 Thread Frederic Riss via lldb-commits
Author: friss Date: Fri Mar 16 15:12:22 2018 New Revision: 327750 URL: http://llvm.org/viewvc/llvm-project?rev=327750&view=rev Log: [DWARFASTParserClang] Complete external record types before using them as a decl context. Summary: When in a gmodules-like debugging scenario, you can have a parent

[Lldb-commits] [lldb] r327731 - Skip TestThreadSpecificBpPlusCondition on Darwin due to timeouts

2018-03-16 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Fri Mar 16 12:33:39 2018 New Revision: 327731 URL: http://llvm.org/viewvc/llvm-project?rev=327731&view=rev Log: Skip TestThreadSpecificBpPlusCondition on Darwin due to timeouts Bot failure: https://ci.swift.org/job/oss-lldb-incremental-osx/1104/ Modified: lldb/trunk/pa

[Lldb-commits] [PATCH] D43592: [DWARFASTParserClang] Always complete types read from a module/PCH AST context.

2018-03-16 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. I can't see a narrower way to do this. This sort of change makes me really wish we had "how many dies did you complete" metrics and some stress tests, so we can tell if we've just made some operation unreasonably more expensive and have

[Lldb-commits] [PATCH] D43592: [DWARFASTParserClang] Always complete types read from a module/PCH AST context.

2018-03-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Much better. Make sure Jim is ok with this as I am ok with it if he is. https://reviews.llvm.org/D43592 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r327729 - Remove -gmodules restriction from test

2018-03-16 Thread Adrian Prantl via lldb-commits
Author: adrian Date: Fri Mar 16 11:21:48 2018 New Revision: 327729 URL: http://llvm.org/viewvc/llvm-project?rev=327729&view=rev Log: Remove -gmodules restriction from test Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-auto-import/TestModulesAutoImport.py Modified: l

[Lldb-commits] [PATCH] D43592: [DWARFASTParserClang] Always complete types read from a module/PCH AST context.

2018-03-16 Thread Frederic Riss via Phabricator via lldb-commits
friss updated this revision to Diff 138734. friss added a comment. Adding back a hunk I didn't mean to delete. https://reviews.llvm.org/D43592 Files: packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py packages/Python/lldbsuite/test/lang/cpp/gmodules/main.cpp packa

[Lldb-commits] [PATCH] D43592: [DWARFASTParserClang] Always complete types read from a module/PCH AST context.

2018-03-16 Thread Frederic Riss via Phabricator via lldb-commits
friss updated this revision to Diff 138733. friss added a comment. I experimented quite a bit with different approches to fix this bug without always completing the types right after importing them from the external AST. This is the most principled approach I came up with. I applied the new helpe

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

2018-03-16 Thread Alexandre Yukio Yamashita via Phabricator via lldb-commits
alexandreyy updated this revision to Diff 138699. alexandreyy added a comment. The test would pass if one of the disassembled code had more instructions. That should be considered. I added the assertion for that. Thanks @labath . https://reviews.llvm.org/D44472 Files: packages/Python/lldbsuit

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

2018-03-16 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL327703: [dotest] Clean up test folder clean-up (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44526?vs=138579&id=138681#

[Lldb-commits] [lldb] r327703 - [dotest] Clean up test folder clean-up

2018-03-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 16 05:04:46 2018 New Revision: 327703 URL: http://llvm.org/viewvc/llvm-project?rev=327703&view=rev Log: [dotest] Clean up test folder clean-up Summary: This patch implements a unified way of cleaning the build folder of each test. This is done by completely removing t

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

2018-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I like what you did with the test. Originally, I wanted to just compare the raw memory contents, but this keeps it more inline with the spirit of the original test. I have just one question ab