Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

2018-01-28 Thread Davide Italiano via lldb-commits
On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano wrote: > On Thu, Jan 11, 2018 at 5:16 PM, Jason Molenda via lldb-commits > wrote: >> Author: jmolenda >> Date: Thu Jan 11 17:16:13 2018 >> New Revision: 322339 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=322339&view=rev >> Log: >> When parsi

[Lldb-commits] [PATCH] D42620: [lldb] Silence signed <-> unsigned integer comparison warning

2018-01-28 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. LGTM. `unsigned` is probably fine as well. Do you need somebody to commit this on your behalf? https://reviews.llvm.org/D42620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

2018-01-28 Thread Davide Italiano via Phabricator via lldb-commits
davide added a comment. As there are no strong objections, I'm going to check this in tomorrow PST and see how it goes. Thanks for your contribution. https://reviews.llvm.org/D40283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

[Lldb-commits] [PATCH] D42620: [lldb] Silence signed <-> unsigned integer comparison warning

2018-01-28 Thread Aaron Smith via Phabricator via lldb-commits
asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. Thanks for fixing that! https://reviews.llvm.org/D42620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D42620: [lldb] Silence signed <-> unsigned integer comparison warning

2018-01-28 Thread Kirill Bobyrev via Phabricator via lldb-commits
omtcyfz created this revision. omtcyfz added reviewers: davide, asmith. `num_args` is unsigned integer, declared as below: uint32_t num_args = arg_enum->getChildCount(); Comparison with the signed `arg_idx` produces a warning when compiled with -Wsign-compare flag, this patch addresses this s