zturner added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:625
os.environ["LLDB_TEST"] = scriptPath
+os.environ["LLDB_BUILD"] = configuration.test_build_dir
Here this has the possibility of setting `os.environ["LLDB_BUILD"] = N
aprantl added a comment.
Thanks, this is a great start!
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:240
+CLANG_MODULE_CACHE_DIR := module-cache
+
Is it safe that this is a relative path?
Comment at: packages/Python/lldbsu
aprantl created this revision.
This patch is the result of a discussion on lldb-dev, see
http://lists.llvm.org/pipermail/lldb-dev/2018-January/013111.html for
background.
This is a first sketch of how to move building of the testcases in the LLDB
testsuite out of the source tree. The patch is
vsk created this revision.
vsk added reviewers: aprantl, davide, jasonmolenda, labath.
Herald added a subscriber: eraman.
Stale global module caches cause problems for the bots. The modules
become invalid when clang headers are updated by version control, and
tests which use these modules fail to
xiaobai added a comment.
I don't have commit rights, so I need somebody to commit for me. If you can do
that, that'd be great! :)
https://reviews.llvm.org/D42264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
davide added a comment.
Do you have commit rights or you need somebody to commit this on your behalf?
https://reviews.llvm.org/D42264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM, ideally this file should be autogenerated.
https://reviews.llvm.org/D42264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
xiaobai created this revision.
xiaobai added reviewers: labath, zturner, jingham.
ArchSpec was moved from Core to Utility, so I modified the docs to
reflect that.
https://reviews.llvm.org/D42264
Files:
www/architecture/index.html
Index: www/architecture/index.html
==
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Wait a minute. Is there any reason why we can't add tests now?
https://reviews.llvm.org/D41702
___
lldb-commits mailing list
lldb-commi
jhibbits accepted this revision.
jhibbits added a comment.
Looks fine to me. We should eventually add tests for this, for both endians.
https://reviews.llvm.org/D41702
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/
owenpshaw updated this revision to Diff 130472.
owenpshaw added a comment.
Updated with suggestions
- Using process.Kill() to close client connection
- Refactored server._receive
- renamed elf-specific functions to be generic
https://reviews.llvm.org/D42195
Files:
packages/Python/lldbsuite/
labath added a comment.
The behavior of llvm::Error is one more quirk that you need to know about, but
I don't think the logging machinery is the place that should teach you that. If
you're working with llvm::Error, in all likelyhook you've already had to learn
about this behavior anyway, in wh
labath added a comment.
My main comment is about making sure the tearDown story is sufficiently robust.
I want to be sure we don't introduce flakyness here.
Comment at:
packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py:12
+target
labath added a comment.
In https://reviews.llvm.org/D42210#979608, @jasonmolenda wrote:
> Jim remembers some problem with logging across a fork()'ed process, Pavel
> does this ring a bell? This change might be completely bogus -- but it's
> very difficult to debug the child side of an lldb-ser
Author: labath
Date: Thu Jan 18 03:15:50 2018
New Revision: 322834
URL: http://llvm.org/viewvc/llvm-project?rev=322834&view=rev
Log:
Fix logging test on windows
Refactor in r322653 broke the logging test on windows because MSVC uses
a fully qualified name as the value of __FUNCTION__, which is no
Merged to 6.0 in r322833.
On Tue, Jan 9, 2018 at 3:44 PM, Michal Gorny via lldb-commits
wrote:
> Author: mgorny
> Date: Tue Jan 9 06:44:04 2018
> New Revision: 322081
>
> URL: http://llvm.org/viewvc/llvm-project?rev=322081&view=rev
> Log:
> [test] Fix tests to use more portable LLVM_ENABLE_ZLIB
Merged to 6.0 in r322832.
On Sat, Jan 6, 2018 at 11:20 AM, Michal Gorny via lldb-commits
wrote:
> Author: mgorny
> Date: Sat Jan 6 02:20:25 2018
> New Revision: 321932
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321932&view=rev
> Log:
> [test] Use full PATH lookup for tools
>
> Use full PAT
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you for taking the time to do this.
@chmeee, do you want to take a quick look at this?
https://reviews.llvm.org/D41702
___
lldb-commits mai
labath added a comment.
I actually enjoy debugging things like this, so I tried playing around and came
up with this test case:
// Test that a signal which is not monitored by the MainLoop does not cause a
premature exit.
TEST_F(MainLoopTest, UnmonitoredSignal) {
MainLoop loop;
Stat
19 matches
Mail list logo
