asmith updated this revision to Diff 129750.
asmith retitled this revision from "[lldb] This commit adds support to cache a
PDB's global scope and fixes a bug in getting the source file name for a
compiland" to "[lldb] Add support to cache a PDB's global scope and fix a bug
in getting the source
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
It's nice that this turned out so easy. Didn't even require modifying
`lldb-test`.
Comment at: lit/SymbolFile/PDB/compilands.test:9
+CHECK: {{^[0-9A-F]+}}: SymbolVendor (
asmith updated this revision to Diff 129747.
asmith added a comment.
Herald added a subscriber: llvm-commits.
Added a lit unit test
Repository:
rL LLVM
https://reviews.llvm.org/D41428
Files:
lit/SymbolFile/PDB/Inputs/CompilandsTest.cpp
lit/SymbolFile/PDB/compilands.test
lit/SymbolFile/
lhames added inline comments.
Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2103
+static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethodDecl *m2) {
+ // FIXME: This should detect covariant return types, but currently doesn't.
aprantl
Author: jmolenda
Date: Fri Jan 12 14:42:45 2018
New Revision: 322418
URL: http://llvm.org/viewvc/llvm-project?rev=322418&view=rev
Log:
We have two sources for path remapping information that we get out
of a dSYM per-uuid plist that may be present (dsymutil does not
create this plist, it is only ad
jasonmolenda added a comment.
In https://reviews.llvm.org/D41962#975168, @aprantl wrote:
> > there's a new skipUnlessFeature() method added to decorators.py which runs
> > sysctl to detect hardware features (in this case, hw.optional.avx512f)
>
> How does one execute a program like `sysctl` on t
aprantl added a comment.
> there's a new skipUnlessFeature() method added to decorators.py which runs
> sysctl to detect hardware features (in this case, hw.optional.avx512f)
How does one execute a program like `sysctl` on the remote? I have seen code in
TestLldbGdbServer.py that uses `platform
aprantl added a comment.
> Why not just look for the AVX registers by name that are only available if
> they are correctly detected by the native lldb-server or debugserver? Then we
> can avoid all of this. If we don't execute any instructions that crash the
> program, we can stop before any sp
davide added a comment.
In https://reviews.llvm.org/D41997#974957, @clayborg wrote:
> Very cool and close. It would be nice to function correctly without asserts,
> see inlined comment.
Out of curiosity, why does `lldb` roll its own assertion() mechanism instead of
using the standard one?
R
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Very cool and close. It would be nice to function correctly without asserts,
see inlined comment.
Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:
Why not just look for the AVX registers by name that are only available if they
are correctly detected by the native lldb-server or debugserver? Then we can
avoid all of this. If we don't execute any instructions that crash the program,
we can stop before any specialized AVX instructions are exe
jingham added inline comments.
Comment at:
Python/lldbsuite/test/expression_command/call-overridden-method/main.cpp:15
+ Base *b = &d;
+ return 0; // Please test these expressions while stopped at this line:
+}
aprantl wrote:
> the expressions are missing :-)
aprantl added a comment.
Awesome!
Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2103
+static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethodDecl *m2) {
+ // FIXME: This should detect covariant return types, but currently doesn't.
Co
lhames created this revision.
lhames added a reviewer: davide.
lhames added a project: LLDB.
Herald added subscribers: llvm-commits, JDevlieghere.
Failure to build the method override tables results in expression failures on
the following trivial test case:
class Base {
public:
virtual ~
aprantl updated this revision to Diff 129639.
aprantl added a comment.
Uploaded a mildly better version that is NFC on MSVC.
https://reviews.llvm.org/D41962
Files:
packages/Python/lldbsuite/test/functionalities/register/intel_avx/TestYMMRegister.py
packages/Python/lldbsuite/test/functional
craig.topper added a comment.
__builtin_cpu_init was added to clang between 5.0 and 6.0
https://reviews.llvm.org/D41962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aprantl added a comment.
In https://reviews.llvm.org/D41962#974656, @jasonmolenda wrote:
> I suppose a possible alternative would be to figure out the avx2 / avx512
> features manually based on the cpuid instead of letting the compiler do it
> for us. e.g.
> https://stackoverflow.com/question
jasonmolenda added a comment.
I suppose a possible alternative would be to figure out the avx2 / avx512
features manually based on the cpuid instead of letting the compiler do it for
us. e.g.
https://stackoverflow.com/questions/1666093/cpuid-implementations-in-c and then
checking the bits as
jasonmolenda added a comment.
fwiw I'm working on upstreaming on zmm (avx512) patches that we have locally
(there's one testsuite fail I still need to find time to fix) and the
TestZMMRegister.py test that ChrisB wrote to test this is written as
skip-unless-darwin, and there's a new skipUnlessF
labath added a comment.
In https://reviews.llvm.org/D41962#973827, @craig.topper wrote:
> I don't know what platforms this needs to support. But __builtin_cpu_support
> only works when compiled with clang or gcc. And it requires compiler-rt or
> libgcc. I don't know if that's guaranteed to exis
20 matches
Mail list logo
