[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

2017-12-15 Thread Taiju Tsuiki via Phabricator via lldb-commits
tzik added inline comments. Comment at: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3496 + + auto Decompressor = llvm::object::Decompressor::create( + section->GetName().GetStringRef(), This adds new dependency to LLVM Object component. Could

[Lldb-commits] [lldb] r320891 - [CMake] darwin-debug is an hard dependency for tests on macOS.

2017-12-15 Thread Davide Italiano via lldb-commits
Author: davide Date: Fri Dec 15 15:27:10 2017 New Revision: 320891 URL: http://llvm.org/viewvc/llvm-project?rev=320891&view=rev Log: [CMake] darwin-debug is an hard dependency for tests on macOS. Fixes a few failured on the testsuite with CMake. Modified: lldb/trunk/test/CMakeLists.txt Modi

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-15 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Looks good https://reviews.llvm.org/D41245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r320883 - [MacOSX/Queues] Relax an overly aggressive assertion in a test.

2017-12-15 Thread Davide Italiano via lldb-commits
Author: davide Date: Fri Dec 15 14:22:51 2017 New Revision: 320883 URL: http://llvm.org/viewvc/llvm-project?rev=320883&view=rev Log: [MacOSX/Queues] Relax an overly aggressive assertion in a test. "Default" is a valid QoS for a thread on older versions of macOS, like the one installed in the bot.

[Lldb-commits] [lldb] r320820 - llgs-tests: Add support for "exit" stop-reply packets

2017-12-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Dec 15 07:19:45 2017 New Revision: 320820 URL: http://llvm.org/viewvc/llvm-project?rev=320820&view=rev Log: llgs-tests: Add support for "exit" stop-reply packets Summary: This makes StopReply class abstract, so that we can represent different types of stop replies such as

[Lldb-commits] [PATCH] D41067: llgs-tests: Add support for "exit" stop-reply packets

2017-12-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320820: llgs-tests: Add support for "exit" stop-reply packets (authored by labath, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41067 Files: lldb/trunk/include/lldb/Host/Host.h ll

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-15 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. In https://reviews.llvm.org/D41245#956644, @labath wrote: > In https://reviews.llvm.org/D41245#97, @krytarowski wrote: > > > Maybe reuse FPR for FXSAVE/FSAVE and add next to it XSAVE/XSAVE_OPT. > > > I am not sure what you mean by that, but I don't think it can wo

[Lldb-commits] [lldb] r320816 - Fix 32-bit builds broken by 320813

2017-12-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Dec 15 06:39:12 2017 New Revision: 320816 URL: http://llvm.org/viewvc/llvm-project?rev=320816&view=rev Log: Fix 32-bit builds broken by 320813 cast to size_t to avoid narrowing error. Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Modified: lld

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

2017-12-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL320813: ObjectFileELF: Add support for compressed sections (authored by labath, committed by ). Changed prior to commit:

[Lldb-commits] [lldb] r320813 - ObjectFileELF: Add support for compressed sections

2017-12-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Dec 15 06:23:58 2017 New Revision: 320813 URL: http://llvm.org/viewvc/llvm-project?rev=320813&view=rev Log: ObjectFileELF: Add support for compressed sections Summary: We use the llvm decompressor to decompress SHF_COMPRESSED sections. This enables us to read data from de

[Lldb-commits] [PATCH] D41066: llgs-tests: Make addition of new tests easier

2017-12-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320809: llgs-tests: Make addition of new tests easier (authored by labath, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41066 Files: lldb/trunk/unittests/tools/lldb-server/CMakeList

[Lldb-commits] [lldb] r320809 - llgs-tests: Make addition of new tests easier

2017-12-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Dec 15 05:56:22 2017 New Revision: 320809 URL: http://llvm.org/viewvc/llvm-project?rev=320809&view=rev Log: llgs-tests: Make addition of new tests easier Summary: Adding a new test would require one to duplicate a significant part of the existing test that we have. This a

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D41245#97, @krytarowski wrote: > Maybe reuse FPR for FXSAVE/FSAVE and add next to it XSAVE/XSAVE_OPT. I am not sure what you mean by that, but I don't think it can work that way, as xsave area already contains a copy of the fpu registers,

[Lldb-commits] [PATCH] D41245: Reduce x86 register context boilerplate.

2017-12-15 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 127111. labath added a comment. New version. This one keeps the fxsave/xsave distinction, but it makes FPR a union directly, so it saves us one level of indirection. https://reviews.llvm.org/D41245 Files: source/Plugins/Process/Linux/NativeRegisterContextL