[Lldb-commits] [lldb] r320540 - [DataEncoder] Replace buggy versions of write functions.

2017-12-12 Thread Davide Italiano via lldb-commits
Author: davide Date: Tue Dec 12 17:41:16 2017 New Revision: 320540 URL: http://llvm.org/viewvc/llvm-project?rev=320540&view=rev Log: [DataEncoder] Replace buggy versions of write functions. This fixes a previously introduced thinko, now that I have a better idea of what's going on :) Modified:

[Lldb-commits] [lldb] r320541 - [IRExecutionUnit] Initialize uninititialized member variable.

2017-12-12 Thread Davide Italiano via lldb-commits
Author: davide Date: Tue Dec 12 17:41:17 2017 New Revision: 320541 URL: http://llvm.org/viewvc/llvm-project?rev=320541&view=rev Log: [IRExecutionUnit] Initialize uninititialized member variable. Found by the ubsan build. Modified: lldb/trunk/include/lldb/Expression/IRExecutionUnit.h Modif

[Lldb-commits] [lldb] r320522 - Add an #include to appease an older clang, NFC

2017-12-12 Thread Vedant Kumar via lldb-commits
Author: vedantk Date: Tue Dec 12 12:19:40 2017 New Revision: 320522 URL: http://llvm.org/viewvc/llvm-project?rev=320522&view=rev Log: Add an #include to appease an older clang, NFC Add in a missing #include that AppleClang-900 complains about when building with -DLLVM_ENABLE_MODULES. Modified:

[Lldb-commits] [PATCH] D41070: llgs: Propagate the environment when launching the inferior from command line

2017-12-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. No worries then. No need to make a new enum if this is just two places and they aren't all setting the same flags. https://reviews.llvm.org/D41070 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [PATCH] D41070: llgs: Propagate the environment when launching the inferior from command line

2017-12-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h:46 - //-- - /// Specify the program to launch and its arguments. - /// - /// @param[in] args - //

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

2017-12-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D40616#952432, @clayborg wrote: > Does that sound right? Yes, I'll get on it. https://reviews.llvm.org/D40616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

2017-12-12 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Sounds good,. So the solution will be: - Section::GetFileSize() will return the size in bytes of the section data as it appears in the file - Section::GetByteSize() will return the size in bytes for when this section is loaded into process memory (we might consider ren

[Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

2017-12-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D40616#951324, @clayborg wrote: > I think GetFileSize() should remain the number of bytes of the section on > disk and we should add new API if we need to figure out the decompressed > size. Or maybe when we get bytes from a compressed section