[Lldb-commits] [lldb] r320242 - Change uses of strncpy in debugserver to strlcpy

2017-12-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Dec 8 19:37:09 2017 New Revision: 320242 URL: http://llvm.org/viewvc/llvm-project?rev=320242&view=rev Log: Change uses of strncpy in debugserver to strlcpy for better safety. Modified: lldb/trunk/tools/debugserver/source/DNB.cpp lldb/trunk/tools/debugserver/

[Lldb-commits] [lldb] r320241 - Change the ordering that we search for kexts and kernels on the local

2017-12-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Dec 8 19:28:15 2017 New Revision: 320241 URL: http://llvm.org/viewvc/llvm-project?rev=320241&view=rev Log: Change the ordering that we search for kexts and kernels on the local computer. When doing kernel debugging, lldb scrapes around a few well-known locations to fi

[Lldb-commits] [lldb] r320240 - Update PlatformDarwin::GetDeveloperDir to handle the two

2017-12-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Dec 8 19:06:19 2017 New Revision: 320240 URL: http://llvm.org/viewvc/llvm-project?rev=320240&view=rev Log: Update PlatformDarwin::GetDeveloperDir to handle the two most common cases where the Xcode.app bundle puts lldb - either as a default part of the bundle, or in a t

[Lldb-commits] [PATCH] D41008: MainLoop: avoid infinite loop when pty slave gets closed

2017-12-08 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Darwin uses a kqueue-based implementation of this, so it definitely won't *break* anything, although I'd appreciate it if you can check whether the test passes there. My cursory reading of the kqueue man page makes me believe it should not be affected by this. https://

[Lldb-commits] [PATCH] D41008: MainLoop: avoid infinite loop when pty slave gets closed

2017-12-08 Thread Davide Italiano via Phabricator via lldb-commits
davide added subscribers: jingham, davide. davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. @jingham ? I'll try this change on macOS to make sure it won't break anything. https://reviews.llvm.org/D41008

[Lldb-commits] [PATCH] D41008: MainLoop: avoid infinite loop when pty slave gets closed

2017-12-08 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. For ptys (at least on Linux), the end-of-file (closing of the slave FD) is signalled by the POLLHUP flag. We were ignoring this flag, which meant that when this happened, we would spin in a loop, continuously calling poll(2) and not making any progress. This makes su