zturner added a subscriber: lldb-commits.
zturner added a comment.
One possible reason for why this never got any traction is that `lldb-commits`
wasn't added as a subscriber. While it's true that the tagged people should
have chimed in, having the whole commits list will get some more visibili
This revision was automatically updated to reflect the committed changes.
Closed by commit rL316173: Logging: Make sure logging machinery is in a
consistent state after forking (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D38938
Files:
lldb/trunk/include/lldb/Utility/L
Author: labath
Date: Thu Oct 19 10:40:51 2017
New Revision: 316173
URL: http://llvm.org/viewvc/llvm-project?rev=316173&view=rev
Log:
Logging: Make sure logging machinery is in a consistent state after forking
Summary:
We had a bug where if we had forked (in the ProcessLauncherPosixFork)
while ano
New patch is fine. Lgtm
On Thu, Oct 19, 2017 at 4:56 AM Ana Julia Caetano via Phabricator <
revi...@reviews.llvm.org> wrote:
> anajuliapc added inline comments.
>
>
>
> Comment at:
> source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:327-333
> + for (uint32_t i =
anajuliapc added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:327-333
+ for (uint32_t i = 0; i < m_max_hwp_supported; i++) {
+if ((m_hwp_regs[i].control & 1) == 0) {
+ wp_index = i; // Mark last free slot
+} else
anajuliapc updated this revision to Diff 119567.
anajuliapc marked 2 inline comments as done.
anajuliapc added a comment.
- Change numeric values to enum
- Use llvm's functions to align addresses
https://reviews.llvm.org/D38897
Files:
source/Plugins/Process/Linux/NativeRegisterContextLinux_pp
