[Lldb-commits] [lldb] r316038 - Silence some "implicit conversion of string literal" warnings

2017-10-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Oct 17 14:52:29 2017 New Revision: 316038 URL: http://llvm.org/viewvc/llvm-project?rev=316038&view=rev Log: Silence some "implicit conversion of string literal" warnings Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp lldb/trunk/sourc

[Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

2017-10-17 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Much better. https://reviews.llvm.org/D38938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D39010: lldb-server tests: Propagate environment variables (pr34192)

2017-10-17 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Without this, the launching of the test inferior may fail if it depends on some component of the environment (most likely LD_LIBRARY_PATH). This makes sure we propagate the environment variable to the inferior process. https://reviews.llvm.org/D39010 Files: unitt

[Lldb-commits] [PATCH] D35311: lldb-server tests: Add support for testing debugserver

2017-10-17 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316010: lldb-server tests: Add support for testing debugserver (authored by labath). Changed prior to commit: https://reviews.llvm.org/D35311?vs=106247&id=119344#toc Repository: rL LLVM https://revi

[Lldb-commits] [lldb] r316010 - lldb-server tests: Add support for testing debugserver

2017-10-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Oct 17 09:28:28 2017 New Revision: 316010 URL: http://llvm.org/viewvc/llvm-project?rev=316010&view=rev Log: lldb-server tests: Add support for testing debugserver Summary: This adds support for running the lldb-server test suite (currently consisting of only one test) aga

[Lldb-commits] [PATCH] D35311: lldb-server tests: Add support for testing debugserver

2017-10-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D35311#830779, @beanz wrote: > This all looks fine to me. The one thing I'd like you to consider is that > someday (when lldb-server is supported on Darwin) we will want to run these > tests against both debugserver and lldb-server. I'm not as

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

2017-10-17 Thread Ana Julia Caetano via Phabricator via lldb-commits
anajuliapc added a comment. I applied some of the suggestions. I'm still working on the others, since I may need to change some logic Thanks for the comments https://reviews.llvm.org/D38897 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r316007 - Remove shared_pointer from NativeThreadProtocol

2017-10-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Oct 17 08:52:16 2017 New Revision: 316007 URL: http://llvm.org/viewvc/llvm-project?rev=316007&view=rev Log: Remove shared_pointer from NativeThreadProtocol Summary: The NativeThread class is useless without the containing process (and in some places it is already assuming

[Lldb-commits] [PATCH] D35618: Remove shared_pointer from NativeThreadProtocol

2017-10-17 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL316007: Remove shared_pointer from NativeThreadProtocol (authored by labath). Changed prior to commit: https://reviews.llvm.org/D35618?vs=107289&id=119338#toc Repository: rL LLVM https://reviews.llv

[Lldb-commits] [PATCH] D38897: Add specific ppc64le hardware watchpoint handler

2017-10-17 Thread Ana Julia Caetano via Phabricator via lldb-commits
anajuliapc updated this revision to Diff 119336. anajuliapc marked 6 inline comments as done. anajuliapc added a comment. - Add values to header file - Use std::array to declare m_hwp_regs - Use llvm's mask - Remove switch and use assert instead - Remove unnecessary 'else' - Change return https:

[Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

2017-10-17 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 119315. labath added a comment. Solve the problem using pthread_atfork(). This way the locks are properly taken before forking and released in both child and parent processes. This behavior is encapsulated within the Log class and is completely transparent to