davide added inline comments.
Comment at: source/Plugins/ABI/SysV-x86_64/ABISysV_x86_64.cpp:1916
+ std::string Name = std::string(reg_info->name);
+ bool IsCalleeSaved = llvm::StringSwitch(Name)
+.Cases("r12", "r13", "r14", "r15",
Currently this uses two ca
davide created this revision.
The goal of this patch is twofold:
First, it removes a wrong comment (at least, not correctly describing what the
function does).
Then, it rewrites the function to use a stringswitch where the registers are
enumerated explicitly instead of being computed programmati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312431: Add test case for attach-by-pid from different cwd
(authored by emaste).
Changed prior to commit:
https://reviews.llvm.org/D32522?vs=113067&id=113671#toc
Repository:
rL LLVM
https://reviews.
Author: emaste
Date: Sat Sep 2 18:44:35 2017
New Revision: 312431
URL: http://llvm.org/viewvc/llvm-project?rev=312431&view=rev
Log:
Add test case for attach-by-pid from different cwd
This was failing on FreeBSD prior to r312430.
Patch by Vignesh Balu.
Differential Revision: https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312430: FreeBSD: attach to pid from different cwd (authored
by emaste).
Changed prior to commit:
https://reviews.llvm.org/D32271?vs=113664&id=113669#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: emaste
Date: Sat Sep 2 18:41:31 2017
New Revision: 312430
URL: http://llvm.org/viewvc/llvm-project?rev=312430&view=rev
Log:
FreeBSD: attach to pid from different cwd
attach by pid worked when running from the directory from which the
target was launched, but failed from a different direc
emaste updated this revision to Diff 113664.
emaste added a comment.
correct variable
https://reviews.llvm.org/D32271
Files:
source/Host/freebsd/Host.cpp
Index: source/Host/freebsd/Host.cpp
===
--- source/Host/freebsd/Host.cpp
emaste added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:44
+"""Test attach by process id"""
+os.mkdir(os.path.join(os.getcwd(),'newdir'))
+
self.buildProgram('main.cpp',os.path.join(os.g
emaste added a comment.
Testing this just now I got:
FAIL: LLDB (/usr/bin/cc-x86_64) ::
test_attach_to_process_from_different_dir_by_id
(TestProcessAttach.ProcessAttachTestCase)
==
ERROR: test_attach_to_process
