[Lldb-commits] [PATCH] D36598: cmake + xcode: prevent gtests from using includes from project root

2017-08-11 Thread Tim Hammerquist via Phabricator via lldb-commits
penryu added a comment. Note that these changes were tested on Darwin with both cmake and xcode. https://reviews.llvm.org/D36598 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36620: Fix crash on parsing gdb remote packets

2017-08-11 Thread Christopher Book via Phabricator via lldb-commits
cbook created this revision. Prevent negative chars from being sign-extended into isprint and isspace which take and int and crash if the int is negative. https://reviews.llvm.org/D36620 Files: source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Index: source/Plugins/Process/gdb-r

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE and having section type debug doesn't contain any valid address

2017-08-11 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. So I looked at the instances of STT_NOTYPE in a few shared libraries on my computer and they do seem to have valid addresses in them. > there are two sections (.text and .debug_ranges) for the file address 0xbcf0. I don't see that from the log. I cleaned up the output

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE and having section type debug doesn't contain any valid address

2017-08-11 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Might need to retitle again as well https://reviews.llvm.org/D35784 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE and having section type debug doesn't contain any valid address

2017-08-11 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain added a comment. The $debug_rangesN symbols are added by linker. These symbols are not used anywhere We can skip these type of symbols (where symbol type is STT_NOTYPE and its section is Debug) https://reviews.llvm.org/D35784 ___ lldb-

[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE and having section type dwarf doesn't contain any valid address

2017-08-11 Thread Nitesh Jain via Phabricator via lldb-commits
nitesh.jain updated this revision to Diff 110698. nitesh.jain retitled this revision from "[LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address" to "[LLDB][MIPS] The symbol with NOTYPE and having section type dwarf doesn't contain any valid address". Herald added a subscriber: em