Re: [Lldb-commits] [lldb] r295369 - Fix build

2017-08-06 Thread Tim Hammerquist via lldb-commits
Thanks, Zachary. Maybe that's where I'm getting confused. What is the case that it's testing? It appears to simply be setting the locale such that the characters in Invalid fail to be encoded correctly, then asserts that (a) the call to VASPrintf() fails and (b) the resulting string is the expect

Re: [Lldb-commits] [lldb] r295369 - Fix build

2017-08-06 Thread Zachary Turner via lldb-commits
I believe locale codes are platform specific, so perhaps this ".932" is not present on these systems. This was always a risk, but there's no other good way to test this. Given that it's testing a very obscure error case, one option would be to remove the test. Another would be to find out a corr

Re: [Lldb-commits] [lldb] r295369 - Fix build

2017-08-06 Thread Tim Hammerquist via lldb-commits
Hi Zachary, Pavel, I'm working on integrating the VASprintfTest.cpp test and other unittests into the Xcode project and I wonder if I can get some information about the EncodingError test in LLDB's VASprintfTest.cpp. It seems to try to store the current locale; set the locale to a new, invalid lo