[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

2017-06-28 Thread Karnajit Wangkhem via Phabricator via lldb-commits
karnajitw added a comment. Adding the corresponing reference discussions with freebsd folks. mmap - https://lists.freebsd.org/pipermail/freebsd-hackers/2017-May/051072.html x87 tag- https://lists.freebsd.org/pipermail/freebsd-hackers/2017-June/051166.html Repository: rL LLVM https://reviews

[Lldb-commits] [lldb] r306634 - Fix two places in RegisterContextLLDB::InitializeNonZerothFrame where

2017-06-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jun 28 20:02:24 2017 New Revision: 306634 URL: http://llvm.org/viewvc/llvm-project?rev=306634&view=rev Log: Fix two places in RegisterContextLLDB::InitializeNonZerothFrame where I'm not running the saved pc through FixCodeAddress as soon as I should. Modified: ll

[Lldb-commits] [lldb] r306633 - Change the ABI class to have a weak pointer to its Process;

2017-06-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jun 28 19:57:03 2017 New Revision: 306633 URL: http://llvm.org/viewvc/llvm-project?rev=306633&view=rev Log: Change the ABI class to have a weak pointer to its Process; some methods in the ABI need a Process to do their work. Instead of passing it in as a one-off argument

[Lldb-commits] Buildbot numbers for the week of 06/18/2017 - 06/24/2017

2017-06-28 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 06/18/2017 - 06/24/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

[Lldb-commits] Buildbot numbers for the week of 06/11/2017 - 06/17/2017

2017-06-28 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the week of 06/11/2017 - 06/17/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[Lldb-commits] [lldb] r306611 - Added a project for the unified IR interpreter.

2017-06-28 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Wed Jun 28 15:51:16 2017 New Revision: 306611 URL: http://llvm.org/viewvc/llvm-project?rev=306611&view=rev Log: Added a project for the unified IR interpreter. Modified: lldb/trunk/www/projects.html Modified: lldb/trunk/www/projects.html URL: http://llvm.org/viewvc/llvm

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

2017-06-28 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek updated this revision to Diff 104514. https://reviews.llvm.org/D34774 Files: packages/Python/lldbsuite/test/functionalities/mtc/simple/Makefile packages/Python/lldbsuite/test/functionalities/mtc/simple/TestMTCSimple.py packages/Python/lldbsuite/test/functionalities/mtc/simple/mai

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

2017-06-28 Thread Karnajit Wangkhem via Phabricator via lldb-commits
karnajitw created this revision. Herald added a subscriber: emaste. Expression evaluation which takes the non IRInterpreter::Interpret path fails on i386-*-freebsd. Following changes are done to enable it. 1. Enable i386 ABI creation for freebsd 2. Added an extra argument in ABISysV_i386::Prepar

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

2017-06-28 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek added a comment. Actually, I think I need to extract the detection of libMainThreadChecker.dylib into a helper function, because I want to add more tests that will use it. https://reviews.llvm.org/D34774 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D34774: [lldb] Add a testcase for MainThreadCheckerRuntime plugin

2017-06-28 Thread Kuba (Brecka) Mracek via Phabricator via lldb-commits
kubamracek created this revision. This adds a simple testcase for MainThreadCheckerRuntime. The tool (Main Thread Checker) is only available on Darwin and in very new Xcode versions, so the test also detects the presence of `libMainThreadChecker.dylib` and is skipped if the tool is not availab

[Lldb-commits] [PATCH] D34750: [UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern

2017-06-28 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer added inline comments. Comment at: source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:875-876 + row->GetCFAValue().GetRegisterNumber() == m_lldb_fp_regnum) { + current_sp_bytes_offset_from_cfa = + row->GetCFAValue().GetOffset(

[Lldb-commits] [PATCH] D34750: [UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern

2017-06-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:875-876 + row->GetCFAValue().GetRegisterNumber() == m_lldb_fp_regnum) { + current_sp_bytes_offset_from_cfa = + row->GetCFAValue().GetOffset() - s

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

2017-06-28 Thread Abhishek via Phabricator via lldb-commits
abhishek.aggarwal updated this revision to Diff 104430. abhishek.aggarwal added a comment. Fixed one minor thing in CMakeFile https://reviews.llvm.org/D33035 Files: tools/CMakeLists.txt tools/intel-features/CMakeLists.txt tools/intel-features/README.txt tools/intel-features/cli-wrapper.

[Lldb-commits] [PATCH] D34750: [UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern

2017-06-28 Thread Tamas Berghammer via Phabricator via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good with one possible question Comment at: source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.cpp:875-876 + row->GetCFAValue().GetReg

[Lldb-commits] [PATCH] D34746: Move Timer and TraceOptions from Core to Utility

2017-06-28 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Can you do a diff before and after of the analyze-deps script output? I don't imagine it will make a difference, but I've been surprised by it before. In general you should do it before and after every patch of this nature. https://reviews.llvm.org/D34746

[Lldb-commits] [PATCH] D34750: [UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern

2017-06-28 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. The instruction pattern: and $-16, %esp sub $imm, %esp ... lea imm(%ebp), %esp appears when the compiler is realigning the stack (for example in main(), or almost everywhere with -mstackrealign switch). The "and" instruction is very difficult to model, but that's not

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

2017-06-28 Thread Abhishek via Phabricator via lldb-commits
abhishek.aggarwal updated this revision to Diff 104376. abhishek.aggarwal added a comment. Cmake files related changes - Using lldb's cmake functions insted of vanilla ones for cmake files https://reviews.llvm.org/D33035 Files: tools/CMakeLists.txt tools/intel-features/CMakeLists.txt too

[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature

2017-06-28 Thread Abhishek via Phabricator via lldb-commits
abhishek.aggarwal added a comment. Hi Pavel .. I have made the changes you suggested. My apologies for misinterpreting your previous comments but during written communications, it is sometimes difficult to interpret everything correctly. I have tried following LLDB's coding conventions and guid

[Lldb-commits] [PATCH] D34746: Move Timer and TraceOptions from Core to Utility

2017-06-28 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added subscribers: mgorny, emaste. The classes have no dependencies, and they are used both by lldb and lldb-server, so it makes sense for them to live in the lowest layers. https://reviews.llvm.org/D34746 Files: include/lldb/Core/Timer.h include/lldb/Co

[Lldb-commits] [PATCH] D34683: [unittests] Add a helper function for getting an input file

2017-06-28 Thread Pavel Labath via Phabricator via lldb-commits
labath marked an inline comment as done. labath added a comment. In https://reviews.llvm.org/D34683#792736, @eugene wrote: > The only comment I have is about location of TestUtilities.cpp. > Utility\Helpers kinda implies that these are helpers for Utility tests which > is not true. > > I would

[Lldb-commits] [PATCH] D34681: [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections

2017-06-28 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL306521: [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections (authored by labath). Repository: rL LLVM https://reviews.llvm.org/D34681 Files: lldb/trunk/include/lldb/Symbol/DW

[Lldb-commits] [lldb] r306521 - [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections

2017-06-28 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Jun 28 02:09:19 2017 New Revision: 306521 URL: http://llvm.org/viewvc/llvm-project?rev=306521&view=rev Log: [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections Summary: instead of using a boolean to differentiate between the two section types, use

[Lldb-commits] [PATCH] D34681: [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections

2017-06-28 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D34681#792602, @tatyana-krasnukha wrote: > Saying about clear intent, it would be even much more better if class name > doesn't start with DWARF ;) That's probably true. :) However, I think I've done enough of renaming of files lately that I

[Lldb-commits] [lldb] r306520 - Linux unit tests should only run on

2017-06-28 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Jun 28 02:01:17 2017 New Revision: 306520 URL: http://llvm.org/viewvc/llvm-project?rev=306520&view=rev Log: Linux unit tests should only run on Linux based systems. Modified: lldb/trunk/unittests/Process/CMakeLists.txt Modified: lldb/trunk/unittests/Process/CMakeL

[Lldb-commits] [lldb] r306516 - Implementation of Intel(R) Processor Trace support for Linux

2017-06-28 Thread Ravitheja Addepally via lldb-commits
Author: ravitheja Date: Wed Jun 28 00:58:31 2017 New Revision: 306516 URL: http://llvm.org/viewvc/llvm-project?rev=306516&view=rev Log: Implementation of Intel(R) Processor Trace support for Linux Summary: This patch implements support for Intel(R) Processor Trace in lldb server. The changes have