[Lldb-commits] Buildbot numbers for the last week of 05/21/2017 - 05/27/2017

2017-06-02 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 05/21/2017 - 05/27/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

[Lldb-commits] Buildbot numbers for the week of 05/14/2017 - 05/20/2017

2017-06-02 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the week of 05/14/2017 - 05/20/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[Lldb-commits] [PATCH] D33853: Avoid invalid string access in ObjCLanguage::MethodName::SetName

2017-06-02 Thread Stephane Sezer via Phabricator via lldb-commits
sas created this revision. Don't access `name[1] if the string is only of length 1. Avoids a crash/assertion failure when parsing the string `-`. Test Plan: Debug a swift binary, set a breakpoint, watch lldb not crash Original change by Paul Menage https://reviews.llvm.org/D33853 Files:

[Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: include/lldb/Host/Host.h:252 +result = f(args...); + while (result == fail_value && errno == EINTR); + return result; krytarowski wrote: > Will this build on Windows for their native API? If so, will it be useful >

Re: [Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Zachary Turner via lldb-commits
Maybe just ask on llvm dev what people's thoughts are? On Fri, Jun 2, 2017 at 7:51 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath updated this revision to Diff 101212. > labath added a comment. > > - fix freebsd typo > - use ::waitpid consistently > > > https://reviews

[Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: include/lldb/Host/Host.h:252 +result = f(args...); + while (result == fail_value && errno == EINTR); + return result; Will this build on Windows for their native API? If so, will it be useful there? https://r

[Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 101212. labath added a comment. - fix freebsd typo - use ::waitpid consistently https://reviews.llvm.org/D33831 Files: include/lldb/Host/Host.h source/Host/common/File.cpp source/Host/macosx/Host.mm source/Host/posix/ConnectionFileDescriptorPosix.cpp

Re: [Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Pavel Labath via lldb-commits
I've wondered about that as well.. I've seen a couple of places where this could be useful, but not nearly as many as in lldb. I'll let you be the judge of that. On 2 June 2017 at 15:43, Zachary Turner wrote: > I wonder if this should go in LLVM? > > On Fri, Jun 2, 2017 at 7:35 AM Pavel Labath vi

[Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:788 -WAIT_AGAIN: - // Wait for the operation thread to initialize. - if (sem_wait(&args->m_semaphore)) { -if (errno == EINTR) - goto WAIT_AGAIN; -else { - error.

Re: [Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Zachary Turner via lldb-commits
I wonder if this should go in LLVM? On Fri, Jun 2, 2017 at 7:35 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath created this revision. > Herald added subscribers: mgorny, emaste. > > It is intended to wrap functions which can fail with EINTR (which we > have a surprisin

[Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. Herald added subscribers: mgorny, emaste. It is intended to wrap functions which can fail with EINTR (which we have a surprising number of). It is inspired by the TEMP_FAILURE_RETRY macro in glibc, but I've c++-ified it and made it more generic (by specifying an expli

[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

2017-06-02 Thread Pavel Labath via Phabricator via lldb-commits
labath planned changes to this revision. labath added a comment. I am going to come back to this later, I'm going to create one or two more cleanup diffs which this will depend on. https://reviews.llvm.org/D33778 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] r304544 - cmake: Put PROCESS_VM_READV detection results into Config.h

2017-06-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Jun 2 07:29:08 2017 New Revision: 304544 URL: http://llvm.org/viewvc/llvm-project?rev=304544&view=rev Log: cmake: Put PROCESS_VM_READV detection results into Config.h Reviewers: beanz, eugene Subscribers: mgorny, lldb-commits Differential Revision: https://reviews.llvm

[Lldb-commits] [PATCH] D33771: cmake: Put PROCESS_VM_READV detection results into Config.h

2017-06-02 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304544: cmake: Put PROCESS_VM_READV detection results into Config.h (authored by labath). Changed prior to commit: https://reviews.llvm.org/D33771?vs=101012&id=101192#toc Repository: rL LLVM https:/