scott.smith added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1995-1996
//--
-TaskMapOverInt(0, num_compile_units, extract_fn);
+llvm::parallel::for_each_n(llvm::
Even though it creates a different TaskGroup for each one, TaskGroup itself
just says getDefaultExecutor, and that returns a global instance. On
Windows this will work because it all delegates to an OS thing that's sort
of like libdispatch and that does support recursion, but the thread pool
execu
scott.smith added inline comments.
Comment at: include/lldb/Utility/TaskPool.h:18-20
+ std::function cbs[sizeof...(T)]{tasks...};
+ llvm::parallel::for_each_n(llvm::parallel::par, static_cast(0),
+ sizeof...(T), [&cbs](size_t idx) { cbs[idx](); });
-
scott.smith added inline comments.
Comment at: include/lldb/Utility/TaskPool.h:18-20
+ std::function cbs[sizeof...(T)]{tasks...};
+ llvm::parallel::for_each_n(llvm::parallel::par, static_cast(0),
+ sizeof...(T), [&cbs](size_t idx) { cbs[idx](); });
-
zturner added inline comments.
Comment at: include/lldb/Utility/TaskPool.h:18-20
+ std::function cbs[sizeof...(T)]{tasks...};
+ llvm::parallel::for_each_n(llvm::parallel::par, static_cast(0),
+ sizeof...(T), [&cbs](size_t idx) { cbs[idx](); });
-
zturner added a comment.
Mostly just that implicit conversion operators are a very subtle source of
bugs, and you can't even find where they're being used because it's impossible
to grep for it.
If you're signing up to get an object that has strict usage semantics like
`llvm::Error`, you had b
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This seems fine to me.
Zachary didn't give reasons why he didn't like the conversion form so I can't
really assess that point. The use in the ErrorConversion test case seems
pretty natural
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303223: [Expression parser] Look up module symbols before
hunting globally (authored by spyffe).
Changed prior to commit:
https://reviews.llvm.org/D33083?vs=99211&id=99227#toc
Repository:
rL LLVM
ht
Author: spyffe
Date: Tue May 16 18:46:13 2017
New Revision: 303223
URL: http://llvm.org/viewvc/llvm-project?rev=303223&view=rev
Log:
[Expression parser] Look up module symbols before hunting globally
When it resolves symbol-only variables, the expression parser
currently looks only in the global
zturner added inline comments.
Comment at: source/Utility/Status.cpp:81-88
+Status::operator llvm::Error() {
+ if (Success())
+return llvm::Error::success();
+ if (m_type == ErrorType::eErrorTypePOSIX)
+return llvm::errorCodeToError(std::error_code(m_code,
std::generic
zturner added a reviewer: lhames.
zturner added inline comments.
Comment at: include/lldb/Utility/Status.h:108
+ explicit Status(llvm::Error error);
+ explicit operator llvm::Error();
+
I think we should remove the conversion operator. Instead, why don't we ma
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Very nice.
https://reviews.llvm.org/D33083
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
spyffe updated this revision to Diff 99211.
spyffe added a comment.
Used `CFLAGS_EXTRAS` instead of `CFLAGS` at Greg Clayton's suggestion.
https://reviews.llvm.org/D33083
Files:
include/lldb/Symbol/SymbolContext.h
packages/Python/lldbsuite/test/lang/c/conflicting-symbol/Makefile
packages/
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few makefile changes where CFLAGS is being modified and this will be
good to go. Much better location for this. Sean, please keep an eye out for
this kind of thing in the
spyffe updated this revision to Diff 99186.
spyffe added a comment.
Updated to reflect Pavel Labath's suggestions:
- Used `CFLAGS_NO_DEBUG` where appropriate
- Marked the testcase as having no debug info variants
https://reviews.llvm.org/D33083
Files:
include/lldb/Symbol/SymbolContext.h
pa
scott.smith created this revision.
scott.smith added a project: LLDB.
Herald added a subscriber: mgorny.
Remove the thread pool and for_each-like iteration functions.
Keep RunTasks, which has no analog in llvm::parallel, but implement it using
llvm::parallel.
Repository:
rL LLVM
https://revi
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
LGTM. :)
And yes - I think it's reasonable to add that MCJIT unit test case too.
Thanks for working on this!
https://reviews.llvm.org/D32899
__
labath created this revision.
I tried convert a function to llvm::Error/Expected but I quickly ran into the
issue of interfacing with code that still expects the Status objects.
This is my proposal for conversion functions between the two. I use
constructors and conversion operators on the Status
Author: labath
Date: Tue May 16 06:58:18 2017
New Revision: 303160
URL: http://llvm.org/viewvc/llvm-project?rev=303160&view=rev
Log:
Skip TestWatchedVarHitWhenInScope on android arm because it triggers a kernel
bug
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoi
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/lang/c/conflicting-symbol/One.mk:1
+LEVEL := ../../../make
+
Thanks for the effort. It almost works for me :), except for the part where you
clear out the CFLAGS. We cannot do that, as CFLA
vbalu added a comment.
In https://reviews.llvm.org/D32732#753348, @jingham wrote:
> That looks like the right way to do it. What was your thinking behind
> returning null rather than the partial list of variables already parsed if
> can_create is false? That doesn't seem like what somebody wh
21 matches
Mail list logo
