zturner added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:189
+if (key.size() >= 9 && key[0] == 'T' && key.substr(3, 6) == "thread") {
+ val.getAsInteger(16, stop_reply->thread);
+ key.substr(1, 2).getAsInteger(16, stop_reply->s
jmajors updated this revision to Diff 98869.
jmajors marked 2 inline comments as done.
jmajors added a comment.
Changed shared_ptr returns to Expected>.
Some other error processing additions.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
un
jmajors marked 7 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:142
+llvm::support::endianness endian) {
+ auto stop_reply = std::shared_ptr(new StopReply());
+
labath wrote:
> jmajors
krytarowski added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
zturner wrote:
> labath wrote:
> > krytarowski wrote:
> > > labath wrote:
> > > > krytarowski wrote:
> > > >
zturner added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
labath wrote:
> krytarowski wrote:
> > labath wrote:
> > > krytarowski wrote:
> > > > jmajors wrote:
> > > > > kr
labath added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
krytarowski wrote:
> labath wrote:
> > krytarowski wrote:
> > > jmajors wrote:
> > > > krytarowski wrote:
> > > >
krytarowski added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
labath wrote:
> krytarowski wrote:
> > jmajors wrote:
> > > krytarowski wrote:
> > > > jmajors wrote:
> > > >
krytarowski added a comment.
In https://reviews.llvm.org/D32930#753916, @labath wrote:
> next batch of comments from me (I expect to have more on monday). :)
>
> In https://reviews.llvm.org/D32930#752843, @krytarowski wrote:
>
> > I can build locally with `make thread_inferior`, how to run it?
>
zturner added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:167
+std::stringstream ss;
+ss << std::hex << std::setw(2) << std::setfill('0') << register_id;
+std::string hex_id = ss.str();
jmajors wrote:
> zturner wr
jmajors updated this revision to Diff 98858.
jmajors marked an inline comment as done.
jmajors added a comment.
More feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tool
jmajors marked 6 inline comments as done.
jmajors added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:25-30
+ elements["pid"].getAsInteger(16, pid);
+ elements["parent-pid"].getAsInteger(16, parent_pid);
+ elements["real-uid"].getAsInteger(1
labath added a comment.
next batch of comments from me (I expect to have more on monday). :)
In https://reviews.llvm.org/D32930#752843, @krytarowski wrote:
> I can build locally with `make thread_inferior`, how to run it?
run the `check-lldb-unit` target.
Comment at: unitte
Author: spyffe
Date: Fri May 12 16:53:44 2017
New Revision: 302954
URL: http://llvm.org/viewvc/llvm-project?rev=302954&view=rev
Log:
Fixed the OS X build after Error -> Status rename.
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
Author: eugene
Date: Fri May 12 15:44:09 2017
New Revision: 302948
URL: http://llvm.org/viewvc/llvm-project?rev=302948&view=rev
Log:
Fix build on Mac OS.
Modified:
lldb/trunk/source/Host/macosx/Host.mm
Modified: lldb/trunk/source/Host/macosx/Host.mm
URL:
http://llvm.org/viewvc/llvm-project/
krytarowski added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.h:33
+ uid_t real_uid;
+ unsigned int real_gid;
+ uid_t effective_uid;
Is there an option to use `gid_t`?
https://reviews.llvm.org/D32930
_
krytarowski added inline comments.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
jmajors wrote:
> krytarowski wrote:
> > jmajors wrote:
> > > zturner wrote:
> > > > This will work on MSVC an
zturner added a comment.
Getting pretty close. Sorry, still have a few more nits.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:25-30
+ elements["pid"].getAsInteger(16, pid);
+ elements["parent-pid"].getAsInteger(16, parent_pid);
+ elements["real-uid"].ge
jmajors updated this revision to Diff 98826.
jmajors marked an inline comment as done.
jmajors added a comment.
Feedback changes.
https://reviews.llvm.org/D32930
Files:
unittests/CMakeLists.txt
unittests/tools/CMakeLists.txt
unittests/tools/lldb-server/CMakeLists.txt
unittests/tools/lld
jmajors marked 17 inline comments as done.
jmajors added a comment.
More feedback changes.
Comment at: unittests/tools/lldb-server/inferior/thread_inferior.cpp:21
+
+ LLVM_BUILTIN_DEBUGTRAP;
+ delay = false;
krytarowski wrote:
> jmajors wrote:
> > zturner wro
jingham added a comment.
That looks like the right way to do it. What was your thinking behind
returning null rather than the partial list of variables already parsed if
can_create is false? That doesn't seem like what somebody who is bothering to
pass in can_create false intends.
Repositor
krytarowski added inline comments.
Comment at: unittests/tools/lldb-server/tests/MessageObjects.cpp:83-88
+ if (endian == LITTLE) {
+registers[register_id] = SwitchEndian(value_str);
+ }
+ else {
+registers[register_id] = stoul(value_str, nullptr, 1
vbalu updated this revision to Diff 98762.
vbalu added a comment.
Modified as per suggested. I used the flag option "flagsParsedVariables" to
monitor if global variable are completely parsed or not.
Looks like it never used. For a compile unit global variable will be parsed
only through the meth
22 matches
Mail list logo
