krytarowski updated this revision to Diff 96272.
krytarowski edited the summary of this revision.
krytarowski added a comment.
Herald added a subscriber: srhines.
Fix handling executable and shared library triple detection.
Apply changes from review.
Update revision summary.
Repository:
rL L
Thanks! I'm working on this, I will test new code soon and submit to review.
On 20.04.2017 15:51, Zachary Turner wrote:
> Note that getAsInteger returns false on success, so be careful!
> On Thu, Apr 20, 2017 at 6:09 AM Pavel Labath via Phabricator
> mailto:revi...@reviews.llvm.org>> wrote:
>
>
emaste added a comment.
Sorry I've been away from LLDB for a bit, I will take a look at this soon.
Repository:
rL LLVM
https://reviews.llvm.org/D32271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Author: emaste
Date: Fri Apr 21 20:38:54 2017
New Revision: 301067
URL: http://llvm.org/viewvc/llvm-project?rev=301067&view=rev
Log:
ThreadSanitizer plugin: match for loop variable with expected type
Removes Clang warning ThreadSanitizerRuntime.cpp:591:21: warning:
comparison of integers of diffe
emaste added a comment.
In https://reviews.llvm.org/D32125#728166, @krytarowski wrote:
> Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+
> years ago.
>
> It's perhaps no-op, but it might be noted in the commit message what
> platforms are supposed to be improved.
spyffe created this revision.
spyffe added a project: LLDB.
LLDB uses `clang::DeclContext`s for lookups, and variables get put into the
`DeclContext` for their //abstract origin//. (The abstract origin is a DWARF
pointer that indicates the unique definition of inlined code.) When the
expressi
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This is awesome! Thanks!
https://reviews.llvm.org/D32357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Author: jmolenda
Date: Fri Apr 21 15:19:28 2017
New Revision: 301034
URL: http://llvm.org/viewvc/llvm-project?rev=301034&view=rev
Log:
Correct the names of some target conditional defines in debugserver.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modified: lldb/trunk/tools/d
jafl created this revision.
jafl added a project: LLDB.
In CommandObjectRegisterRead.DoExecute(), set the status to "success" when
appropriate.
Repository:
rL LLVM
https://reviews.llvm.org/D32366
Files:
source/Commands/CommandObjectRegister.cpp
Index: source/Commands/CommandObjectRegist
This was the first time I'd used Enrico's class-based command interface. It is
much handier than the one-at-a time way of doing things.
We need to figure out a better way to package up and advertise these commands.
It would be nice to have a way for the broader community to be able to
contrib
labath created this revision.
the reason for this is two-fold:
- getaddrinfo without the extra arguments will return the same
(network-level) address multiple times, once for each supported
transport protocol, which is not what is usually intended (it certainly
wasn't in https://reviews.llvm.org
On Thu, Apr 20, 2017 at 9:00 PM Greg Clayton via Phabricator via
lldb-commits wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> Very close. A few misuses of ConstString and this will be good to go.
>
>
>
> ==
ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Thanks for catching this! Could you update this CL to let me commit it?
Comment at:
packages/Python/lldbsuite/test/tools/lldb-mi/control/TestMiExec.py:287-289
+
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
sounds reasonable
https://reviews.llvm.org/D32340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
labath added a comment.
Thank you for looking at this. My response is below.
In https://reviews.llvm.org/D32022#733223, @jasonmolenda wrote:
> Hi Pavel, I'd document the new flag in include/lldb/Core/Address.h where we
> have documentation for the other flags being used.
>
> It seems like we're
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, thank you.
Out of curiosity, have you observed any performance improvements resulting from
this?
Repository:
rL LLVM
https://reviews.llvm.org/D32306
___
This is cool, I just did some assembly debugging yesterday, and wished it
was easier :)
On 20 April 2017 at 22:51, Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jingham
> Date: Thu Apr 20 16:51:27 2017
> New Revision: 300902
>
> URL: http://llvm.org/viewvc/llvm-proje
nitesh.jain created this revision.
Herald added subscribers: arichardson, ki.stfu.
Call to s_MyFunction may not follow immediately after g_MyFunction. There might
be some instructions in between to restore caller-saved registers. We need to
get past these instructions with a step to reach call t
18 matches
Mail list logo
