kettenis updated this revision to Diff 92861.
kettenis added a comment.
Apologies. Previous diff contained a bogus change to DYLDRendezvous.cpp and a
formatting botch. Please review this updated version instead,
https://reviews.llvm.org/D31131
Files:
include/lldb/Host/Config.h
include/ll
kettenis updated this revision to Diff 92857.
kettenis marked an inline comment as done.
kettenis edited the summary of this revision.
kettenis added a comment.
Herald added subscribers: srhines, rengolin, emaste, aemerson.
New diff. This one adds support for OpenBSD/amd64, OpenBSD/arm, OpenBSD/ar
clayborg added a comment.
Let me know what you think about the MergeFrom comment. I am generally ok with
this, but just wanted to check in case the merge made any sense in this patch
somewhere.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:220
+ // informati
jingham added a comment.
Yes, that seems like the cleanest solution.
https://reviews.llvm.org/D31172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
BTW, other than the lack of a test, this is fine.
https://reviews.llvm.org/D31283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
It almost seems like we need some sort of an architecture plug-in here. Maybe
something like Architecture plugins. The Architecture::FindPlugin() would take
an ArchSpec and return a lldb_private::Architecture class instance that can be
cached in the target or process.
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
If you are exposing this, could you write a test to make sure it stays correct?
I added a sample test that you can easily copy and modify in:
packages/Python/lldbsuite/test/sample
labath added a comment.
Does anyone object to me landing this? I am going to be careful and wait for
the change to trickle through CI before submitting any followup changes.
https://reviews.llvm.org/D30984
___
lldb-commits mailing list
lldb-commits
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thank you.
https://reviews.llvm.org/D30457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Ah, that explains it, thanks.
Let's give Greg a chance to comment, but otherwise I am fine with this.
https://reviews.llvm.org/D31280
___
lldb-c
nitesh.jain added a comment.
The core architecture doesn't have any revision, os and ABI information. Hence
we need to relied on target architecture.
https://reviews.llvm.org/D31280
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:220
+ // information. Hence we need to relied on target architecture for that.
+ if (arch.IsValid() && !arch.IsMIPS())
+GetTarget().SetArchitecture(arch);
laba
labath added a comment.
Thank you for that.
I just have one more concern. I see two places where you are copying the
archspec from core file to the target and then back again. I must be missing
something, because that looks completely unnecessary at first sight. What is
the reason behind that?
nitesh.jain updated this revision to Diff 92808.
nitesh.jain added a comment.
updated diff as per suggestion
https://reviews.llvm.org/D31280
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalities/postmortem
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675
+ llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple());
+ target_arch.GetTriple().setOS(host_triple.getOS());
+}
nitesh.jain wrote:
> labath wr
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675
+ llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple());
+ target_arch.GetTriple().setOS(host_triple.getOS());
+}
labath wrote:
> nitesh.ja
brucem created this revision.
SBBreakpointLocation exposed the ignore count, but didn't expose
the hit count. Both values were exposed by SBBreakpoint and
SBWatchpoint, so this makes things a bit more consistent.
https://reviews.llvm.org/D31283
Files:
include/lldb/API/SBBreakpointLocation.h
brucem created this revision.
https://reviews.llvm.org/D31282
Files:
scripts/interface/SBBreakpoint.i
scripts/interface/SBModule.i
scripts/interface/SBSymbol.i
Index: scripts/interface/SBSymbol.i
===
--- scripts/interface/SBS
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675
+ llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple());
+ target_arch.GetTriple().setOS(host_triple.getOS());
+}
nitesh.jain wrote:
> labath wr
nitesh.jain added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675
+ llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple());
+ target_arch.GetTriple().setOS(host_triple.getOS());
+}
labath wrote:
> I'm not t
nitesh.jain added a comment.
They are around ~28KB
Repository:
rL LLVM
https://reviews.llvm.org/D31280
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
BTW, thank you for adding the test. It's not obvious from the patch: how big
are the core files?
Repository:
rL LLVM
https://reviews.llvm.org/D31280
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:675
+ llvm::Triple host_triple(llvm::sys::getDefaultTargetTriple());
+ target_arch.GetTriple().setOS(host_triple.getOS());
+}
I'm not terribly happy with th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298585: Fix warnings from clang build on macOS. (authored by
brucem).
Changed prior to commit:
https://reviews.llvm.org/D31279?vs=92764&id=92776#toc
Repository:
rL LLVM
https://reviews.llvm.org/D312
Author: brucem
Date: Thu Mar 23 04:52:26 2017
New Revision: 298585
URL: http://llvm.org/viewvc/llvm-project?rev=298585&view=rev
Log:
Fix warnings from clang build on macOS.
Reviewers: lldb-commits
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D31279
Modified:
ll
nitesh.jain added a comment.
Added test case for MIPS in https://reviews.llvm.org/D31280
https://reviews.llvm.org/D30457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nitesh.jain created this revision.
Herald added a subscriber: sdardis.
The MIPS core file doesn't contain any Architecture revision, OS and ABI
information. Hence we need to relied on executable to get that information.
This patch also add core file test cases for MIPS.
Patch By:- Bhushan
Rep
nitesh.jain updated this revision to Diff 92768.
nitesh.jain added a comment.
In case of MIPS, The ELFLinuxPrPsInfo.pr_uid and ELFLinuxPrPsInfo.pr_gid is
always 32 bit irrespective of platforms
https://reviews.llvm.org/D30457
Files:
source/Core/ArchSpec.cpp
source/Plugins/Process/FreeBSD/R
brucem created this revision.
https://reviews.llvm.org/D31279
Files:
source/Expression/LLVMUserExpression.cpp
source/Host/common/Symbols.cpp
source/Host/macosx/Symbols.cpp
source/Plugins/Process/Utility/DynamicRegisterInfo.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServ
29 matches
Mail list logo
