[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

2017-03-19 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: source/Plugins/Platform/CMakeLists.txt:8 +#elseif (CMAKE_SYSTEM_NAME MATCHES "OpenBSD") + add_subdirectory(OpenBSD) #elseif (CMAKE_SYSTEM_NAME MATCHES "Darwin") I would sort by subdirectory. Repository: rL LLVM

[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

2017-03-19 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: include/lldb/Host/Config.h:35 + +#include "lldb/Host/openbsd/Config.h" krytarowski wrote: > Missing in patch? I think that Config.h should go away. It's almost empty. But it's beyond the scope of this patch. Whil

[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

2017-03-19 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: include/lldb/Host/Config.h:35 + +#include "lldb/Host/openbsd/Config.h" Missing in patch? Repository: rL LLVM https://reviews.llvm.org/D31131 ___ lldb-commits mail

[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

2017-03-19 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added inline comments. Comment at: source/Host/openbsd/Host.cpp:223 + +#if 0 +lldb::DataBufferSP Host::GetAuxvData(lldb_private::Process *process) { Wasn't it already gone from there? Repository: rL LLVM https://reviews.llvm.org/D31131 ___

[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

2017-03-19 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski added a comment. Fantastic! I got a substantial portion of Process Plugin to work on NetBSD, to coordinate the work feel free to join IRC `#lldb` at OFTC -- e.g. do not waste time on FreeBSD Process Plugin. Demo: http://www.netbsd.org/~kamil/lldb/hello2.txt I'm working on on remai

[Lldb-commits] [PATCH] D31131: [LLDB] OpenBSD support

2017-03-19 Thread Mark Kettenis via Phabricator via lldb-commits
kettenis created this revision. Herald added a subscriber: mgorny. Add basic OpenBSD support. This is enough to be able to analyze core dumps for OpenBSD/amd64, but not much beyond that. Note that part of the changes to source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp fix a bug that probably aff

[Lldb-commits] [PATCH] D31129: Remove remaining platform specific code from FileSpec

2017-03-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner updated this revision to Diff 92287. zturner added a comment. Turns out `ResolveUsername` was only being called from one place outside of `FileSpec` and `ResolvePartialUsername` was dead code (since callers had already been updated to use `TildeExpressionResolver`. So I just deleted the

[Lldb-commits] [PATCH] D31129: Remove remaining platform specific code from FileSpec

2017-03-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. Herald added subscribers: mgorny, srhines. This is the last step before I plan to move `FileSpec` to `Utility`, which should completely eliminate between 3 and 5 dependencies from other targets to `Host`. https://reviews.llvm.org/D31129 Files: lldb/include/lld