hughbe edited reviewers, added: zturner; removed: beanz.
hughbe added a comment.
As per discussion on lists
https://reviews.llvm.org/D30927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
hughbe edited reviewers, added: zturner; removed: jingham, hughbe.
hughbe added a comment.
This revision now requires review to proceed.
As per discussion on lists
https://reviews.llvm.org/D30926
___
lldb-commits mailing list
lldb-commits@lists.llvm
Author: cbieneman
Date: Wed Mar 15 14:52:57 2017
New Revision: 297880
URL: http://llvm.org/viewvc/llvm-project?rev=297880&view=rev
Log:
[debugserver] NFC. One more small cleanup to DNBArchImplX86_64::SetFPUState
This is another similar cleanup to other changes I've been making to simplify
the AV
krytarowski added inline comments.
Comment at: source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:128
+ if (kp == nullptr || (error != 0 && errno == ENOMEM)) {
+// Add extra space in case threads are added before next call.
+len += sizeof(*kp) + len / 10;
-
krytarowski added a comment.
> remove the NetBSD version (which was probably incorrect anyway, as it assumes
> the current process instead of the inferior.
Yes, I had issues with this and I wanted to take rid of it completely during
the last month. I'm patching it out in my local LLDB tree... (
Finding the executables that a binary will load on run before you actually run
is always best effort. We don't require the ObjectFile class to fully emulate
the platform loader. So from the standpoint of writing tests, if the test
relies on getting symbols from a loaded library it should alway
krytarowski added a comment.
For your interest. NetBSD will not use procfs for any operation.
Today I implemented reading the process map with sysctl(7):
https://github.com/NetBSD/pkgsrc-wip/commit/d4af36204feb616dd83f5f3ffb871a4b7274e5e0
procfs is used by SunOS.. but for regular debuggers they
nitesh.jain added a comment.
In https://reviews.llvm.org/D30457#694306, @labath wrote:
> Thank you for updating that. Let me know what the make_core investigation
> uncovers.
In case of MIPS, the core file doesn't contain Arch and OS information. Hence
we shared information from executable.
nitesh.jain updated this revision to Diff 91881.
nitesh.jain added a comment.
Update Diff as per suggestion
https://reviews.llvm.org/D30457
Files:
source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp
labath created this revision.
Herald added a subscriber: srhines.
Herald added a reviewer: EricWF.
This aims to replace the different decorators we've had on each libc++
test with a single solution. Each libc++ will be assigned to the
"libc++" category and a single central piece of code will decid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297843: Remove some ProcFileReader occurences (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D30942?vs=91727&id=91875#toc
Repository:
rL LLVM
https://reviews.llvm.org/D30942
Author: labath
Date: Wed Mar 15 10:08:49 2017
New Revision: 297843
URL: http://llvm.org/viewvc/llvm-project?rev=297843&view=rev
Log:
Remove some ProcFileReader occurences
Summary:
ProcFileReader is the cause of the dependency from Host to ProcessLinux
module. Since it's interface is also obsolete
labath accepted this revision.
labath added a comment.
looks good to me, but please give Greg a chance to respond first.
https://reviews.llvm.org/D30454
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Hmm, i see you said freebsd needs this. Ignore my previous comment
On Wed, Mar 15, 2017 at 7:33 AM Zachary Turner wrote:
> Only linux needs this now afaict because on all other platforms, you can
> only get the name of the current thread, not an arbitrary thread, and that
> use case is covered by
Only linux needs this now afaict because on all other platforms, you can
only get the name of the current thread, not an arbitrary thread, and that
use case is covered by llvm. (Even if it *is* possible on other platforms,
only linux actually does it with an arbitrary thread)
With that in mind, ca
labath created this revision.
Herald added a subscriber: mgorny.
These classes existed only because of the GetName() static function,
which can be moved to a more natural place anyway. I move the linux
version to NativeProcessLinux (and get rid of ProcFileReader), the
freebsd version to ProcessFre
Author: labath
Date: Wed Mar 15 08:32:17 2017
New Revision: 297834
URL: http://llvm.org/viewvc/llvm-project?rev=297834&view=rev
Log:
Fix TestMoveNearest for remote targets
Launching a process with shared libraries on remote targets requires a
special dance, which I forgot to do in r297830.
Modif
Hi Jim,
I am not sure if behavior like this should be considered a bug, but I
wanted to make sure you don't miss this.
cheers,
pl
On 15 March 2017 at 12:32, Pavel Labath via lldb-commits
wrote:
> Author: labath
> Date: Wed Mar 15 07:32:18 2017
> New Revision: 297830
>
> URL: http://llvm.org/vi
Author: labath
Date: Wed Mar 15 07:32:18 2017
New Revision: 297830
URL: http://llvm.org/viewvc/llvm-project?rev=297830&view=rev
Log:
Fix TestMoveNearest breakage on darwin
It seems that on darwin we are not able to resolve breakpoints in the
test shared library until the process has started. That
nitesh.jain updated this revision to Diff 91855.
nitesh.jain retitled this revision from "[LLDB][MIPS] Regain Module Name if
memory_info.GetName() is empty" to "[LLDB][MIPS] Check if
memory_info.GetName() is empty before finding corresponding module.".
nitesh.jain edited the summary of this revi
labath added inline comments.
Comment at: source/Host/linux/Host.cpp:166
+ llvm::SmallString<64> ProcExe;
+ (llvm::Twine("/proc/") + llvm::Twine(pid) + "/exe").toVector(ProcExe);
+ llvm::SmallString<0> ExePath;
labath wrote:
> zturner wrote:
> > You can make t
Author: labath
Date: Wed Mar 15 05:02:16 2017
New Revision: 297818
URL: http://llvm.org/viewvc/llvm-project?rev=297818&view=rev
Log:
Delete empty file ProcessLauncherLinux.h
Removed:
lldb/trunk/include/lldb/Host/linux/ProcessLauncherLinux.h
Removed: lldb/trunk/include/lldb/Host/linux/Process
Author: labath
Date: Wed Mar 15 05:02:20 2017
New Revision: 297819
URL: http://llvm.org/viewvc/llvm-project?rev=297819&view=rev
Log:
Fix windows&darwin builds broken by r297812
Modified:
lldb/trunk/include/lldb/Utility/Log.h
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDPLog.cp
Author: labath
Date: Wed Mar 15 04:53:10 2017
New Revision: 297817
URL: http://llvm.org/viewvc/llvm-project?rev=297817&view=rev
Log:
BreakpointResolverFileLine: Restrict move-to-nearest-code from moving across
function boundaries
Summary:
This fixes the case where a user tries to set a breakpoin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297817: BreakpointResolverFileLine: Restrict
move-to-nearest-code from moving across… (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30817?vs=91693&id=91848#toc
Repository:
labath marked an inline comment as done.
labath added a comment.
In https://reviews.llvm.org/D30817#700825, @jingham wrote:
> This seems good to me. Thanks for doing this.
>
> I made a few inline comments, but none are serious.
>
> Maybe I'm a little over-cautious about this sort of thing, but
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297812: Remove lldb streams from the Log class completely
(authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30894?vs=91562&id=91841#toc
Repository:
rL LLVM
https://reviews.llv
Author: labath
Date: Wed Mar 15 04:06:58 2017
New Revision: 297812
URL: http://llvm.org/viewvc/llvm-project?rev=297812&view=rev
Log:
Remove lldb streams from the Log class completely
Summary:
previously we switched to llvm streams for log output, this completes
the switch for the error streams.
labath added inline comments.
Comment at: tools/lldb-server/LLDBServerUtilities.cpp:59-60
if (!success) {
- fprintf(stderr, "Unable to open log file '%s' for channel \"%s\"\n",
- log_file.c_str(), channel_with_categories.str().c_str());
+ fprintf(stder
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297811: dotest.py: remove the ability to specify different
architectures/compilers in a… (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D30779?vs=91157&id=91838#toc
Repository:
Author: labath
Date: Wed Mar 15 03:51:59 2017
New Revision: 297811
URL: http://llvm.org/viewvc/llvm-project?rev=297811&view=rev
Log:
dotest.py: remove the ability to specify different architectures/compilers in a
single invocation
Summary:
This has been broken at least since the new test result
labath added a subscriber: tberghammer.
labath added inline comments.
Comment at: source/Core/DynamicLoader.cpp:193
memory_info.GetRange().GetRangeBase() == base_addr) {
+ // Regain name if memory_info.GetName is empty
+ if (memory_info.GetName().IsEmpty())
---
nitesh.jain updated this revision to Diff 91833.
nitesh.jain retitled this revision from "[LLDB][MIPS] Fix typo in
MatchesModuleSpec()" to "[LLDB][MIPS] Regain Module Name if
memory_info.GetName() is empty".
nitesh.jain added a comment.
In case of debugging normal process, the memory_info.GetNa
33 matches
Mail list logo
