[Lldb-commits] [PATCH] D30624: Remove all of LLDB's custom filesystem statting code.

2017-03-05 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. Herald added a subscriber: emaste. LLVM provides this functionality, so there is no point duplicating it. This is a pretty large patch because we call functions like `FileSpec::IsRegularFile()`, or `FileSpec::GetFileType()` all over the place, and all of these ar

[Lldb-commits] [PATCH] D30622: Remove FileSpec::ReadFileContents

2017-03-05 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. The idea is that `DataBufferLLVM` already covers this use case, so there is no point duplicating the code. The only tricky thing is that I found one case where we attempt to modify the bytes we read in (in `ObjectFilePECOFF`). It seems kind of hackish, but it wo