Author: labath
Date: Wed Feb 8 19:17:34 2017
New Revision: 294549
URL: http://llvm.org/viewvc/llvm-project?rev=294549&view=rev
Log:
[cmake] add missing dependency lldbCommands->lldbBase
CommandObjectVersion.cpp calls lldb_private::GetVersion (present in lldbBase).
This should fix the unittest l
labath added a comment.
Thank you for the review. I'll submit this tomorrow.
In https://reviews.llvm.org/D29615#670879, @clayborg wrote:
> Looks good as long as if we type two log enable commands like:
>
> (lldb) log enable -f /tmp/a.txt lldb process
> (lldb) log enable -f /tmp/a.txt lldb ap
Hello everyone,
Below are some buildbot numbers for the last week of 01/29/2017 -
02/04/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Author: cbieneman
Date: Wed Feb 8 15:24:51 2017
New Revision: 294521
URL: http://llvm.org/viewvc/llvm-project?rev=294521&view=rev
Log:
[CMake] Add dependency on Mips target if it is available
The Mips plugins conditionally link the Mips backend, so we need to
conditionally add the target as a d
Author: cbieneman
Date: Wed Feb 8 15:00:46 2017
New Revision: 294515
URL: http://llvm.org/viewvc/llvm-project?rev=294515&view=rev
Log:
[CMake] Final dependency cleanup patch!
Summary:
This patch removes the over-specified dependencies from LLDBDependencies and
instead relies on the dependencies
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294515: [CMake] Final dependency cleanup patch! (authored by
cbieneman).
Changed prior to commit:
https://reviews.llvm.org/D29352?vs=87265&id=87701#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would prefer to see NativeBreakpoint struct expanded to have more member
variables instead of adding a new hardware breakpoint list. Then you just ask
any breakpoint to enable/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as if we type two log enable commands like:
(lldb) log enable -f /tmp/a.txt lldb process
(lldb) log enable -f /tmp/a.txt lldb api
share the same log stream (we don't
Aside from the thread stuff, nothing seems particularly risky about this
change. Did the thread-local stuff you removed have anything to do with
the -t option to the log command?
On Wed, Feb 8, 2017 at 9:15 AM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> wrote:
> labath added a comme
labath added a comment.
Ping. Any thoughts on this?
https://reviews.llvm.org/D29615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
10 matches
Mail list logo