Re: [Lldb-commits] [lldb] r291198 - Make lldb -Werror clean for -Wstring-conversion

2017-01-05 Thread David Blaikie via lldb-commits
Ah, thanks - r291204 should hopefully do it, otherwise I might need some help. I'm assuming I'm not actually building this code - think I just ended up touching it after doing a bunch of manual cleanup then resorting to sed - so possibly ended up touching code that isn't building in my configuratio

[Lldb-commits] [lldb] r291204 - Revert part of cleanup to fix a build break

2017-01-05 Thread David Blaikie via lldb-commits
Author: dblaikie Date: Thu Jan 5 19:42:56 2017 New Revision: 291204 URL: http://llvm.org/viewvc/llvm-project?rev=291204&view=rev Log: Revert part of cleanup to fix a build break Wasn't sure I could include ErrorHandling.h here, and evidently I wasn't building this part (must've made the change u

Re: [Lldb-commits] [lldb] r291198 - Make lldb -Werror clean for -Wstring-conversion

2017-01-05 Thread Tim Hammerquist via lldb-commits
Green Dragon build < http://lab.llvm.org:8080/green/job/lldb_build_test/23854/> failed with this commit with the error: CompileC build/debugserver.build/Release/debugserver.build/Objects-normal/x86_64/DNBDataRef.o source/DNBDataRef.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler

[Lldb-commits] [lldb] r291199 - Fix -Wunused-function warning by preprocessor conditionalizing the function the same way as the caller

2017-01-05 Thread David Blaikie via lldb-commits
Author: dblaikie Date: Thu Jan 5 18:38:10 2017 New Revision: 291199 URL: http://llvm.org/viewvc/llvm-project?rev=291199&view=rev Log: Fix -Wunused-function warning by preprocessor conditionalizing the function the same way as the caller Modified: lldb/trunk/source/Plugins/Process/POSIX/Cras

[Lldb-commits] [lldb] r291198 - Make lldb -Werror clean for -Wstring-conversion

2017-01-05 Thread David Blaikie via lldb-commits
Author: dblaikie Date: Thu Jan 5 18:38:06 2017 New Revision: 291198 URL: http://llvm.org/viewvc/llvm-project?rev=291198&view=rev Log: Make lldb -Werror clean for -Wstring-conversion Also found/fixed one bug identified by this warning in RenderScriptx86ABIFixups.cpp where a string literal was bei

[Lldb-commits] [lldb] r291200 - Fixes for Clang API changes to use std::shared_ptr

2017-01-05 Thread David Blaikie via lldb-commits
Author: dblaikie Date: Thu Jan 5 18:38:12 2017 New Revision: 291200 URL: http://llvm.org/viewvc/llvm-project?rev=291200&view=rev Log: Fixes for Clang API changes to use std::shared_ptr Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp Modified: lldb/trun

Re: [Lldb-commits] [PATCH] D19603: Fix entry point lookup for ObjectFilePECOFF.

2017-01-05 Thread Stephane Sezer via lldb-commits
I'm currently busy with other stuff but I'll get back to this soon. I think we have a different version of this internally which seems to work properly, so I'll make sure everything is clean and re-upload a better version. On Tue, Dec 20, 2016 at 11:34 AM, Greg Clayton via Phabricator wrote: > cl

[Lldb-commits] [PATCH] D28305: [Host] Handle short reads and writes, take 3

2017-01-05 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I've done a bit of investigation, and there is still a lot of `FILE*` usage in random places. I believe most of them would be pretty easy to get rid of (https://reviews.llvm.org/D28356 is one of the more complicated cases). However, the main problem I see is the SB API,

[Lldb-commits] [PATCH] D28356: Consolidate file handle usage in Editline.cpp

2017-01-05 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. To implement wide character reading, editline was mixing FILE*-based access with a Connection-based one (plus it did some selects on the raw FD), which is very fragile. Here, I replace

[Lldb-commits] [lldb] r291118 - Skip a test on darwin.

2017-01-05 Thread Hafiz Abid Qadeer via lldb-commits
Author: abidh Date: Thu Jan 5 09:09:07 2017 New Revision: 291118 URL: http://llvm.org/viewvc/llvm-project?rev=291118&view=rev Log: Skip a test on darwin. My earlier commit today seem to cause a failure on a darwin buildbot. I am skipping the test while I investigate the failure. Modified:

[Lldb-commits] [PATCH] D24711: [lldb-mi] Fix implementation for a few mi commands

2017-01-05 Thread Hafiz Abid Qadeer via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL291104: [lldb-mi] Fix implementation for a few mi commands (authored by abidh). Changed prior to commit: https://reviews.llvm.org/D24711?vs=82654&id=83225#toc Repository: rL LLVM https://reviews.llv

[Lldb-commits] [lldb] r291104 - [lldb-mi] Fix implementation for a few mi commands

2017-01-05 Thread Hafiz Abid Qadeer via lldb-commits
Author: abidh Date: Thu Jan 5 07:23:47 2017 New Revision: 291104 URL: http://llvm.org/viewvc/llvm-project?rev=291104&view=rev Log: [lldb-mi] Fix implementation for a few mi commands Summary: Some of the mi commands implemented in lldb-mi are incomplete/not confirming to the spec. - `gdb-show` a

[Lldb-commits] [lldb] r291103 - Fix jModulesInfo handling for cross-path syntax debugging

2017-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 5 07:18:46 2017 New Revision: 291103 URL: http://llvm.org/viewvc/llvm-project?rev=291103&view=rev Log: Fix jModulesInfo handling for cross-path syntax debugging We were sending paths with the host path separator, which meant the remote target did not understand our p

[Lldb-commits] [lldb] r291102 - Silence some -Wstring-conversion warnings

2017-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 5 07:18:42 2017 New Revision: 291102 URL: http://llvm.org/viewvc/llvm-project?rev=291102&view=rev Log: Silence some -Wstring-conversion warnings lldbassert(!"foo") -> lldbassert(0 && "foo") In one case, this actually detected a logic error in the assertion (missing

[Lldb-commits] [lldb] r291100 - XFAIL an lldb-mi test

2017-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jan 5 06:03:49 2017 New Revision: 291100 URL: http://llvm.org/viewvc/llvm-project?rev=291100&view=rev Log: XFAIL an lldb-mi test the test fails due to a bug in ToT clang Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-mi/stack/TestMiStack.py Modified