Re: [Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

So I ran into a nasty problem doing the rest of the conversions and at the moment I'm not sure if there's even a workaround. So this is on hold while I think about it. On Thu, Dec 15, 2016 at 8:06 PM Zachary Turner via Phabricator < revi...@reviews.llvm.org> wrote: > zturner added a comment. > >

[Lldb-commits] [lldb] r289922 - Add methods to enable using formatv syntax in LLDB.

Author: zturner Date: Thu Dec 15 22:27:00 2016 New Revision: 289922 URL: http://llvm.org/viewvc/llvm-project?rev=289922&view=rev Log: Add methods to enable using formatv syntax in LLDB. This adds formatv-backed formatting functions in various places in LLDB such as StreamString, logging, construc

[Lldb-commits] [PATCH] D27632: Add Formatv() versions of all our printf style formatting functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL289922: Add methods to enable using formatv syntax in LLDB. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D27632?vs=80992&id=81713#toc Repository: rL LLVM https://reviews.

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

zturner added a comment. Greg, did the comments about implicit construction of a `StringRef` from a char literal being zero overhead make sense? If so, are there any other concerns? https://reviews.llvm.org/D27780 ___ lldb-commits mailing list lld

[Lldb-commits] [lldb] r289913 - Fix a bug when using a StructuredData darwin-log plugin

Author: jmolenda Date: Thu Dec 15 20:48:39 2016 New Revision: 289913 URL: http://llvm.org/viewvc/llvm-project?rev=289913&view=rev Log: Fix a bug when using a StructuredData darwin-log plugin where we would insert a breakpoint into a system library but never remove it, so the second time we ran the

[Lldb-commits] [PATCH] D25922: Test infra: expose CFLAGS_NO_ARCH for use by test custom build rules

tfiala abandoned this revision. tfiala added a comment. @jingham, there may be some reconciliation needed between here and swift-lldb. I'm bowing out of this one. https://reviews.llvm.org/D25922 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

tfiala added a comment. Looks reasonable to me. @beanz, any comments on this? https://reviews.llvm.org/D23977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

tfiala abandoned this revision. tfiala added a comment. This one needs more analysis. I'm bowing out of it. Greg, you might want to pick this one up? https://reviews.llvm.org/D26510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://

[Lldb-commits] [lldb] r289879 - [CMake] Refactor LLDB libraries and tools to be components

Author: cbieneman Date: Thu Dec 15 16:01:17 2016 New Revision: 289879 URL: http://llvm.org/viewvc/llvm-project?rev=289879&view=rev Log: [CMake] Refactor LLDB libraries and tools to be components In LLVM's CMake we have a convention that components have both a build and an install target. Making

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

zturner removed rL LLVM as the repository for this revision. zturner updated this revision to Diff 81625. zturner added a comment. Re-upload the correct diff. https://reviews.llvm.org/D27780 Files: lldb/include/lldb/Interpreter/Options.h lldb/include/lldb/lldb-private-types.h lldb/source/

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

zturner reopened this revision. zturner added a comment. My bad, this revision was not actually closed, I attached the wrong diff to an unrelated commit. I will need to re-upload this one. Repository: rL LLVM https://reviews.llvm.org/D27780 ___

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rL289853: [StringRef] Add enable-if to StringLiteral. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D27780?vs=81487&id=81624#toc Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [lldb] r289842 - [CMake] Ensure Python files are inside the LLDB framework bundle

Author: cbieneman Date: Thu Dec 15 12:19:10 2016 New Revision: 289842 URL: http://llvm.org/viewvc/llvm-project?rev=289842&view=rev Log: [CMake] Ensure Python files are inside the LLDB framework bundle When building the LLDB Framework we need to ensure that the Python files get put into the Frame

[Lldb-commits] [lldb] r289841 - [CMake] Only support LLDB_BUILD_FRAMEWORK on CMake 3.7 and later

Author: cbieneman Date: Thu Dec 15 12:18:47 2016 New Revision: 289841 URL: http://llvm.org/viewvc/llvm-project?rev=289841&view=rev Log: [CMake] Only support LLDB_BUILD_FRAMEWORK on CMake 3.7 and later CMake's framework target generation was unable to generate POST_BUILD steps (see: https://gitla

Re: [Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

Hi Zachary On 15/12/16 17:52, Zachary Turner wrote: I think this was lgtm'ed wasn't it? Chris checked the cmake changes, so if you're happy with the python fixes I'll go ahead and commit this. Thanks Luke ___ lldb-commits mailing list lldb-commit

Re: [Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

I think this was lgtm'ed wasn't it? On Thu, Dec 15, 2016 at 9:46 AM Luke Drummond via Phabricator < revi...@reviews.llvm.org> wrote: > ldrumm marked 2 inline comments as done. > ldrumm added a comment. > > ping > > > https://reviews.llvm.org/D26757 > > > >

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm marked 2 inline comments as done. ldrumm added a comment. ping https://reviews.llvm.org/D26757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r289821 - Fix build for mingw.

Author: abidh Date: Thu Dec 15 09:00:41 2016 New Revision: 289821 URL: http://llvm.org/viewvc/llvm-project?rev=289821&view=rev Log: Fix build for mingw. Summary: I was building lldb using cross mingw-w64 toolchain on Linux and observed some issues. This is first patch in the series to fix that b

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

abidh accepted this revision. abidh added a reviewer: abidh. abidh marked an inline comment as done. abidh added a comment. This revision is now accepted and ready to land. Accepted in email. https://reviews.llvm.org/D27759 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

abidh updated this revision to Diff 81576. abidh added a comment. Replaced /D with -D as per comments. https://reviews.llvm.org/D27759 Files: cmake/LLDBDependencies.cmake cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake include/lldb/Host/windows/windows.h source/API/SystemIn

Re: [Lldb-commits] [PATCH] D27759: Fix build for mingw.

Looks good On Thu, Dec 15, 2016 at 2:16 AM Hafiz Abid Qadeer via Phabricator < revi...@reviews.llvm.org> wrote: > abidh added a comment. > > In https://reviews.llvm.org/D27759#622332, @labath wrote: > > > Yeah, I meant using it everywhere as a generic "am I on windows, > regardless of the compiler

[Lldb-commits] [lldb] r289801 - Remove linux/personality.h wrapper

Author: labath Date: Thu Dec 15 04:47:40 2016 New Revision: 289801 URL: http://llvm.org/viewvc/llvm-project?rev=289801&view=rev Log: Remove linux/personality.h wrapper This code is currently unused. Removing it should make porting of the linux plugin to NetBSD easier, and we can always add it la

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

labath added a comment. Looks reasonable. I look forward to using StringRef in more places. https://reviews.llvm.org/D27780 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D27759: Fix build for mingw.

abidh added a comment. In https://reviews.llvm.org/D27759#622332, @labath wrote: > Yeah, I meant using it everywhere as a generic "am I on windows, regardless > of the compiler" check. (Assuming Zach is fine with that) OK. If Zachary is fine with that then I can do that in a separate commit.