zturner updated this revision to Diff 80992.
zturner added a comment.
Added a format provider for `FileSpec`. Style syntax is documented in this
patch. Added some unit tests so you can see the output.
To answer Greg's earlier question about printing c-strings, `formatv("'{0}'
'{1}' '{2}'", (c
Seems reasonable, I'll make a FileSpec formatter and update the patch
On Fri, Dec 9, 2016 at 4:03 PM Greg Clayton via Phabricator <
revi...@reviews.llvm.org> wrote:
> clayborg requested changes to this revision.
> clayborg added a comment.
> This revision now requires changes to proceed.
>
> I wou
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I would like to see the FileSpec having its formatv stuff done for this since
it will start a whole slew of people wanting to use it and we should have an
example of a class that
clayborg added a comment.
It is nice to be able to use StringRef and std::string as is. I was wondering
if you have:
StringRef null;
StringRef empty("");
StringRef hello("hello")
What does this show:
formatv("{0} {1} {2}", null, empty, hello);
I would hope for:
(null) "" "hello"
Whe
zturner created this revision.
zturner added reviewers: labath, clayborg, jingham.
zturner added a subscriber: lldb-commits.
We have various functions like `Stream::Printf()`, and
`Error::SetErrorStringWithFormat()`, `Log::Printf()`, and various others. I
added functions that delegate to `forma
clayborg added a comment.
If we can parse the register info that was retrieved via the GDB remote packets
and emulate the DWARF expression that would allow us to do things correctly in
the test case. Anything that is agnostic will work and we probably have all the
info we need. We will need to
Author: gclayton
Date: Fri Dec 9 11:54:59 2016
New Revision: 289233
URL: http://llvm.org/viewvc/llvm-project?rev=289233&view=rev
Log:
Fix i386 being able to show member variables correctly by not returning empty
objective C types from the runtime.
We don't parse ObjC v1 types from the runtime m
Author: gclayton
Date: Fri Dec 9 10:25:13 2016
New Revision: 289223
URL: http://llvm.org/viewvc/llvm-project?rev=289223&view=rev
Log:
Fix buildbots that are failing due to this test by adding all expected fails
that TestMultipleDebuggers.py has.
Modified:
lldb/trunk/packages/Python/lldbsu
Author: gclayton
Date: Fri Dec 9 10:22:10 2016
New Revision: 289222
URL: http://llvm.org/viewvc/llvm-project?rev=289222&view=rev
Log:
Rename multiple target test so it is unique.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/api/multiple-targets/TestMultipleTargets.py
Modified:
lld
nitesh.jain added a comment.
Hi Greg,
The patch https://reviews.llvm.org/D20357 evaluated the DwarfExpression and
update the floating point register size. So should we implement
SBRegisterContext and SBArchSpec to evaluate dwarf expression and update the
floating point register size according
Author: nitesh.jain
Date: Fri Dec 9 07:54:47 2016
New Revision: 289211
URL: http://llvm.org/viewvc/llvm-project?rev=289211&view=rev
Log:
[LLDB][MIPS] Fix TestWatchpointIter failure
Reviewers: jingham
Subscribers: jaydeep, bhushan, slthakur, lldb-commits
Differential Revision: https://reviews.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289211: [LLDB][MIPS] Fix TestWatchpointIter failure
(authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D27124?vs=80414&id=80895#toc
Repository:
rL LLVM
https://reviews.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289210: [LLDB][MIPS] Fix TestMultipleHits for MIPS (authored
by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D27085?vs=79038&id=80893#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: nitesh.jain
Date: Fri Dec 9 07:44:15 2016
New Revision: 289210
URL: http://llvm.org/viewvc/llvm-project?rev=289210&view=rev
Log:
[LLDB][MIPS] Fix TestMultipleHits for MIPS
Reviewers: clayborg, labath, zturner
Subscribers: jaydeep, bhushan, slthakur, lldb-commits
Differential Revision:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289209: [LLDB][MIPS] Fix some test case failures due to
elf_abi field of qprocessInfo… (authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D26542?vs=77603&id=80892#toc
Reposito
Author: nitesh.jain
Date: Fri Dec 9 07:37:14 2016
New Revision: 289209
URL: http://llvm.org/viewvc/llvm-project?rev=289209&view=rev
Log:
[LLDB][MIPS] Fix some test case failures due to elf_abi field of qprocessInfo
packet.
Reviewers: jaydeep, bhushan, clayborg
Subscribers: slthakur, lldb-commi
labath added a comment.
I'll respond to your comments on the lldb-dev thread.
Comment at: include/lldb/Core/Log.h:218-219
+ << llvm::formatv(
\
+ "{0,-60}: ",
jasonmolenda added a comment.
A couple of thoughts / two cents.
I don't mind the current if (log) { ... } style of logging, even with the
PRIx64's and having to do filepath.GetPath().c_str() and all that. I like
being able to do extra work in a if (log) block of code -- create a
SymbolContext
Author: labath
Date: Fri Dec 9 04:05:07 2016
New Revision: 289199
URL: http://llvm.org/viewvc/llvm-project?rev=289199&view=rev
Log:
Fix TestMultipleTargets for on x86_64 architectures
This test links against liblldb, so it can only run when the target arch is the
same arch as liblldb. We already
19 matches
Mail list logo
