vadimcn created this revision.
vadimcn added reviewers: zturner, hans.
vadimcn added a subscriber: lldb-commits.
vadimcn set the repository for this revision to rL LLVM.
vadimcn added a project: LLDB.
Herald added a subscriber: mgorny.
With this change, "script import lldb" succeeds when executed
labath added a comment.
This discussion has diverged across lldb-dev and lldb-commits. I think we
should move it to one place. I propose lldb-dev, as that seems a better place
for high-level discussions.
https://reviews.llvm.org/D27459
___
lldb-co
jingham added a comment.
I not infrequently have some non-trivial code in the "if (log)" block that
gathers the information that I am then going to print, or loops over entities
printing them. Putting more complex code like that inside a macro looks awful
and is hard to debug. I don't think t
zturner added a comment.
In https://reviews.llvm.org/D27459#614672, @clayborg wrote:
> Does llvm::formatv allow you to specify the base of integers, or just where
> they go? Can you give it width, number base, leading characters and other
> things like a lot of what printf does?
You can speci
zturner added a comment.
In https://reviews.llvm.org/D27459#614670, @clayborg wrote:
> Part of the reason I like the current "if (log) log->Printf()" is that it
> doesn't cost you much if logging isn't enabled. So if you have a log line
> like:
>
> if (log)
> log->Printf("%s %s %s", myStr
clayborg added a comment.
I am fine with us changing logging, just want to make sure it works well.
Ideally it would include:
- almost zero cost when logging disabled. No arguments should be passed to any
functions and then determine that logging is disabled, it should check if
logging is enab
clayborg added a comment.
Does llvm::formatv allow you to specify the base of integers, or just where
they go? Can you give it width, number base, leading characters and other
things like a lot of what printf does?
https://reviews.llvm.org/D27459
clayborg added a comment.
Part of the reason I like the current "if (log) log->Printf()" is that it
doesn't cost you much if logging isn't enabled. So if you have a log line like:
if (log)
log->Printf("%s %s %s", myStringRef1.str().c_str(),
myStringRef2.str().c_str(), myStringRef3.str().c
clayborg added a comment.
The other way to do this that might be easier is to require this register is
always read via a "p" packet and watch for the size that comes back and adjust
the register size for that register accordingly.
https://reviews.llvm.org/D27088
clayborg added a comment.
We should be able to handle this being thread specific. Each stop reply packet
and qThreadStopInfo (asks for a complete stop reply packet for each thread), or
the the "jThreadsInfo" packet (see "$trunk/docs/lldb-gdb-remote.txt" for
detail) has the ability to return key
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Great, thanks!
https://reviews.llvm.org/D27124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
labath added a comment.
In https://reviews.llvm.org/D27459#614549, @zturner wrote:
> A couple comments:
>
> 1. If we're going to use `formatv` (yay!) then let's standardize. No point
> mising `formatv` and streaming, especially when the former will almost always
> be less verbose.
In this ch
> On Dec 6, 2016, at 1:42 AM, Tamas Berghammer via Phabricator
> wrote:
>
> tberghammer added a reviewer: aprantl.
> tberghammer added a comment.
>
> +Adrian
>
> Thank you for all the comment. I agree that teaching the AST Importer to be
> able to handle types inside a DeclBlock would be the
zturner added a comment.
A couple comments:
1. If we're going to use `formatv` (yay!) then let's standardize. No point
mising `formatv` and streaming, especially when the former will almost always
be less verbose.
2. One of the concerns that came up last time was that of evaluating the
argum
labath created this revision.
labath added a subscriber: lldb-commits.
https://reviews.llvm.org/D27459
Files:
include/lldb/Core/Log.h
source/Plugins/Process/Linux/NativeProcessLinux.cpp
Index: source/Plugins/Process/Linux/NativeProcessLinux.cpp
===
nitesh.jain added a comment.
Hi Greg,
I am not sure whether this approach will work in Multithreaded application.
Since if any thread modify the SR.FR bit then the change will get reflect in
all copy of SR.FR of all other threads. So if we stop at thread A and thread B
(running) try to modify
nitesh.jain updated this revision to Diff 80414.
nitesh.jain added a comment.
Update diff as per suggestion
https://reviews.llvm.org/D27124
Files:
source/Target/StopInfo.cpp
Index: source/Target/StopInfo.cpp
===
--- source/Targ
Author: labath
Date: Tue Dec 6 05:24:51 2016
New Revision: 288797
URL: http://llvm.org/viewvc/llvm-project?rev=288797&view=rev
Log:
Use Timeout<> in EvaluateExpressionOptions class
Modified:
lldb/trunk/include/lldb/Target/Target.h
lldb/trunk/source/API/SBExpressionOptions.cpp
lldb/tr
tberghammer added a reviewer: aprantl.
tberghammer added a comment.
+Adrian
Thank you for all the comment. I agree that teaching the AST Importer to be
able to handle types inside a DeclBlock would be the best long term solution
but I am not sure about its complexity and feasibility (will take
19 matches
Mail list logo
