alexshap created this revision.
alexshap added reviewers: clayborg, spyffe.
alexshap added a subscriber: lldb-commits.
alexshap set the repository for this revision to rL LLVM.
This diff
1. Adds a comment to ObjectFileELF.cpp about the current
approach to determining the OS.
2. Replaces the che
Thanks, Kuba!
On Fri, Dec 2, 2016 at 2:11 PM, Kuba Mracek via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: kuba.brecka
> Date: Fri Dec 2 16:11:26 2016
> New Revision: 288542
>
> URL: http://llvm.org/viewvc/llvm-project?rev=288542&view=rev
> Log:
> Update test expectations after A
Author: kuba.brecka
Date: Fri Dec 2 16:11:26 2016
New Revision: 288542
URL: http://llvm.org/viewvc/llvm-project?rev=288542&view=rev
Log:
Update test expectations after AddressSanitizer text descriptions changed in
r288535.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalitie
This commit is causing tests to fail in Darwin:
TestReportData.AsanTestReportDataCase
TestMemoryHistory.AsanTestCase
http://lab.llvm.org:8080/green/job/lldb_build_test/22768/
http://lab.llvm.org:8080/green/job/lldb_build_test/22769/
FAIL: test_dwarf (TestReportData.AsanTestReportDataCase)
--
kubabrecka added a comment.
Thanks for reviewing this!
Repository:
rL LLVM
https://reviews.llvm.org/D27017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288535: Support more report types in
AddressSanitizerRuntime.cpp, re-word existing ones. (authored by kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D27017?vs=79611&id=80123#toc
Reposi
.Case("stack-use-after-return", "Use of returned stack memory")
Maybe "Use of stack memory after (function) return"? (i couldn't decide
whether to include "function". Either delete it or delete the parens.
This is a very minor nit, so I'm ok with keeping the current wording if you
prefer that.
kubabrecka added a comment.
In https://reviews.llvm.org/D27017#611894, @filcab wrote:
> LGTM
>
> (I commented on a minor nit. It might just be me, so feel free to keep the
> current wording if you feel it's preferred)
I'm not seeing this comment. Can you post it again?
https://reviews.llvm.
jasonmolenda added a comment.
@labath intersting idea, sending a blob of stack memory above the current stack
pointer reg value to accelerate an unwind. If you have a lot of small stack
frames, it could be a performance benefit. Common/simple methods do their work
in 32-64 bytes of stack spac
> On Dec 2, 2016, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits
> wrote:
>
> labath added a comment.
>
> In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote:
>
>> @labath ah I see I hadn't looked at the lldb-server packets so I didn't know
>> you had jThreadsInfo, good
filcab accepted this revision.
filcab added a comment.
LGTM
(I commented on a minor nit. It might just be me, so feel free to keep the
current wording if you feel it's preferred)
https://reviews.llvm.org/D27017
___
lldb-commits mailing list
lldb-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL288494: Replace __ANDROID_NDK__ with __ANDROID__ (authored
by labath).
Changed prior to commit:
https://reviews.llvm.org/D27305?vs=80047&id=80048#toc
Repository:
rL LLVM
https://reviews.llvm.org/D27
Author: labath
Date: Fri Dec 2 05:15:15 2016
New Revision: 288494
URL: http://llvm.org/viewvc/llvm-project?rev=288494&view=rev
Log:
Replace __ANDROID_NDK__ with __ANDROID__
Summary:
This replaces all the uses of the __ANDROID_NDK__ define with __ANDROID__. This
is a preparatory step to remove ou
labath updated this revision to Diff 80047.
labath added a comment.
A bit more cleanup.
https://reviews.llvm.org/D27305
Files:
cmake/platforms/Android.cmake
include/lldb/Core/RegularExpression.h
include/lldb/Host/Config.h
include/lldb/Host/Editline.h
include/lldb/Host/Host.h
include
labath updated this revision to Diff 80046.
labath added a comment.
Remove ifdef in driver.cpp -- it is completely unnecessary
https://reviews.llvm.org/D27305
Files:
cmake/platforms/Android.cmake
include/lldb/Core/RegularExpression.h
include/lldb/Host/Config.h
include/lldb/Host/Editline
labath added a comment.
I've tried to unify this slightly, but sometimes further unification would make
things inconsistent with surrounding preprocessor directives.
I was suprised by the presence of some of these ifdefs as well -- some of them
seem completely unnecessary. I think that at some
labath updated this revision to Diff 80043.
labath added a comment.
Update to use __ANDROID__
https://reviews.llvm.org/D27305
Files:
cmake/platforms/Android.cmake
include/lldb/Core/RegularExpression.h
include/lldb/Host/Config.h
include/lldb/Host/Editline.h
include/lldb/Host/Host.h
i
labath added a comment.
In https://reviews.llvm.org/D27289#611082, @jasonmolenda wrote:
> @labath ah I see I hadn't looked at the lldb-server packets so I didn't know
> you had jThreadsInfo, good to hear. Yes, if your target is built mostly
> -fomit-frame-pointer, lldb-server won't be able to
tberghammer added inline comments.
Comment at: include/lldb/Core/RegularExpression.h:34
#else
-#if __ANDROID_NDK__
+#if ANDROID
#include
In most case you use "#ifdef". It would be nice to uniformalize
Comment at: source/Plugins/Language/CPlu
19 matches
Mail list logo
