kubabrecka created this revision.
kubabrecka added reviewers: clayborg, jasonmolenda, jingham.
kubabrecka added subscribers: lldb-commits, zaks.anna.
kubabrecka set the repository for this revision to rL LLVM.
kubabrecka added a project: Sanitizers.
https://reviews.llvm.org/D27012 will add more re
labath updated this revision to Diff 78895.
labath added a comment.
A new version, which uses a helper class which enables all the implicit
conversions that one would normally expect from the duration classes.
Things left TBD:
- name
- where to put it
- whether inheriting from Optional is fine (
labath added a comment.
In https://reviews.llvm.org/D26971#602738, @clayborg wrote:
> It would be nice if we can find a way to be able to use any time units we
> want when specifying the timeout. I would rather not have everyone have to
> convert their times to microseconds. Maybe we just add s
labath added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:56
-response,
-
std::chrono::duration_cast(kInterruptTimeout)
-.count(),
zturner wrote:
> I think we should all be willing to agree tha
labath abandoned this revision.
labath added a comment.
This has been abandoned some time ago.
https://reviews.llvm.org/D23290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added a comment.
I suppose we could create a new class (I am not sure what a good name for that
would be... `OptionalDuration`, which inherits from `llvm:Optional`, but
provides the additional conversion operator to make things work seamlessly.
Something like:
template
class Optiona
zturner added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:56
-response,
-
std::chrono::duration_cast(kInterruptTimeout)
-.count(),
I think we should all be willing to agree that `using namespa
clayborg added a comment.
Is there anything we need to do on this review?
https://reviews.llvm.org/D24610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I am not sure this is the right fix. This fix would mean that any IOHandler
would always be interactive even if the user didn't want it to be. A better fix
would be to make a way
zturner added a comment.
In https://reviews.llvm.org/D26971#602738, @clayborg wrote:
> It would be nice if we can find a way to be able to use any time units we
> want when specifying the timeout. I would rather not have everyone have to
> convert their times to microseconds. Maybe we just add
Author: zturner
Date: Tue Nov 22 11:10:15 2016
New Revision: 287647
URL: http://llvm.org/viewvc/llvm-project?rev=287647&view=rev
Log:
Re-add "demonstrate new Args API"
This fixes the build breakage due to the use of C++14.
Modified:
lldb/trunk/include/lldb/Interpreter/Args.h
lldb/trunk/s
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We will need to take a look at the existing assert calls within LLDB and within
LLVM to make sure we won't cause things to crash at a later time with no
context as to what happen
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice if we can find a way to be able to use any time units we want
when specifying the timeout. I would rather not have everyone have to convert
their times to micros
labath created this revision.
labath added reviewers: zturner, beanz, tfiala.
labath added a subscriber: lldb-commits.
Herald added subscribers: mgorny, srhines, danalbert.
This basically just inlines the LLDBDependencies.cmake file into lldb-server
CMakeLists.txt. The reason is that most of these
labath created this revision.
labath added reviewers: clayborg, zturner, jingham.
labath added a subscriber: lldb-commits.
This replaces the usage of raw integers with duration classes in the gdb-remote
packet management functions. The values are still converted back to integers
once
they go into
- Original Message -
> From: "Omair Javaid via lldb-commits"
> To: lldb-commits@lists.llvm.org
> Sent: Tuesday, November 22, 2016 3:47:01 AM
> Subject: [Lldb-commits] [lldb] r287631 - Fix build failure on Linux and BSD
> by reverting r287597
>
> Author: omjavaid
> Date: Tue Nov 22 03:4
Author: sammccall
Date: Tue Nov 22 05:40:25 2016
New Revision: 287636
URL: http://llvm.org/viewvc/llvm-project?rev=287636&view=rev
Log:
Improve detection of global vs local variables
Summary:
Improve detection of global vs local variables.
Currently when a global variable is optimized out or oth
labath added a comment.
In https://reviews.llvm.org/D26883#601638, @jingham wrote:
> The outermost quote character is syntactically significant in the lldb
> command language. If you say:
>
> memory read -c `count_var` 0x123345
>
> then lldb evaluates the expression in the backticks, replacing
Proposed change didnt fix the build errors so I have reverted changes
from rev 287597
On 22 November 2016 at 14:18, Zachary Turner wrote:
> Ack, I caught this and fixed it, but it looks like I didn't dcommit the fix.
> I have no access until morning but if someone else does, you can either
> reve
Author: omjavaid
Date: Tue Nov 22 03:47:00 2016
New Revision: 287631
URL: http://llvm.org/viewvc/llvm-project?rev=287631&view=rev
Log:
Fix build failure on Linux and BSD by reverting r287597
Linux and BSD builds failing after this changes from rev 287597.
Modified:
lldb/trunk/include/lldb/I
Ack, I caught this and fixed it, but it looks like I didn't dcommit the
fix. I have no access until morning but if someone else does, you can
either revert or change return type to vector::const_iterator
On Tue, Nov 22, 2016 at 12:45 AM Omair Javaid
wrote:
Linux buildbot also failing with simil
Linux buildbot also failing with similar errors.
On 22 November 2016 at 09:26, Ed Maste via lldb-commits
wrote:
> On 21 November 2016 at 18:18, Zachary Turner via lldb-commits
> wrote:
>> Author: zturner
>> Date: Mon Nov 21 17:18:07 2016
>> New Revision: 287597
>>
>> URL: http://llvm.org/viewvc/
22 matches
Mail list logo
