[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Ilia K via lldb-commits
ki.stfu added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:676-677 # If not found, disable the lldb-mi tests -lldbMiExec = None -if lldbtest_config.lldbExec and is_exe(lldbtest_config.lldbExec + "-mi"): -lldbMiExec = lldbtest_config.l

[Lldb-commits] [lldb] r283969 - Add an arm64 unit test where the function saves x20 in the

2016-10-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 11 22:53:01 2016 New Revision: 283969 URL: http://llvm.org/viewvc/llvm-project?rev=283969&view=rev Log: Add an arm64 unit test where the function saves x20 in the prologue, then loads & stores x20 on the stack from a different location in the middle of the function,

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Vadim Macagon via lldb-commits
enlight added a comment. In https://reviews.llvm.org/D25486#567722, @zturner wrote: > Heh. It just occurred to me that this is probably the reason why all of the > `lldb-mi` tests fail on Windows. Because `.exe` is not appended. I'm not > ready to turn that on and deal with all the failures

[Lldb-commits] [lldb] r283966 - Add a simple frameless function test case to the arm64 unwind unit tests

2016-10-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 11 21:46:22 2016 New Revision: 283966 URL: http://llvm.org/viewvc/llvm-project?rev=283966&view=rev Log: Add a simple frameless function test case to the arm64 unwind unit tests with return statements in the body of the function. Modified: lldb/trunk/unittests/Un

[Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-11 Thread Jason Molenda via lldb-commits
Hi Tamas, I'm writing some unit tests for the unwind source generators - x86 last week, arm64 this week, and I noticed with this prologue: JavaScriptCore`JSC::B3::reduceDoubleToFloat: 0x192b45c0c <+0>: 0x6db923e9 stpd9, d8, [sp, #-0x70]! 0x192b45c10 <+4>: 0xa9016ffc stpx28,

[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-10-11 Thread Kamil Rytarowski via lldb-commits
krytarowski added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:414 + +find_package(Backtrace REQUIRED) tfiala wrote: > Hi Sylvestre! > > It's hard to tell without more context, but it looks like this location has > most/all configurations going t

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. Looks good! https://reviews.llvm.org/D25486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D23977: Support of lldb on Kfreebsd

2016-10-11 Thread Todd Fiala via lldb-commits
tfiala added inline comments. Comment at: cmake/modules/LLDBConfig.cmake:414 + +find_package(Backtrace REQUIRED) Hi Sylvestre! It's hard to tell without more context, but it looks like this location has most/all configurations going through it. For OSes that d

[Lldb-commits] [lldb] r283959 - This test now passes.

2016-10-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 11 19:05:36 2016 New Revision: 283959 URL: http://llvm.org/viewvc/llvm-project?rev=283959&view=rev Log: This test now passes. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-auto-import/TestModulesAutoImport.py Modified: lldb/trunk/packag

[Lldb-commits] [lldb] r283957 - This was skipped due to a clang PR that has been fixed.

2016-10-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 11 18:55:13 2016 New Revision: 283957 URL: http://llvm.org/viewvc/llvm-project?rev=283957&view=rev Log: This was skipped due to a clang PR that has been fixed. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-incomplete/TestIncompleteModules

[Lldb-commits] [lldb] r283956 - Added a radar on our end for this test's failure.

2016-10-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 11 18:30:38 2016 New Revision: 283956 URL: http://llvm.org/viewvc/llvm-project?rev=283956&view=rev Log: Added a radar on our end for this test's failure. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py Modified

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-11 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added inline comments. This revision is now accepted and ready to land. Comment at: test/CMakeLists.txt:12 +DEPENDS ${LLDB_TEST_DEPS} +USES_TERMINAL ) OMG. I've been looking for this magic for forever. Praise

[Lldb-commits] [PATCH] D25487: Fix building tests without system headers on Darwin

2016-10-11 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. If you wanted to get really fancy, you could actually locate the system include directory and set the default to that. But that's up to you, just an idea. https://reviews.llvm.org/D25487

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Zachary Turner via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Heh. It just occurred to me that this is probably the reason why all of the `lldb-mi` tests fail on Windows. Because `.exe` is not appended. I'm not ready to turn that on and deal with al

[Lldb-commits] [lldb] r283940 - Add the radar number on our end.

2016-10-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 11 16:08:27 2016 New Revision: 283940 URL: http://llvm.org/viewvc/llvm-project?rev=283940&view=rev Log: Add the radar number on our end. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py Modified: lldb/trunk/packages/

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Herald added a subscriber: mgorny. This patch adds the following fixes to the check-lldb targets: - Adds missing dependencies on lldb tools so they get built before tests execute - Adds Ni

[Lldb-commits] [PATCH] D25489: Use LLDB_SRC for relative paths

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Going from LLDB_SRC instead of the file path is safer when looking for compiler-rt. Also need to add support for looking inside the LLVM runtimes subdirectory. Eventually we should just

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. When running on Darwin, the test suite assumes a specific directory structure for the build directory. This works for the Xcode project builds, but fails for CMake builds regardless of wh

[Lldb-commits] [PATCH] D25487: Fix building tests without system headers on Darwin

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. Default installations of OS X do not have system headers installed at /usr/include. This patch allows the LLDB test executables to properly compile when built on a system without headers

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-11 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added reviewers: tfiala, zturner. beanz added a subscriber: lldb-commits. The test suite calls realpath on the lldb executable then append "-mi" to it to find the path of the lldb-mi executable. This does not work when using CMake builds on *nix platforms. On *

[Lldb-commits] [lldb] r283929 - This test now passes.

2016-10-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 11 15:09:40 2016 New Revision: 283929 URL: http://llvm.org/viewvc/llvm-project?rev=283929&view=rev Log: This test now passes. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/list/TestDataFormatterLibcx

[Lldb-commits] [lldb] r283923 - Added a bugreport tracking the failure to get float return values

2016-10-11 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Oct 11 14:29:25 2016 New Revision: 283923 URL: http://llvm.org/viewvc/llvm-project?rev=283923&view=rev Log: Added a bugreport tracking the failure to get float return values on i386. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/return-value/Te

[Lldb-commits] [lldb] r283904 - Clarified the explanation of expr --top-level.

2016-10-11 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Oct 11 11:57:21 2016 New Revision: 283904 URL: http://llvm.org/viewvc/llvm-project?rev=283904&view=rev Log: Clarified the explanation of expr --top-level. Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp Modified: lldb/trunk/source/Commands/CommandObj

Re: [Lldb-commits] [PATCH] D25179: [lldb] Improve identification of Linux core dumps. Fix for bug #30485.

2016-10-11 Thread Zachary Turner via lldb-commits
I must have forgotten to add a doxygen comment on it. Will do today On Tue, Oct 11, 2016 at 7:09 AM Richard Chamberlain via lldb-commits < lldb-commits@lists.llvm.org> wrote: > rnchamberlain added a comment. > > Thanks, that's nicer. I did have a look for a 'contains()' method, but it > has not ma

[Lldb-commits] [PATCH] D25179: [lldb] Improve identification of Linux core dumps. Fix for bug #30485.

2016-10-11 Thread Richard Chamberlain via lldb-commits
rnchamberlain added a comment. Thanks, that's nicer. I did have a look for a 'contains()' method, but it has not made it into the docs yet. http://llvm.org/docs/doxygen/html/classllvm_1_1StringRef.html https://reviews.llvm.org/D25179 ___ lldb-commi

[Lldb-commits] [PATCH] D25179: [lldb] Improve identification of Linux core dumps. Fix for bug #30485.

2016-10-11 Thread Richard Chamberlain via lldb-commits
rnchamberlain updated this revision to Diff 74248. rnchamberlain added a comment. Updating as suggested to use StringRef.contains() https://reviews.llvm.org/D25179 Files: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Index: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp =

[Lldb-commits] [lldb] r283870 - Fix Arm64InstEmulation tests for windows

2016-10-11 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Oct 11 06:05:34 2016 New Revision: 283870 URL: http://llvm.org/viewvc/llvm-project?rev=283870&view=rev Log: Fix Arm64InstEmulation tests for windows MSVC does not like the declaration of a terminate() function (I guess it looks too much like std::terminate()). While I'm t

[Lldb-commits] [PATCH] D24498: [LLDB][MIPS] Fix TestReturnValue failure for MIPS

2016-10-11 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283729: [LLDB][MIPS] Fix TestReturnValue failure for MIPS (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24498?vs=71131&id=74203#toc Repository: rL LLVM https://review

[Lldb-commits] [PATCH] D24549: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite loop

2016-10-11 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283732: [LLDB][MIPS] Skip some test case which were causing LLDB to go into infinite… (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24549?vs=71314&id=74204#toc Repositor

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for 32 bit big endian system

2016-10-11 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283728: [LLDB][MIPS] Fix register read/write for 32 bit big endian system (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24124?vs=72024&id=74202#toc Repository: rL LLVM