nitesh.jain added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1218
@@ +1217,3 @@
+response.Printf("eflags:%" PRIx32 ";", proc_arch.GetFlags());
+if (proc_triple.isArch64Bit()) {
+ if (proc_arch.IsMIPS()) {
--
Good suggestions, thanks. I'll fix those when I commit the 32-bit version of
the same test.
J
> On Sep 28, 2016, at 9:28 PM, Zachary Turner wrote:
>
>
>
> On Wed, Sep 28, 2016 at 9:10 PM Jason Molenda via lldb-commits
> wrote:
>
> + EXPECT_TRUE(regloc.GetOffset() == -8);
> This should b
On Wed, Sep 28, 2016 at 9:10 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> + EXPECT_TRUE(regloc.GetOffset() == -8);
>
This should be
EXPECT_EQ(-8, regloc.GetOffset());
That way if it fails, you'll get a handy error message that says:
Expected: -8
Actual: -7
If yo
Author: jmolenda
Date: Wed Sep 28 23:01:43 2016
New Revision: 282683
URL: http://llvm.org/viewvc/llvm-project?rev=282683&view=rev
Log:
Add a unit test for an x86_64 assembly inspection of
a large stack frame with lots of spilled registers.
While writing the i386 version of this test, it looks
li
On Wed, Sep 28, 2016 at 6:09 PM Jason Molenda via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> +#include "x86AssemblyInspectionEngine.h"
> +
> +#include "llvm-c/Disassembler.h"
> +
> +#include "lldb/Core/Address.h"
> +#include "lldb/Symbol/UnwindPlan.h"
> +#include "lldb/Target/RegisterC
On Wed, Sep 28, 2016 at 5:54 PM Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Wed Sep 28 19:45:33 2016
> New Revision: 282657
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282657&view=rev
> Log:
> Fixed TestObjCStructArgument/i386; expressions can
On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
>
> -
> +
> + static ConstString g___i_("__i_");
> +
>// this must be a ValueObject* because it is a child of the ValueObject
> we are
>// producing children for
>// it if were a Valu
Author: spyffe
Date: Wed Sep 28 19:45:33 2016
New Revision: 282657
URL: http://llvm.org/viewvc/llvm-project?rev=282657&view=rev
Log:
Fixed TestObjCStructArgument/i386; expressions can now call ObjC class methods.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
omjavaid created this revision.
omjavaid added a reviewer: labath.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: samparker, srhines, danalbert, tberghammer, rengolin,
aemerson.
On ARM Linux targets watchpoints are reported by PTrace before the instruction
causing watchpoi
Author: spyffe
Date: Wed Sep 28 19:16:37 2016
New Revision: 282653
URL: http://llvm.org/viewvc/llvm-project?rev=282653&view=rev
Log:
Introduced a null check to avoid a crash in a test on i386.
Modified:
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/source/Target/StackFrame.cpp
Hello everyone,
Below are some buildbot numbers for the last week of 9/18/2016 - 9/24/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL221467.
https://reviews.llvm.org/D6127
___
lldb-commits mailing list
lldb-commits@lists.l
Author: enrico
Date: Wed Sep 28 17:53:16 2016
New Revision: 282648
URL: http://llvm.org/viewvc/llvm-project?rev=282648&view=rev
Log:
Fix an issue where libc++ changed the type information we get for
std::map::iterator, rendering LLDB unable to display elements vended by an
iterator
Fixes
Mod
Author: gclayton
Date: Wed Sep 28 16:07:34 2016
New Revision: 282632
URL: http://llvm.org/viewvc/llvm-project?rev=282632&view=rev
Log:
Add the ability for the task port to change when a process execs.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
l
Yep, looks like r282565 fixed the llvm.org tests, but broke another bot.
r282566 fixed the other bot, but broke the llvm.org tests again.
http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20757/
On Wed, Sep 28, 2016 at 1:48 PM, Tim Hammerquist wrote:
> Looks like there was some work
Looks like there was some work to address this in r282565 here:
http://lab.llvm.org:8080/green/view/LLDB/job/lldb_build_test/20756/
However, the issue occurred again on the very next run.
On Wed, Sep 28, 2016 at 1:41 PM, Tim Hammerquist wrote:
> This change seems to have introduced a linker fa
Author: tfiala
Date: Wed Sep 28 15:39:50 2016
New Revision: 282628
URL: http://llvm.org/viewvc/llvm-project?rev=282628&view=rev
Log:
use assertEquals in TestSBTypeClassMembers
This change replaces the self.assertTrue() calls with
self.assertEquals() so that test failures get more context on failu
This change seems to have introduced a linker failure while building the
gtest suite:
Ld build/Release/lldb-gtest normal x86_64
cd "/Users/buildslave/jenkins/sharedspace/lldb@2/lldb"
export MACOSX_DEPLOYMENT_TARGET=10.9
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.x
Meinersbur requested changes to this revision.
Meinersbur added a comment.
The description of `LLVM_LINK_LLVM_DYLIB` reads:
> Link tools against the libllvm dynamic library
that is, its intend is what this patch would disable (for dynamic modules). I
assume that you would like lldb-server to w
Author: tfiala
Date: Wed Sep 28 11:43:47 2016
New Revision: 282605
URL: http://llvm.org/viewvc/llvm-project?rev=282605&view=rev
Log:
zorg Xcode python test suite target arch update
This changes the Xcode target used by the Green Dragon Xcode CI.
When calling xcodebuild with LLDB_PYTHON_TESTSUITE_
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We need to send each flag individually. See inlined comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1887
@@ -1885,1 +18
labath added a comment.
Looks good as far as I am concerned. Just a couple of nits here and there.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1887
@@ -1885,1 +1886,3 @@
++num_keys_decoded;
+} else if (name.equals("eflags"
nitesh.jain created this revision.
nitesh.jain added reviewers: clayborg, labath.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits.
nitesh.jain set the repository for this revision to rL LLVM.
In case of MIPS64, the pointer size depends on ELF abi. The MIPS64 currently
supp
labath added a comment.
In https://reviews.llvm.org/D24610#554587, @omjavaid wrote:
> Give this approach a rethink I dont see a lot of problems with this final
> implementation unless it fails on other architectures.
> We are already hacking our way to have these byte selection watchpoints
> w
24 matches
Mail list logo
