Author: zturner
Date: Fri Sep 16 21:34:40 2016
New Revision: 281804
URL: http://llvm.org/viewvc/llvm-project?rev=281804&view=rev
Log:
Fix boolean logic error in BreakpointID.
Modified:
lldb/trunk/source/Breakpoint/BreakpointID.cpp
Modified: lldb/trunk/source/Breakpoint/BreakpointID.cpp
URL:
Author: zturner
Date: Fri Sep 16 21:00:02 2016
New Revision: 281799
URL: http://llvm.org/viewvc/llvm-project?rev=281799&view=rev
Log:
Convert many functions to use StringRefs.
Where possible, remove the const char* version. To keep the
risk and impact here minimal, I've only done the simplest
fu
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: labath, zturner.
Eugene.Zelenko added a subscriber: lldb-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Looks like RegisterContextNetBSD_x86_64.cpp should use RegisterInfos_x86_64.h
as much as possible
I have been thinking about something similar. Ildb-mi specifically I have
serious concerns about because the code itself is a bit of an abomination.
It has its own entire test suite, which also doesn't work very well.
Using a tool like lldb mi is very similar in spirit to how llvm already
uses lit
I thought about this more overnight and I'm more convinced that lit and lldb-mi
make a great pair. lldb-mi is a programmatic text format that isn't subject to
the whims of command-line UI design over the years; well tests written in terms
of MI will be resilient and stable. lldb-mi MUCH more c
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Fri Sep 16 15:10:02 2016
New Revision: 281770
URL: http://llvm.org/viewvc/llvm-project?rev=281770&view=rev
Log:
Fix compiler warnings where two values weren't being initialized.
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_i386.h
Modified: lldb/tru
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281765: Set the correct triple when creating an ArchSpec for
Windows. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D24283?vs=71226&id=71686#toc
Repository:
rL LLVM
https:
Author: zturner
Date: Fri Sep 16 14:09:12 2016
New Revision: 281764
URL: http://llvm.org/viewvc/llvm-project?rev=281764&view=rev
Log:
Add unit tests for a few string conversion functions in Args.
Also provided a StringRef overload for these functions and have
the const char* overloads delegate to
Author: zturner
Date: Fri Sep 16 14:09:19 2016
New Revision: 281765
URL: http://llvm.org/viewvc/llvm-project?rev=281765&view=rev
Log:
Set the correct triple when creating an ArchSpec for Windows.
Patch by Walter Erquinigo
Differential Revision: https://reviews.llvm.org/D24283
Modified:
lldb/
zturner added a subscriber: zturner.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/multi_watchpoint_slots/main.c:23
@@ +22,3 @@
+{
+printf("About to write byteArray[%d] ...\n", i); // About to write
byteArray
+
What's up with
wallace added a comment.
I'm obliged, your grace
https://reviews.llvm.org/D24284
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner accepted this revision.
This revision is now accepted and ready to land.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:89
@@ +88,3 @@
+ if (!data_sp || !ObjectFilePECOFF::MagicBytesMatch(data_sp)) {
+return NULL;
+ }
s/NULL/nullpt
zturner added a comment.
Thanks for the reminder. Will do this today.
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
wallace added a comment.
ping
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
wallace added a comment.
ping
https://reviews.llvm.org/D24284
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
fjricci added a comment.
I do understand the complexity problem, and it was one of my concerns with this
as well. For my cases, the complexity here is significantly less than the
alternatives, but I also do understand if you don't think that's generally true.
It probably comes down to how often
fjricci updated this revision to Diff 71651.
fjricci added a comment.
Refactor re
https://reviews.llvm.org/D24629
Files:
packages/Python/lldbsuite/test/configuration.py
packages/Python/lldbsuite/test/dotest.py
packages/Python/lldbsuite/test/dotest_args.py
packages/Python/lldbsuite/test/
On Fri, Sep 16, 2016 at 4:36 AM Luke Drummond via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: ldrumm
> Date: Fri Sep 16 06:28:12 2016
> New Revision: 281717
>
> URL: http://llvm.org/viewvc/llvm-project?rev=281717&view=rev
> Log:
> [RenderScript] Support tracking and dumping reduct
omjavaid updated this revision to Diff 71633.
omjavaid added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
I have added a new test case that tests suggested scnario without changing any
previous test cases.
Also I have made sure we re validate all watchpoint installed on
Author: ldrumm
Date: Fri Sep 16 06:28:12 2016
New Revision: 281717
URL: http://llvm.org/viewvc/llvm-project?rev=281717&view=rev
Log:
[RenderScript] Support tracking and dumping reduction kernels
Initial implementation of support for tracking
[RenderScript
Reductions](https://developer.android.co
omjavaid added a comment.
comments inline.
Comment at:
packages/Python/lldbsuite/test/functionalities/watchpoint/watchpoint_size/TestWatchpointSizes.py:43
@@ -42,2 +42,3 @@
"""Test to selectively watch different bytes in a 8-byte array."""
-self.run_watchpoint_
labath added a comment.
I don't think this is a totally bad idea. In fact we already had something like
this (nobody used it though), before it was removed in
https://reviews.llvm.org/rL255040. If it goes in, we might start using it
actually -- e.g., currently we have watchpoint tests which fa
23 matches
Mail list logo
