[Lldb-commits] Buildbot numbers for the last week of 8/21/2016 - 8/27/2016

2016-09-01 Thread Galina Kistanova via lldb-commits
Hello everyone, Below are some buildbot numbers for the last week of 8/21/2016 - 8/27/2016. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

2016-09-01 Thread Pierson Lee via lldb-commits
pieandcakes updated this revision to Diff 70107. pieandcakes added a comment. Fixed bracket. Repository: rL LLVM https://reviews.llvm.org/D23026 Files: tools/lldb-mi/MICmdCmdBreak.cpp tools/lldb-mi/MICmnResources.cpp tools/lldb-mi/MICmnResources.h Index: tools/lldb-mi/MICmnResources.h

Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

2016-09-01 Thread Pierson Lee via lldb-commits
pieandcakes updated this revision to Diff 70088. pieandcakes added a comment. Added error message if location is not specified per reviewers comments. Repository: rL LLVM https://reviews.llvm.org/D23026 Files: tools/lldb-mi/MICmdCmdBreak.cpp tools/lldb-mi/MICmnResources.cpp tools/lldb-

[Lldb-commits] [lldb] r280395 - When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed

2016-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 1 13:31:40 2016 New Revision: 280395 URL: http://llvm.org/viewvc/llvm-project?rev=280395&view=rev Log: When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed Modified: lldb/trunk/source/Core/ValueObjectRegister.cpp Modified:

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Pavel Labath via lldb-commits
labath added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1844 @@ +1843,3 @@ + +uint64_t value; +value = reg_size == 4 ? *(uint32_t *)reg_bytes : *(uint64_t *)reg_bytes; nitesh.jain wrote: > labat

Re: [Lldb-commits] [lldb] r280344 - XFail TestMemoryFind on 32-bit architectures

2016-09-01 Thread Enrico Granata via lldb-commits
I am probably being a little dense right now, but I can't seem to find (const char*)0x1000 anywhere in the test case code... > On Sep 1, 2016, at 2:17 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Thu Sep 1 04:17:37 2016 > New Revision: 280344 > > URL: http://llvm.org

[Lldb-commits] [lldb] r280389 - Change the formula for tagged NSIndexPath data formatting

2016-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 1 13:09:01 2016 New Revision: 280389 URL: http://llvm.org/viewvc/llvm-project?rev=280389&view=rev Log: Change the formula for tagged NSIndexPath data formatting Fixes rdar://25192935 Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatt

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Greg Clayton via lldb-commits
clayborg requested changes to this revision. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:659-660 @@ -651,4 +658,4 @@ { -uint8_t *dst; +uint8_t *dst, byte_size; uint64_t *src; Please initialize the

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Greg Clayton via lldb-commits
clayborg added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:808 @@ -799,3 +807,3 @@ uint8_t *src, *dst; init nullptr please. https://reviews.llvm.org/D24124 _

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Nitesh Jain via lldb-commits
nitesh.jain added inline comments. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1844 @@ +1843,3 @@ + +uint64_t value; +value = reg_size == 4 ? *(uint32_t *)reg_bytes : *(uint64_t *)reg_bytes; labath wrote: > This

Re: [Lldb-commits] [PATCH] D24126: Make Scalar::GetValue more consistent

2016-09-01 Thread Zachary Turner via lldb-commits
Actually you're right, i read the test backwards and thought the string was the argument. I shouldn't do this 30 seconds after waking up :) On Thu, Sep 1, 2016 at 7:26 AM Pavel Labath wrote: > I don't think that even makes sense. :) > > Scalar class has constructors overrides for each of the prim

Re: [Lldb-commits] [PATCH] D24126: Make Scalar::GetValue more consistent

2016-09-01 Thread Pavel Labath via lldb-commits
I don't think that even makes sense. :) Scalar class has constructors overrides for each of the primitive types. I cannot construct it with a value which is larger than it will fit in the primitive type. I suppose I could try the boundary conditions like UINT32_MAX, but that's about it. Or I am m

Re: [Lldb-commits] [PATCH] D24126: Make Scalar::GetValue more consistent

2016-09-01 Thread Zachary Turner via lldb-commits
What about a case in the unit test where the value overflows the type? Would that be useful? On Thu, Sep 1, 2016 at 3:50 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > labath created this revision. > labath added reviewers: clayborg, granata.enrico. > labath added a subsc

Re: [Lldb-commits] [PATCH] D24078: [zorg] Move lldb-x86_64-ubuntu-14.04-cmake buildbot to the stable category

2016-09-01 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280362: [zorg] Move lldb-x86_64-ubuntu-14.04-cmake buildbot to the stable category (authored by labath). Changed prior to commit: https://reviews.llvm.org/D24078?vs=69853&id=69996#toc Repository: rL

Re: [Lldb-commits] [PATCH] D23545: Minidump parsing

2016-09-01 Thread Dimitar Vlahovski via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280356: Minidump parsing (authored by dvlahovski). Changed prior to commit: https://reviews.llvm.org/D23545?vs=69340&id=69988#toc Repository: rL LLVM https://reviews.llvm.org/D23545 Files: lldb/tr

[Lldb-commits] [lldb] r280356 - Minidump parsing

2016-09-01 Thread Dimitar Vlahovski via lldb-commits
Author: dvlahovski Date: Thu Sep 1 06:29:53 2016 New Revision: 280356 URL: http://llvm.org/viewvc/llvm-project?rev=280356&view=rev Log: Minidump parsing Summary: This is a Minidump parsing code. There are still some more structures/data streams that need to be added. The aim ot this is to be use

Re: [Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Pavel Labath via lldb-commits
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I don't think the patch can go in in this form. Also, you seem to be putting multiple unrelated changes in one patch. It would be much easier to review if you split that up into mult

Re: [Lldb-commits] [PATCH] D24122: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

2016-09-01 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great. Thanks. https://reviews.llvm.org/D24122 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [PATCH] D24126: Make Scalar::GetValue more consistent

2016-09-01 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, granata.enrico. labath added a subscriber: lldb-commits. It seems the original intention of the function was printing signed values in decimal format, and unsigned values in hex (without the leading "0x"). However, signed and unsigne

[Lldb-commits] [PATCH] D24124: [LLDB][MIPS] Fix register read/write for big endian

2016-09-01 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. Herald added a subscriber: sdardis. The RegisterValue.SetBytes for 4 byte data followed by GetAsUInt64 for 32 bit big endian system will produ

[Lldb-commits] [PATCH] D24122: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS

2016-09-01 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, labath. nitesh.jain added subscribers: jaydeep, bhushan, slthakur, lldb-commits. This patch will fix TestEhFrameUnwind.py failure for MIPS https://reviews.llvm.org/D24122 Files: packages/Python/lldbsuite/test/functionali

[Lldb-commits] [lldb] r280344 - XFail TestMemoryFind on 32-bit architectures

2016-09-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Sep 1 04:17:37 2016 New Revision: 280344 URL: http://llvm.org/viewvc/llvm-project?rev=280344&view=rev Log: XFail TestMemoryFind on 32-bit architectures the test fails for a very prosaic reason: `(const char *)0x1000` returns "4096" on x86_64 and "1000" (without the "0x"