wttsugrii created this revision.
wttsugrii added a reviewer: jingham.
wttsugrii added a subscriber: lldb-commits.
frame_zero_id local variable is not used and can be safely removed.
https://reviews.llvm.org/D23952
Files:
source/Target/ThreadPlanStepOut.cpp
Index: source/Target/ThreadPlanStepO
wttsugrii created this revision.
wttsugrii added a reviewer: granata.enrico.
wttsugrii added a subscriber: lldb-commits.
any_found variable is not used anywhere and can be safely removed.
https://reviews.llvm.org/D23951
Files:
source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRunti
wttsugrii created this revision.
wttsugrii added a reviewer: granata.enrico.
wttsugrii added a subscriber: lldb-commits.
type variable is not used and can be safely removed.
https://reviews.llvm.org/D23950
Files:
source/DataFormatters/TypeCategoryMap.cpp
Index: source/DataFormatters/TypeCateg
wttsugrii created this revision.
wttsugrii added a reviewer: hhellyer.
wttsugrii added a subscriber: lldb-commits.
range_base variable is not used anywhere, so can be
safely removed.
https://reviews.llvm.org/D23948
Files:
source/Target/Process.cpp
Index: source/Target/Process.cpp
Author: jingham
Date: Fri Aug 26 19:35:48 2016
New Revision: 279897
URL: http://llvm.org/viewvc/llvm-project?rev=279897&view=rev
Log:
This test now succeeds.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/ma
Author: spyffe
Date: Fri Aug 26 19:35:37 2016
New Revision: 279896
URL: http://llvm.org/viewvc/llvm-project?rev=279896&view=rev
Log:
Fixed the location of a conditional to make the following code clearer.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Mo
Author: spyffe
Date: Fri Aug 26 19:20:38 2016
New Revision: 279894
URL: http://llvm.org/viewvc/llvm-project?rev=279894&view=rev
Log:
The error stream in IRForTarget is never null, so use it instead of the log.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cp
Author: spyffe
Date: Fri Aug 26 18:48:03 2016
New Revision: 279884
URL: http://llvm.org/viewvc/llvm-project?rev=279884&view=rev
Log:
Fixed a bad lldbassert() condition.
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp
Modified:
lldb/trunk/source/Plugins/E
k8stone accepted this revision.
k8stone added a reviewer: k8stone.
k8stone added a comment.
All changes long since accepted and submitted to trunk.
https://reviews.llvm.org/D22286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
Hello everyone,
LLVM buildmaster will be restarted after 6 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: spyffe
Date: Fri Aug 26 13:12:39 2016
New Revision: 279850
URL: http://llvm.org/viewvc/llvm-project?rev=279850&view=rev
Log:
Don't crash when trying to capture persistent variables in a block.
Reports an error instead. We can fix this later to make persistent variables
work, but right no
tfiala added a comment.
In https://reviews.llvm.org/D23884#526419, @tfiala wrote:
> > Again, if we switch the parser over to use an llvm::StringRef then this
> > make sense, otherwise it doesn't.
>
>
> I don't want to conflate this change with switching the parser over to a
> string ref. The o
amccarth added a comment.
LGTM.
https://reviews.llvm.org/D23545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added inline comments.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:113
@@ -105,4 +112,3 @@
case 'J':
-// Asynchronous JSON packet, destined for a
-// StructuredDataPlugin.
{
+
tfiala added a comment.
> Again, if we switch the parser over to use an llvm::StringRef then this make
> sense, otherwise it doesn't.
I don't want to conflate this change with switching the parser over to a string
ref. The only reason I changed the entry to a const char* was to avoid
creatin
zturner added a comment.
You mention a `StringRefExtractor`. But nothing about `StringExtractor` that I
can tell depends on the fact that it's null terminated. It only needs to know
where to stop. A `StringRef` contains a length, so you stop when it gets to
the end of the `StringRef`. It se
clayborg added a comment.
In https://reviews.llvm.org/D23884#526390, @zturner wrote:
> Actually it looks like `JSONParser` constructor takes a `StringRef` and then
> converts it to a `std::string` internally. Why can't it just store the
> `StringRef` internally? It doesn't modify the buffer,
> Greg's going to change over the parser now to StringRef. I'll adjust my
patch once he does that.
Sorry, that comment was incorrect and I removed from the website about
30-ish minutes ago. I'm not sure why it just popped up now. Disregard.
On Fri, Aug 26, 2016 at 8:54 AM, Todd Fiala wrote:
clayborg added a comment.
In https://reviews.llvm.org/D23884#526385, @zturner wrote:
> I'm not sure I follow. `StringRef` is literally just a wrapper around a
> `const char*`, so if `const char*` works, why doesn't `StringRef`?
"const char *" assumed null termination. StringRef can be a refer
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Actually after looking at the JSON parser I see that it isn't using
llvm::StringRef throughout. So I vote to keep the "const char *" for now since
we need to guarantee that the JSON is nul
tfiala added a comment.
Greg's going to change over the parser now to StringRef. I'll adjust my patch
once he does that.
https://reviews.llvm.org/D23884
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We should probably move over to using llvm::StrringRef instead of "const char
*". It the JSON parser isn't using llvm::StringRef already it probably should.
https://reviews.llvm
zturner added a comment.
Actually it looks like `JSONParser` constructor takes a `StringRef` and then
converts it to a `std::string` internally. Why can't it just store the
`StringRef` internally? It doesn't modify the buffer, and incidentally it also
keeps a `uint64_t` representing the "offs
zturner added a subscriber: zturner.
zturner added a comment.
I'm not sure I follow. `StringRef` is literally just a wrapper around a `const
char*`, so if `const char*` works, why doesn't `StringRef`? `JSONParser`
constructor is already taking a `const char*` in this patch, so it's not like
i
clayborg added a comment.
Looking closer at the JSON parser llvm::StringRef isn't the right thing to use
when parsing JSON. The parser will often remove desensitizing characters from
say a string like:
"hello \"world\""
And when parsing a token in JSONParser::GetToken, we can't just hand out
Unless we have a good reason to use const char* such as interoperability
with a C api I would strongly prefer we standardize on llvm::StringRef
On Fri, Aug 26, 2016 at 2:24 AM Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> labath added a comment.
>
> Thank you for writing th
zturner accepted this revision.
zturner added a reviewer: zturner.
This revision is now accepted and ready to land.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:60
@@ +59,3 @@
+MinidumpParser parser(data_buf_sp, header, directory_map);
+return llvm::Optio
dvlahovski updated this revision to Diff 69340.
dvlahovski added a comment.
Making MinidumpParser constuctor private
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Pr
labath added a comment.
Looks fine to me. Adrian, Zachary, any more thoughts here?
Comment at: source/Plugins/Process/minidump/MinidumpParser.h:42
@@ +41,3 @@
+public:
+explicit MinidumpParser(const lldb::DataBufferSP &data_buf_sp, const
MinidumpHeader *header,
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279812: Switch linux and android CODE_OWNERS (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D23877?vs=69249&id=69335#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23877
Author: labath
Date: Fri Aug 26 05:06:13 2016
New Revision: 279812
URL: http://llvm.org/viewvc/llvm-project?rev=279812&view=rev
Log:
Switch linux and android CODE_OWNERS
Summary:
Oleksiy is no longer active in LLDB, I'd like to formally assume ownership of
the linux and
android parts.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL279808: Add cmake option to choose whether to use the
builtin demangler (authored by labath).
Changed prior to commit:
https://reviews.llvm.org/D23830?vs=69093&id=69333#toc
Repository:
rL LLVM
https
Author: labath
Date: Fri Aug 26 04:47:58 2016
New Revision: 279808
URL: http://llvm.org/viewvc/llvm-project?rev=279808&view=rev
Log:
Add cmake option to choose whether to use the builtin demangler
Summary:
Previously the builting demangler was on for platforms that explicitly set a
flag by modif
labath added a subscriber: labath.
labath added reviewers: ki.stfu, abidh.
labath added a comment.
Woohoo. I am glad that this is finally getting fixed.
https://reviews.llvm.org/D23882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
labath added a comment.
Thank you for writing the tests. I have two stylistic comments, but otherwise
looks great.
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:113
@@ -105,4 +112,3 @@
case 'J':
-// Asynchronous JSON packet,
35 matches
Mail list logo
