Re: [Lldb-commits] [PATCH] D23604: gdb-remote: Centralize thread specific packet handling

2016-08-17 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D23604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

2016-08-17 Thread Muhammad Omair Javaid via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278947: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D20386?vs=68339&id=68374#toc Repository: rL

[Lldb-commits] [lldb] r278947 - Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

2016-08-17 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Wed Aug 17 11:45:34 2016 New Revision: 278947 URL: http://llvm.org/viewvc/llvm-project?rev=278947&view=rev Log: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY Differential revision: https://reviews.llvm.org/D20386 Modified: lldb/trunk/package

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

2016-08-17 Thread Adrian Prantl via lldb-commits
aprantl abandoned this revision. aprantl added a comment. I'm abandon this review so tfiala can claim it. https://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

2016-08-17 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I have updated the buildbots to appropriately set these variables. Hopefully we will have a smooth transition. Thanks for your patience. https://reviews.llvm.org/D20386 __

[Lldb-commits] [PATCH] D23608: Fix parsing of complicated C++ names

2016-08-17 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. CPlusPlusLanguage::MethodName was not correctly parsing templated functions whose demangled name included the return type -- the space before the function name was included in the "context"

Re: [Lldb-commits] [PATCH] D20386: Correct makefile.rules to use arm/aarch64 target specific AR and OBJCOPY

2016-08-17 Thread Muhammad Omair Javaid via lldb-commits
omjavaid updated this revision to Diff 68339. omjavaid added a comment. so I have used ?= now with following new changes OBJCOPY ?= $(call replace_cc_with,objcopy) ARCHIVER ?= $(call replace_cc_with,ar) override AR = $(ARCHIVER) https://reviews.llvm.org/D20386 Files: packages/Python/ll

[Lldb-commits] [lldb] r278925 - Fix unittests on windows after r278915

2016-08-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 17 07:00:19 2016 New Revision: 278925 URL: http://llvm.org/viewvc/llvm-project?rev=278925&view=rev Log: Fix unittests on windows after r278915 Apparently clang will happily capture a const variable in a lambda without it being specified in the capture clause. MSVC do

Re: [Lldb-commits] [PATCH] D23554: Remove cmake legacy code

2016-08-17 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278924: Remove cmake legacy code (authored by labath). Changed prior to commit: https://reviews.llvm.org/D23554?vs=68172&id=68338#toc Repository: rL LLVM https://reviews.llvm.org/D23554 Files: lld

[Lldb-commits] [lldb] r278924 - Remove cmake legacy code

2016-08-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 17 06:55:50 2016 New Revision: 278924 URL: http://llvm.org/viewvc/llvm-project?rev=278924&view=rev Log: Remove cmake legacy code Summary: Cmake 2.8 support is gone and not coming back. We can remove a bit of legacy code now. Reviewers: zturner Subscribers: lldb-com

[Lldb-commits] [PATCH] D23604: gdb-remote: Centralize thread specific packet handling

2016-08-17 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Before this, each function had a copy of the code which handled appending of the thread suffix to the packet (or using $Hg instead). I have moved that code into a single function and made ev

[Lldb-commits] [lldb] r278918 - Fix unittest compilation error in r278915

2016-08-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 17 04:17:08 2016 New Revision: 278918 URL: http://llvm.org/viewvc/llvm-project?rev=278918&view=rev Log: Fix unittest compilation error in r278915 Modified: lldb/trunk/unittests/Process/gdb-remote/GDBRemoteTestUtils.cpp lldb/trunk/unittests/Process/gdb-remote/G

[Lldb-commits] [lldb] r278916 - Remove manual packet construction from GDBRemoteRegisterContext::SetPrimordialRegister

2016-08-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 17 04:12:21 2016 New Revision: 278916 URL: http://llvm.org/viewvc/llvm-project?rev=278916&view=rev Log: Remove manual packet construction from GDBRemoteRegisterContext::SetPrimordialRegister Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegister

[Lldb-commits] [lldb] r278915 - Move packet construction from GDBRemoteRegisterContext go the communication class

2016-08-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Aug 17 03:53:31 2016 New Revision: 278915 URL: http://llvm.org/viewvc/llvm-project?rev=278915&view=rev Log: Move packet construction from GDBRemoteRegisterContext go the communication class Summary: When saving/restoring registers the GDBRemoteRegisterContext class was m

Re: [Lldb-commits] [PATCH] D23553: Move packet construction from GDBRemoteRegisterContext go the communication class

2016-08-17 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL278915: Move packet construction from GDBRemoteRegisterContext go the communication… (authored by labath). Changed prior to commit: https://reviews.llvm.org/D23553?vs=68171&id=68323#toc Repository: r