Author: jmolenda
Date: Fri Jul 29 01:24:03 2016
New Revision: 277123
URL: http://llvm.org/viewvc/llvm-project?rev=277123&view=rev
Log:
PlatformDarwinKernel maintains a list of kexts and kernels
that it finds on the local computer in "well known" locations
when we start up the darwin-kernel platfor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277117: Fix -break-insert not working when using absolute
paths (MI) (authored by ki.stfu).
Changed prior to commit:
https://reviews.llvm.org/D22902?vs=66055&id=66079#toc
Repository:
rL LLVM
https:/
Author: ki.stfu
Date: Fri Jul 29 01:01:20 2016
New Revision: 277117
URL: http://llvm.org/viewvc/llvm-project?rev=277117&view=rev
Log:
Fix -break-insert not working when using absolute paths (MI)
Summary:
When trying to parse the -break-insert arguments as a named location, the
string parsing was
ki.stfu accepted this revision.
ki.stfu added a comment.
No. I'm going to land it right now! Thanks!
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
malaperle added a comment.
Thanks! Newcomer silly question: now that the change is accepted, is there any
action required on my end?
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
compnerd closed this revision.
compnerd added a comment.
SVN r277011
https://reviews.llvm.org/D20436
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
There should be a way to specify the lldb-mi binary. If there isn't feel free
to add one to the test suite.
https://reviews.llvm.org/D22902
Author: jmolenda
Date: Thu Jul 28 19:18:39 2016
New Revision: 277088
URL: http://llvm.org/viewvc/llvm-project?rev=277088&view=rev
Log:
Move the code which knows how to get information about the shared
cache from ObjectFileMachO (very wrong place) to the DynamicLoader
plugins (better place). Not m
malaperle added a comment.
In https://reviews.llvm.org/D22902#500174, @malaperle wrote:
> This failed for me because lldb is a symlink to lldb-4.0.0 and lldb-4.0.0-mi
> doesn't exist. I'm not sure if there either a way to not make it resolve the
> symlink or if the script should be changed.
B
malaperle added a comment.
BTW, I had trouble running the lldb-mi tests. There seems to be a bug in
dotest.py.
lldbMiExec = lldbtest_config.lldbExec + "-mi"
I used 'python dotest.py --executable /path/to/llvm/build/bin/lldb
This failed for me because lldb is a symlink to lldb-4.0.0 and lldb-
malaperle updated this revision to Diff 66055.
malaperle added a comment.
The test actually already existed but now it passed.
https://reviews.llvm.org/D22902
Files:
packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py
tools/lldb-mi/MICmdArgValString.cpp
tools/lldb-mi/MI
Author: jmolenda
Date: Thu Jul 28 17:43:10 2016
New Revision: 277065
URL: http://llvm.org/viewvc/llvm-project?rev=277065&view=rev
Log:
Small refinement on the memory segment support in core files that
Greg added in r272276 -- when working with a non-user-process mach-o
core file, force the permiss
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277060: Remove a duplicated block in cmake. (authored by
sas).
Changed prior to commit:
https://reviews.llvm.org/D22891?vs=65839&id=66038#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22891
Fil
Author: sas
Date: Thu Jul 28 17:11:54 2016
New Revision: 277060
URL: http://llvm.org/viewvc/llvm-project?rev=277060&view=rev
Log:
Remove a duplicated block in cmake.
Summary:
This is supposed to find the python lib dir and seems like it's just
been copied twice by mistake.
Reviewers: tfiala
Sub
tfiala added a comment.
> Ah! I see the email. Thanks for the clarification.
>
> Best
>
> Luke
Sure thing :-) Sorry for the confusion.
Repository:
rL LLVM
https://reviews.llvm.org/D18059
___
lldb-commits mailing list
lldb-commits@lists.l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277016: Cleanup some format string warnings (authored by
ldrumm).
Changed prior to commit:
https://reviews.llvm.org/D22923?vs=65941&id=65960#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22923
Author: ldrumm
Date: Thu Jul 28 13:19:33 2016
New Revision: 277016
URL: http://llvm.org/viewvc/llvm-project?rev=277016&view=rev
Log:
Cleanup some format string warnings
Clean up format string warnings in ValueObjectSyntheticFilter.cpp to explictly
cast "%p" params to void *`
Subscribers: lldb-c
Author: compnerd
Date: Thu Jul 28 13:16:07 2016
New Revision: 277013
URL: http://llvm.org/viewvc/llvm-project?rev=277013&view=rev
Log:
Host: correct use of std::condition_variable::wait_for
std::condition::wait_for takes a std::unique_lock. The previous commit
accidentally left a reference to `m
ldrumm added a comment.
In https://reviews.llvm.org/D18059#499525, @tfiala wrote:
> In https://reviews.llvm.org/D18059#499522, @ldrumm wrote:
>
> > In https://reviews.llvm.org/D18059#499521, @tfiala wrote:
> >
> > > I've got a fix to make this work in Xcode, but I'm currently stuck behind
> > >
tfiala added a comment.
In https://reviews.llvm.org/D18059#499522, @ldrumm wrote:
> In https://reviews.llvm.org/D18059#499521, @tfiala wrote:
>
> > I've got a fix to make this work in Xcode, but I'm currently stuck behind
> > the missing Condition.cpp from r277011 to verify.
>
>
> Thanks Todd. I
ldrumm added a comment.
In https://reviews.llvm.org/D18059#499521, @tfiala wrote:
> I've got a fix to make this work in Xcode, but I'm currently stuck behind the
> missing Condition.cpp from r277011 to verify.
Thanks Todd. I don't really deal with XCode, so that's a real help.
Regarding r2770
> Also, fixed up typos in RenderScript code that could
not possibly compile.
Typo in that, it was MacOSX-Kernel *.KDP that had typos, not RenderScript.
Pardon!
On Thu, Jul 28, 2016 at 10:56 AM, Todd Fiala via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: tfiala
> Date: Thu Jul 28
Author: tfiala
Date: Thu Jul 28 12:56:26 2016
New Revision: 277012
URL: http://llvm.org/viewvc/llvm-project?rev=277012&view=rev
Log:
Fixed up Xcode build for r276976 and r277011.
Also, fixed up typos in RenderScript code that could
not possibly compile.
Modified:
lldb/trunk/lldb.xcodeproj/pr
tfiala added a subscriber: tfiala.
tfiala added a comment.
I've got a fix to make this work in Xcode, but I'm currently stuck behind the
missing Condition.cpp from r277011 to verify.
Repository:
rL LLVM
https://reviews.llvm.org/D18059
___
lldb-c
clayborg added a comment.
A few things that worry me:
- There are no sequence IDs on any packets so when receiving responses, I am
not sure how you are going to match up packets with their responses especially
when you are sending from multiple threads. I didn't look through your
implementatio
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for all of the updates.
https://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
dvlahovski updated this revision to Diff 65957.
dvlahovski added a comment.
Checking for null pointer, in case of a corrupt core file
https://reviews.llvm.org/D22917
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py
source/Plugins/ObjectFile/ELF/O
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
Comment at: source/API/SBCommandInterpreter.cpp:156
@@ -155,3 +155,3 @@
}
-lldb::SBCommandPluginInterface* m_backend;
+std::shared_ptr m_backend;
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I am fine with the llvm::StringRef until it causes a crash. So really look at
all the ways you construct a llvm::StringRef and make sure it won't assert ever
if you leave it as a llvm::Str
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Add a test and this is good to go.
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
ldrumm created this revision.
ldrumm added reviewers: clayborg, granata.enrico.
ldrumm added a subscriber: lldb-commits.
ldrumm added a project: LLDB.
clean up format string warnings in `ValueObjectSyntheticFilter.cpp` to
explictly cast `"%p" params to `void *`
https://reviews.llvm.org/D22923
F
labath added a comment.
Looks great, thanks.
Please just fix the null pointer issue and we are good to go.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1506
@@ -1502,2 +1505,3 @@
{
llvm::StringRef path(data.GetCStr(&offset));
dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added a subscriber: lldb-commits.
There were places in the code, assuming(hardcoding) offsets
and types that were only valid for the x86_64 elf core file format.
The NT_PRSTATUS and NT_PRPSINFO structures are with t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276976: Add IR fixups for RenderScript ABI mismatch between
ARMV7 frontend and x86… (authored by ldrumm).
Changed prior to commit:
https://reviews.llvm.org/D18059?vs=65927&id=65929#toc
Repository:
rL
Author: ldrumm
Date: Thu Jul 28 09:21:07 2016
New Revision: 276976
URL: http://llvm.org/viewvc/llvm-project?rev=276976&view=rev
Log:
Add IR fixups for RenderScript ABI mismatch between ARMV7 frontend and x86
backend
Expression evaluation for function calls to certain public RenderScript
API func
ldrumm updated this revision to Diff 65927.
Herald added a subscriber: samparker.
https://reviews.llvm.org/D18059
Files:
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/CMakeLists.txt
source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptExpressionOpts.c
nitesh.jain marked 9 inline comments as done.
nitesh.jain added a comment.
https://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
This change adds the ability to the client to send multiple packets without
waiting for the
response to the first one. The individual senders
abhishek.aggarwal updated this revision to Diff 65903.
abhishek.aggarwal added a comment.
New patch according to review feedback
- Added another variant of AddCommand API with syntax as an additional argument
https://reviews.llvm.org/D22863
Files:
include/lldb/API/SBCommandInterpreter.h
so
labath added inline comments.
Comment at: source/API/SBCommandInterpreter.cpp:156
@@ -155,3 +155,3 @@
}
-lldb::SBCommandPluginInterface* m_backend;
+std::shared_ptr m_backend;
};
abhishek.aggarwal wrote:
> clayborg wrote:
> > Can't change public API,
abhishek.aggarwal added inline comments.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandPluginInterface *impl, const
char* help);
+AddCommand (const char* name, lldb:
labath added a comment.
In https://reviews.llvm.org/D22629#498135, @clayborg wrote:
> I have some reservations about your future changes to add concurrent packets.
> We should discuss this at length before you try to make any changes on the
> mailing list.
Agreed. I have a follow-up almost re
labath updated this revision to Diff 65895.
labath marked 2 inline comments as done.
labath updated the summary for this revision.
labath added a comment.
Address review comments.
https://reviews.llvm.org/D22629
Files:
source/Plugins/Process/gdb-remote/CMakeLists.txt
source/Plugins/Process/
labath added a subscriber: labath.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandPluginInterface *impl, const
char* help);
+AddCommand (const char* name, lldb::SBCom
abhishek.aggarwal added a comment.
Hi Greg
Please find my comments inlined. Let me know if I am missing something here.
Comment at: include/lldb/API/SBCommandInterpreter.h:141-142
@@ -140,4 +140,4 @@
lldb::SBCommand
-AddCommand (const char* name, lldb::SBCommandP
On 27 July 2016 at 23:39, Jim Ingham wrote:
>
> Yes, I see.
>
> This change always checks public state running, so all the flips from run to
> stopped in the private state thread will have no effect on all the modes of
> running except expression evaluation.
>
> The change as is is better than w
47 matches
Mail list logo
