Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Renato Golin via lldb-commits
rengolin added a comment. You will not be required to use submodules at all, as we'll all use the individual projects, like we have always been. I don't understand why people keep going back to it. Having a single repository was part of the original proposal for years, and every time it was sh

[Lldb-commits] [lldb] r276079 - Add a default-value bool flag pretty_print to the StructuredData Dump methods.

2016-07-19 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jul 19 22:49:02 2016 New Revision: 276079 URL: http://llvm.org/viewvc/llvm-project?rev=276079&view=rev Log: Add a default-value bool flag pretty_print to the StructuredData Dump methods. They will dump pretty-print (indentation, extra whitepsace) by default. I'll make

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Justin Lebar via lldb-commits
jlebar added a comment. FYI after talking to Chandler, I'm going to write up a separate proposal for the one-repository thing and send it to the list tomorrow. The suggestion was that this phabricator thread isn't the right place to have this discussion. https://reviews.llvm.org/D22463 ___

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Justin Lebar via lldb-commits
jlebar added a subscriber: jlebar. jlebar added a comment. I'm sure you all have thought about this more than I have, and I apologize if this has been brought up before because I haven't been following the thread closely. But I am not convinced by this document that using subrepositories beats

[Lldb-commits] [lldb] r276065 - s/Cocoa/Foundation/

2016-07-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 19 18:58:23 2016 New Revision: 276065 URL: http://llvm.org/viewvc/llvm-project?rev=276065&view=rev Log: s/Cocoa/Foundation/ Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py lldb/t

[Lldb-commits] [lldb] r276061 - Fix an issue where the libc++ std::list formatter wasn't recognizing the new memory layout correctly

2016-07-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 19 18:50:31 2016 New Revision: 276061 URL: http://llvm.org/viewvc/llvm-project?rev=276061&view=rev Log: Fix an issue where the libc++ std::list formatter wasn't recognizing the new memory layout correctly rdar://problem/26999542 Modified: lldb/trunk/source/Plug

[Lldb-commits] [lldb] r276033 - Don't check the value of the unset variables on iOS

2016-07-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 19 16:50:39 2016 New Revision: 276033 URL: http://llvm.org/viewvc/llvm-project?rev=276033&view=rev Log: Don't check the value of the unset variables on iOS Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/boolreference/TestForma

[Lldb-commits] [lldb] r275983 - Typo corrections identified by codespell

2016-07-19 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Jul 19 10:28:02 2016 New Revision: 275983 URL: http://llvm.org/viewvc/llvm-project?rev=275983&view=rev Log: Typo corrections identified by codespell Submitted by giffu...@yahoo.com; I fixed a couple of nearby errors and incorrect changes in the patch. llvm.org/pr27634 M

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Jonathan Roelofs via lldb-commits
On 7/19/16 8:55 AM, Robinson, Paul wrote: I think we could emulate any pre-commit hook we like via GitHub WebHooks by having two repositories: llvm and llvm-staging (say). People push to llvm-staging, which notifies some LLVM server we own. That does basic sanity checks and pushes to llvm prop

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Robinson, Paul via lldb-commits
> > I think we could emulate any pre-commit hook we like via GitHub > > WebHooks by having two repositories: llvm and llvm-staging (say). > > > > People push to llvm-staging, which notifies some LLVM server we own. > > That does basic sanity checks and pushes to llvm proper if passed. > > I think

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-19 Thread Ed Maste via lldb-commits
emaste added a comment. With this patch, test results on FreeBSD are consistent. https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-19 Thread Ed Maste via lldb-commits
emaste added a subscriber: emaste. emaste added a comment. I'm testing on FreeBSD now https://reviews.llvm.org/D20436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22132: Support for OCaml native debugging

2016-07-19 Thread Elias Boutaleb via lldb-commits
ebtaleb updated the summary for this revision. ebtaleb removed a reviewer: tberghammer. ebtaleb updated this revision to Diff 64473. https://reviews.llvm.org/D22132 Files: cmake/LLDBDependencies.cmake include/lldb/Symbol/OCamlASTContext.h include/lldb/Symbol/TypeSystem.h source/API/System

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Renato Golin via lldb-commits
rengolin updated this revision to Diff 64469. https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index: docs/Proposals/GitHub.rst === --- /dev/null +++ docs/Proposals/GitHub.rst @@ -0,0 +1,254 @@ +===

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Renato Golin via lldb-commits
rengolin updated this revision to Diff 64468. rengolin added a comment. Formatting issues (bullet points) https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index: docs/Proposals/GitHub.rst === --- /dev/null +++ do

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Renato Golin via lldb-commits
rengolin updated this revision to Diff 64467. rengolin added a comment. More updates, following recent comments. https://reviews.llvm.org/D22463 Files: docs/Proposals/GitHub.rst Index: docs/Proposals/GitHub.rst === --- /dev/null

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Renato Golin via lldb-commits
rengolin added inline comments. Comment at: docs/Proposals/GitHub.rst:68 @@ +67,3 @@ + * Collaborate with peers directly, even without access to the Internet + * Have multiple trees without multiplying disk space, multiple concurrent builds + vsk wrote: > What do

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Filipe Cabecinhas via lldb-commits
filcab added a comment. Thanks a lot for working on this! Filipe https://reviews.llvm.org/D22463 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D20436: Clean up vestigial remnants of locking primitives

2016-07-19 Thread Zachary Turner via lldb-commits
I can't test this on Windows until Friday because I'm traveling and my laptop isn't set up to build lldb. Could Stephane maybe help? On Tue, Jul 19, 2016 at 1:51 AM Saleem Abdulrasool wrote: > compnerd updated this revision to Diff 64448. > > https://reviews.llvm.org/D20436 > > Files: > inclu