[Lldb-commits] [lldb] r272087 - Revive the error message from "process load" and SBProcess::LoadImage.

2016-06-07 Thread Jim Ingham via lldb-commits
Author: jingham Date: Tue Jun 7 20:29:21 2016 New Revision: 272087 URL: http://llvm.org/viewvc/llvm-project?rev=272087&view=rev Log: Revive the error message from "process load" and SBProcess::LoadImage. IsPointedCString has problems with ValueObjects of type eTypeHostAddress. We should figure

[Lldb-commits] [lldb] r272071 - Now that there are no cycles that cause leaks in the disassembler/instruction classes, we can get rid of the FIXME lines that were working around this issue.

2016-06-07 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Jun 7 18:19:00 2016 New Revision: 272071 URL: http://llvm.org/viewvc/llvm-project?rev=272071&view=rev Log: Now that there are no cycles that cause leaks in the disassembler/instruction classes, we can get rid of the FIXME lines that were working around this issue.

[Lldb-commits] [lldb] r272069 - Fix a memory leak in InstructionLLVMC where it held onto a strong reference to the DisassemblerLLVMC which in turn had a vector of InstructionSP causing the strong cycl

2016-06-07 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Jun 7 17:56:40 2016 New Revision: 272069 URL: http://llvm.org/viewvc/llvm-project?rev=272069&view=rev Log: Fix a memory leak in InstructionLLVMC where it held onto a strong reference to the DisassemblerLLVMC which in turn had a vector of InstructionSP causing the stro

Re: [Lldb-commits] [PATCH] D21032: Eliminate differences in lldbinline-generated Makefiles and ensure they're regenerated every time

2016-06-07 Thread Zachary Turner via lldb-commits
For the diffing issue seems like we should be able to generate makefiles with stable separators. I haven't seen the generation code, but it seems like we could write a function lldbsuite.support.fs.unixpath() that works like normpath but always uses /, never \. Would that fix it? When you say it d

Re: [Lldb-commits] [PATCH] D21032: Eliminate differences in lldbinline-generated Makefiles and ensure they're regenerated every time

2016-06-07 Thread Zachary Turner via lldb-commits
zturner added a comment. For the diffing issue seems like we should be able to generate makefiles with stable separators. I haven't seen the generation code, but it seems like we could write a function lldbsuite.support.fs.unixpath() that works like normpath but always uses /, never \. Would that

Re: [Lldb-commits] [PATCH] D21032: Eliminate differences in lldbinline-generated Makefiles and ensure they're regenerated every time

2016-06-07 Thread Pavel Labath via lldb-commits
labath added subscribers: zturner, labath. labath added a comment. Hi, I have reverted this commit, as it makes a number of assumptions, which are not true on windows. Please see comments for details. If you need help testing out a revised version on windows, let me know. I think Zachary will b

[Lldb-commits] [lldb] r272062 - Revert "Make lldbinline.py regenerate the Makefile each time it builds."

2016-06-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 7 16:29:46 2016 New Revision: 272062 URL: http://llvm.org/viewvc/llvm-project?rev=272062&view=rev Log: Revert "Make lldbinline.py regenerate the Makefile each time it builds." This reverts commit r272024 as it is not windows-compatible. Modified: lldb/trunk/pac

Re: [Lldb-commits] [PATCH] D21088: Don't use SO_REUSEADDR for *client* sockets

2016-06-07 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272041: Don't use SO_REUSEADDR for *client* sockets (authored by labath). Changed prior to commit: http://reviews.llvm.org/D21088?vs=59916&id=59922#toc Repository: rL LLVM http://reviews.llvm.org/D2

[Lldb-commits] [lldb] r272041 - Don't use SO_REUSEADDR for *client* sockets

2016-06-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 7 13:36:38 2016 New Revision: 272041 URL: http://llvm.org/viewvc/llvm-project?rev=272041&view=rev Log: Don't use SO_REUSEADDR for *client* sockets Summary: In the case of client sockets, we are not binding to a specific port, so we should be able to just request a ne

Re: [Lldb-commits] [PATCH] D21088: Don't use SO_REUSEADDR for *client* sockets

2016-06-07 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I am fine with this as long as all test suites on all systems pass. http://reviews.llvm.org/D21088 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] r272036 - LLDB is leaking memory in Editline.cpp on MacOSX.

2016-06-07 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Jun 7 13:16:39 2016 New Revision: 272036 URL: http://llvm.org/viewvc/llvm-project?rev=272036&view=rev Log: LLDB is leaking memory in Editline.cpp on MacOSX. When USE_SETUPTERM_WORKAROUND is enabled, we were calling setupterm() multiple times and leaking memory on eac

[Lldb-commits] [PATCH] D21088: Don't use SO_REUSEADDR for *client* sockets

2016-06-07 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. In the case of client sockets, we are not binding to a specific port, so we should be able to just request a new one. Disregarding refactors,

[Lldb-commits] [lldb] r272024 - Make lldbinline.py regenerate the Makefile each time it builds.

2016-06-07 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Jun 7 12:22:18 2016 New Revision: 272024 URL: http://llvm.org/viewvc/llvm-project?rev=272024&view=rev Log: Make lldbinline.py regenerate the Makefile each time it builds. If a lldbinline test's source file changed language, then the Makefile wasn't updated. This was a p

[Lldb-commits] [PATCH] D21064: [LLDB][MIPS] Fix Emulation of Compact branch and ADDIU instructions

2016-06-07 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, bhushan, jaydeep. nitesh.jain added subscribers: slthakur, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. Herald added subscribers: sdardis, dsanders. This patch contains 2 changes: