Author: jmolenda
Date: Tue May 3 22:09:40 2016
New Revision: 268475
URL: http://llvm.org/viewvc/llvm-project?rev=268475&view=rev
Log:
Add a way for an ObjectFile to indicate that assembly emulation
should not be used for this module -- for use when an ObjectFile
knows that it does not have meanin
jasonmolenda added a subscriber: jasonmolenda.
jasonmolenda added a comment.
fwiw, there are ARM cores that only support thumb - the Cortex M series. I
doubt a windows phone is running one of those low-power chips though. The
importance of the triple used will come in to play when you try to e
Author: jingham
Date: Tue May 3 19:06:23 2016
New Revision: 268467
URL: http://llvm.org/viewvc/llvm-project?rev=268467&view=rev
Log:
You have to call setHasLoadedFieldsFromExternalStorage AFTER calling
the field_begin that starts the copy or it won't do anything.
This causes failures, but only i
Author: spyffe
Date: Tue May 3 15:36:06 2016
New Revision: 268433
URL: http://llvm.org/viewvc/llvm-project?rev=268433&view=rev
Log:
Added a testcase for the ptr_refs tool so we catch if it stops working.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/ptr_refs/
lldb/trun
clayborg added a comment.
I would prefer a fix in the ADB client only if I had to pick. I don't think
anyone else will use this functionality and prefer to the keep the API as
simple as possible for Connection subclasses.
Repository:
rL LLVM
http://reviews.llvm.org/D19533
___
amccarth added a comment.
Zach is hoping to enable tests on our Windows build bot this week, so I'd like
to land this in the next day or two if possible. If not, I can just xfail this
test on Windows and postpone the other fixes until there's more time for a
review.
Thanks.
http://reviews.l
Author: fjricci
Date: Tue May 3 11:31:36 2016
New Revision: 268397
URL: http://llvm.org/viewvc/llvm-project?rev=268397&view=rev
Log:
Split out console and file writing cases in TestCommandScriptImmediateOutput
Summary:
As these are really testing separate issues, they should be run as separate
t
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
This revision is now accepted and ready to land.
I did the same thing back when 3.7 was the current release branch and I think
@clayborg reviewed it at that point.
Without this, we simply can't build the release branch.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268397: Split out console and file writing cases in
TestCommandScriptImmediateOutput (authored by fjricci).
Changed prior to commit:
http://reviews.llvm.org/D19690?vs=55619&id=56020#toc
Repository:
r
labath added a comment.
Good question. I don't really have an opinion on that... Is it just that single
line? (this would be simpler if you uploaded the final version :) ). If it just
that single line, then I think it's fine. If you also need to play with the
ADDITIONAL_VERSIONS and such, then
krytarowski added a comment.
In http://reviews.llvm.org/D15067#419632, @labath wrote:
> Looks good.
Thanks!
Are you accepting it with the patch in `scripts/CMakeLists.txt` as noted in the
comment?
Repository:
rL LLVM
http://reviews.llvm.org/D15067
_
labath added a comment.
This is going to be messier than I expected. I would need to introduce the same
repeat-until-the-buffer-is-full loop into ConnectionGenericFileWindows, which I
don't think is good for code reuse. I see two possibilities:
- go back to the version with a separate function
Author: labath
Date: Tue May 3 09:07:41 2016
New Revision: 268384
URL: http://llvm.org/viewvc/llvm-project?rev=268384&view=rev
Log:
Revert "Add a read_full_buffer argument to ConnectionFileDescriptor::Read"
This reverts commit r268380 as it breaks windows build (I forgot to make
neccesary adjus
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268380: Add a read_full_buffer argument to
ConnectionFileDescriptor::Read (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D19533?vs=55397&id=55986#toc
Repository:
rL LLVM
http
Author: labath
Date: Tue May 3 08:55:53 2016
New Revision: 268380
URL: http://llvm.org/viewvc/llvm-project?rev=268380&view=rev
Log:
Add a read_full_buffer argument to ConnectionFileDescriptor::Read
Summary:
AdbClient was attempting to handle the case where the socket input arrived in
pieces, bu
labath added inline comments.
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:37
@@ -36,3 +36,3 @@
-const uint32_t kReadTimeout = 100; // 1 second
+const uint32_t kReadTimeout = 400; // 4 seconds
const char * kOKAY = "OKAY";
ovyalov wrote:
> I
rengolin added a comment.
In http://reviews.llvm.org/D19604#419284, @sas wrote:
> - We don't use thumb-* triples in lldb as far as I can see. Thumb is handled
> just fine regardless of the triple.
This is a good strategy. Thumb is an instruction set, the "arm-" in the triple
means the Archite
labath accepted this revision.
labath added a comment.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D15067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid added a comment.
@sas
Ideally it should be thumb-* if an environment is thumb only but lldb right now
has some areas where we need to handle this case.
Either you put arm-* and leave it for someone else to correct the problems or
put thumb-* and fix the issues that come up after that.
19 matches
Mail list logo
