granata.enrico added inline comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/command_script_immediate_output/TestCommandScriptImmediateOutput.py:29
@@ -30,1 +28,3 @@
+"""Test that LLDB correctly allows scripted commands to set immediate
output to the
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cameron314 added a comment.
All right, no worries :-) I didn't want to bother anyone.
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This is going to have to be Sean, but his delay can be unpredictable. Keep
pinging every so often until you get a response
On Thu, Apr 28, 2016 at 2:41 PM Cameron wrote:
> cameron314 added a comment.
>
> I'd appreciate if someone could take a look at this when they have a
> moment.
>
>
> http://r
cameron314 added a comment.
I'd appreciate if someone could take a look at this when they have a moment.
http://reviews.llvm.org/D19124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
fjricci created this revision.
fjricci added reviewers: zturner, granata.enrico, clayborg.
fjricci added a subscriber: lldb-commits.
As these are really testing separate issues, they should be run as separate
tests.
http://reviews.llvm.org/D19690
Files:
packages/Python/lldbsuite/test/function
Author: amccarth
Date: Thu Apr 28 15:14:44 2016
New Revision: 267931
URL: http://llvm.org/viewvc/llvm-project?rev=267931&view=rev
Log:
Used llvm_unreached to quite a VC++ compiler warning.
Differential Revision: http://reviews.llvm.org/D19489
Modified:
lldb/trunk/source/Expression/Diagnostic
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267931: Used llvm_unreached to quite a VC++ compiler
warning. (authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D19489?vs=54882&id=55475#toc
Repository:
rL LLVM
http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267923: XFail TestBitfields.py Python API tests. (authored
by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D19680?vs=55464&id=55465#toc
Repository:
rL LLVM
http://reviews.llvm.org/D196
chaoren updated this revision to Diff 55464.
chaoren added a comment.
Clickable links.
http://reviews.llvm.org/D19680
Files:
packages/Python/lldbsuite/test/lang/c/bitfields/TestBitfields.py
Index: packages/Python/lldbsuite/test/lang/c/bitfields/TestBitfields.py
==
Author: chaoren
Date: Thu Apr 28 14:40:19 2016
New Revision: 267923
URL: http://llvm.org/viewvc/llvm-project?rev=267923&view=rev
Log:
XFail TestBitfields.py Python API tests.
Summary:
Started failing after rL267895.
Possibly related to http://llvm.org/pr27510.
Reviewers: labath, tfiala
Subscrib
chaoren created this revision.
chaoren added reviewers: labath, tfiala.
chaoren added a subscriber: lldb-commits.
Started failing after r267895.
Possibly related to llvm.org/pr27510.
http://reviews.llvm.org/D19680
Files:
packages/Python/lldbsuite/test/lang/c/bitfields/TestBitfields.py
Index:
ovyalov added a comment.
LGTM
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:37
@@ -36,3 +36,3 @@
-const uint32_t kReadTimeout = 100; // 1 second
+const uint32_t kReadTimeout = 400; // 4 seconds
const char * kOKAY = "OKAY";
It might be usef
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:103
@@ +102,3 @@
+AddCXXSynthetic(g_category,
lldb_private::formatters::JavaArraySyntheticFrontEn
fjricci added a comment.
I do observe the sendline() behavior on OSX, but only when I cherry-pick these
bug-fixes onto the 3.8 branch. It seems to work fine on master.
http://reviews.llvm.org/D19633
___
lldb-commits mailing list
lldb-commits@lists.
granata.enrico added a comment.
I don't think we are seeing this behavior on OS X (the failure to process
sendline() calls) - but Todd Fiala might know more about that since he keeps a
careful eye over our bots.
Longer term, it would be interesting to find out *why* those issues are
happening.
fjricci added a comment.
Oh I see. I don't think the file-writing is going to work in the PExpect mode
(for some reason, it looks like the sendline calls aren't always being
received/processed correctly by lldb, while runCmd works fine), so it's
probably better to split out into a different tes
granata.enrico added a comment.
Sure, that works. My only concern is that I'd like to keep the current
PExpect-let's test writing to the console and see what happens behavior
Whatever you need to do to split the test is fine by me
http://reviews.llvm.org/D19633
_
Author: kuba.brecka
Date: Thu Apr 28 10:27:10 2016
New Revision: 267894
URL: http://llvm.org/viewvc/llvm-project?rev=267894&view=rev
Log:
Provide location information (file name, line number) in TSan reports about
global variables.
Added:
lldb/trunk/packages/Python/lldbsuite/test/functiona
fjricci added a comment.
Would it be acceptable to split it into two test methods inside the same test
case? Both are testing writing immediate output from a command script, just one
is immediate output to the console and the other is immediate output to a file.
http://reviews.llvm.org/D19633
fjricci abandoned this revision.
fjricci added a comment.
Ok, I'll put up a new revision to split out the test cases.
http://reviews.llvm.org/D19633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: labath
Date: Thu Apr 28 05:42:47 2016
New Revision: 267867
URL: http://llvm.org/viewvc/llvm-project?rev=267867&view=rev
Log:
Remote flaky decorator from TestSignalsAPI on linux
The test seems to pass now, and the test does not seem to be doing anything
unusual, so I don't
expect it to ca
labath updated this revision to Diff 55397.
labath added a comment.
Added proper handling of the timeout after retries, and moved the functionality
into
Connection::Read. I have called the parameter read_full_buffer, as I think that
better reflects
its intended use. I did not want to add a defau
Hi,
this commit broke the build due to a missing declaration of the
APIntWithTypeAndValue. Since this function is not called anywhere, i
suspect some work in progress may have gotten committed with the
actual fix. I'm not sure which one is which, so I reverted the whole
patch. Could you please tak
Author: labath
Date: Thu Apr 28 03:16:19 2016
New Revision: 267861
URL: http://llvm.org/viewvc/llvm-project?rev=267861&view=rev
Log:
Revert "Fixed a bug where const this would cause parser errors about
$__lldb_expr."
This reverts commit r267833 as it breaks the build. It looks like some work in
25 matches
Mail list logo
