[Lldb-commits] [lldb] r266944 - Expressions can run without a process.

2016-04-20 Thread Jim Ingham via lldb-commits
Author: jingham Date: Wed Apr 20 20:46:11 2016 New Revision: 266944 URL: http://llvm.org/viewvc/llvm-project?rev=266944&view=rev Log: Expressions can run without a process. Code was added in ClangExpressionParser::ClangExpressionParser that was calling through the process w/o checking that it wa

[Lldb-commits] [lldb] r266941 - Corrected wording of REPL not available messaging (contained a repeated word and lacked clarity.)

2016-04-20 Thread Kate Stone via lldb-commits
Author: kate Date: Wed Apr 20 19:56:08 2016 New Revision: 266941 URL: http://llvm.org/viewvc/llvm-project?rev=266941&view=rev Log: Corrected wording of REPL not available messaging (contained a repeated word and lacked clarity.) Modified: lldb/trunk/source/Core/Debugger.cpp lldb/trunk/s

[Lldb-commits] [lldb] r266940 - Added command prefix to new help messages to ensure that they're correctly words in REPL mode.

2016-04-20 Thread Kate Stone via lldb-commits
Author: kate Date: Wed Apr 20 19:55:20 2016 New Revision: 266940 URL: http://llvm.org/viewvc/llvm-project?rev=266940&view=rev Log: Added command prefix to new help messages to ensure that they're correctly words in REPL mode. Modified: lldb/trunk/source/Commands/CommandObjectHelp.cpp Modif

[Lldb-commits] [lldb] r266924 - Removed extraneous print() in decorator for enabling module debugging

2016-04-20 Thread Kate Stone via lldb-commits
Author: kate Date: Wed Apr 20 16:59:43 2016 New Revision: 266924 URL: http://llvm.org/viewvc/llvm-project?rev=266924&view=rev Log: Removed extraneous print() in decorator for enabling module debugging Modified: lldb/trunk/packages/Python/lldbsuite/test/decorators.py Modified: lldb/trunk/pac

[Lldb-commits] [lldb] r266922 - When making an array or stuct/union/class elements, make sure the type is complete. If the type isn't complete, complete the type so that clang won't assert and kill yo

2016-04-20 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Wed Apr 20 16:47:56 2016 New Revision: 266922 URL: http://llvm.org/viewvc/llvm-project?rev=266922&view=rev Log: When making an array or stuct/union/class elements, make sure the type is complete. If the type isn't complete, complete the type so that clang won't assert and

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

2016-04-20 Thread Ryan Brown via lldb-commits
ribrdb removed rL LLVM as the repository for this revision. ribrdb updated this revision to Diff 54427. http://reviews.llvm.org/D19273 Files: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp Index: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp =

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

2016-04-20 Thread Ryan Brown via lldb-commits
ribrdb marked an inline comment as done. ribrdb added a comment. I'm not sure how else we could identify the runtime version. I'm hoping to eventually add a producer string that has the version, but this would just be a git commit for development compilers. Repository: rL LLVM http://review

[Lldb-commits] [lldb] r266917 - update Jenkins Xcode buildbot target for r266885

2016-04-20 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Wed Apr 20 15:54:59 2016 New Revision: 266917 URL: http://llvm.org/viewvc/llvm-project?rev=266917&view=rev Log: update Jenkins Xcode buildbot target for r266885 Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r266911 - Fix a bug where LLDB would crash if 'apropos ' was used after spawning an inferior process

2016-04-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Apr 20 15:48:05 2016 New Revision: 266911 URL: http://llvm.org/viewvc/llvm-project?rev=266911&view=rev Log: Fix a bug where LLDB would crash if 'apropos ' was used after spawning an inferior process Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/ap

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-20 Thread Jonas Hahnfeld via lldb-commits
Hahnfeld added a subscriber: Hahnfeld. Hahnfeld added a comment. I think this one is breaking `make check-all` for me because it cannot find and copy `test-pdb-types.exe`. Maybe this has to be checked in? `test-dwarf.exe` and `test-pdb.exe` are in SVN as well... http://reviews.llvm.org/D18848

Re: [Lldb-commits] [PATCH] D19305: Use Process Plugin register indices when communicating with remote

2016-04-20 Thread Francis Ricci via lldb-commits
fjricci added a comment. I can add a comment to the ReadRegister decl. Alternatively, if you think it would be preferable, I could change the parameter name from reg_num to something more descriptive, like remote_reg_num or plugin_reg_num. Or I could change ReadRegister to take a RegisterInfo

Re: [Lldb-commits] [PATCH] D19305: Use Process Plugin register indices when communicating with remote

2016-04-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. As to Jason's comment about a register number class: I wanted RegisterContext classes to be able to statically initialize an array or RegisterInfo structs without having to cal

[Lldb-commits] [lldb] r266886 - Add missing file needed for PDB unittests.

2016-04-20 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Apr 20 11:41:02 2016 New Revision: 266886 URL: http://llvm.org/viewvc/llvm-project?rev=266886&view=rev Log: Add missing file needed for PDB unittests. Added: lldb/trunk/unittests/SymbolFile/PDB/Inputs/test-pdb-types.exe Added: lldb/trunk/unittests/SymbolFile/PDB/Inp

Re: [Lldb-commits] [PATCH] D19288: test infra: move test event-related handling into its own package

2016-04-20 Thread Todd Fiala via lldb-commits
tfiala closed this revision. tfiala added a comment. Closed with commit r266885. @zturner, we can post-commit adjust if you see any improvements. I want to get moving on writing the package-level tests for it. http://reviews.llvm.org/D19288 ___ l

Re: [Lldb-commits] [PATCH] D19288: test infra: move test event-related handling into its own package

2016-04-20 Thread Todd Fiala via lldb-commits
tfiala added a comment. Comment at: packages/Python/lldbsuite/test_event/formatter/curses.py:1 @@ +1,2 @@ +#!/usr/bin/env python + labath wrote: > Is this actually supposed to be executable? No, there is no need for it to be executable. That can come out. Goo

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-20 Thread Zachary Turner via lldb-commits
Hmm, ok i will check it out later. I'm not sure why it's even trying to copy an exe, should be only doing the pdb. Exe isn't even checked in On Wed, Apr 20, 2016 at 8:08 AM Pavel Labath wrote: > labath added a subscriber: labath. > labath added a comment. > > In http://reviews.llvm.org/D18848#406

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-20 Thread Zachary Turner via lldb-commits
zturner added a comment. Hmm, ok i will check it out later. I'm not sure why it's even trying to copy an exe, should be only doing the pdb. Exe isn't even checked in http://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llv

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-20 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. In http://reviews.llvm.org/D18848#406509, @zturner wrote: > I was under the impression the make build was officially unsupported/dead? You can still cmake to generate makefiles (and it does that by default). In any case, this problem s

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-20 Thread Zachary Turner via lldb-commits
zturner added a comment. I was under the impression the make build was officially unsupported/dead? http://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

2016-04-20 Thread Zachary Turner via lldb-commits
I was under the impression the make build was officially unsupported/dead? On Wed, Apr 20, 2016 at 4:26 AM Jonas Hahnfeld wrote: > Hahnfeld added a subscriber: Hahnfeld. > Hahnfeld added a comment. > > I think this one is breaking `make check-all` for me because it cannot > find and copy `test-pd

Re: [Lldb-commits] [PATCH] D19252: Handle invalid values of PLT entry size generated by ld + gcc on arm linux targets.

2016-04-20 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. I don't really have an opinion about CheckPLTSize() function Greg proposes but I definitely want to see some comment explaining why we say that a plt entry less then 4 byte is invalid. http://reviews.llvm.org/D19252 __

Re: [Lldb-commits] [PATCH] D18975: Fix unwind failures when PC points beyond the end of a function

2016-04-20 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. I think having an explicit value for resolve_tail_call_address with a comment is valuable (not sure how much details we need in the comment) so when the next person looking into related unwinding issue he/she will know that changin

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

2016-04-20 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer added a comment. Is it possible to query the version of the go runtime we are currently debugging and decide which symbol we look for instead of using this fallback mechanism? I think it would make the code easier to understand and also ea

Re: [Lldb-commits] [PATCH] D19288: test infra: move test event-related handling into its own package

2016-04-20 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense. Comment at: packages/Python/lldbsuite/test_event/formatter/curses.py:1 @@ +1,2 @@ +#!/usr/bin/env python + Is this actually supposed to be execut

[Lldb-commits] [lldb] r266867 - Fix xfail for test_tilde_home_directory on windows

2016-04-20 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Apr 20 04:54:47 2016 New Revision: 266867 URL: http://llvm.org/viewvc/llvm-project?rev=266867&view=rev Log: Fix xfail for test_tilde_home_directory on windows Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/llvm/TestLLVM.py Modified: lldb/tr

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

2016-04-20 Thread Pavel Labath via lldb-commits
labath added a comment. btw, this does not seem to follow lldb code style (braces on a new line), please reformat that. Repository: rL LLVM http://reviews.llvm.org/D19273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

Re: [Lldb-commits] [PATCH] D19273: Update Go OS Plugin for newer runtimes

2016-04-20 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath accepted this revision. labath added a reviewer: labath. This revision is now accepted and ready to land. Comment at: source/Plugins/OperatingSystem/Go/OperatingSystemGo.cpp:253 @@ +252,3 @@ +ValueObjectSP allgs_sp = FindGlobal(target_